From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1C8B745B60; Thu, 17 Oct 2024 18:44:15 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5FA0240662; Thu, 17 Oct 2024 18:44:13 +0200 (CEST) Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by mails.dpdk.org (Postfix) with ESMTP id 24D4E40662 for ; Thu, 17 Oct 2024 18:44:10 +0200 (CEST) Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-207115e3056so9529065ad.2 for ; Thu, 17 Oct 2024 09:44:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729183449; x=1729788249; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=cHe2qSGYj8LoiOw8mgosd0WhkIdkDAMG8xT8GrocXFM=; b=dv3hikws/uLvtw0C80BXKHCK7MD6IOje57j7XVJ8ZpYX1mA7ijSNTfWCZYyOsOsBaM u0II922xLz7kl0U/fw0t2PvAuhFt2P+RxcvHHpmLGm/zQCFfZuQo3LeAUupTO7m6RwTR PxeRGcge0URTXkjuiIvReUyLYErBW5vlYEv+EcXs9wKY64Gg/H+yTfdFx3ewhnYge68x ddG4P0mAxrpC+GDn4kAzCEdHDGm9CLPvS5DNq5dJVNbSUkoC68kKZCiOrazNNLEEuWxq F5vvHQQCtYOEBCWgA6U53aNs484VOiNJCb1D6UKCnwpyEEVqAsSknWA8LysO7QdV4RIp uy0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729183449; x=1729788249; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cHe2qSGYj8LoiOw8mgosd0WhkIdkDAMG8xT8GrocXFM=; b=aFpyvEMMAfozvXcth0lHg9jHbhgBIpazo4LaLcfK/dSrE5YfrDpkYiq3k7rWDhqY8b 6aevkKhYHXVEAuHrTdgIqME8nooI9mxiszgRI/jt/s0/M5LjKIIB0zdKOPDTXGGzvOj7 V1NOqUSOrz2YFt30MLxzbfT7bDD7SE8SR28MJ6YhOzXjw9qCLdLUKEJepuV66ec+VvCj kfBSFlH4V4fsKwHQ47Kn1C6IgcLIZcKZKJeVd6cO+iv8sN+8Mr4pe4ZUrpXydAz3+5Ca 5jCQaZCzdldf12ig/SG07AK3TuKtZ1luPwbhdUFs4JhtQ1kNkz6jMouhzx7wksrOs3/s ysSA== X-Gm-Message-State: AOJu0YzF+GytNLELwNoZVO7tRIGsU2DmO+YjEDoy0LXsI8b9pxhHwY2a 23vGF8VWy74P9u2FUr1o17i7J80oezXRrw3Sl3VvfuKSC7aGorgdVNWUoCv0hEI= X-Google-Smtp-Source: AGHT+IEDNZq2X4VlFXa6+jtx5YW24R9duXhgga049qWW7W76Io7dDymjj1f+lb0fAJCFLUrj5fxVJQ== X-Received: by 2002:a17:902:f687:b0:20c:7181:51cb with SMTP id d9443c01a7336-20d27ea8547mr119424445ad.18.1729183449121; Thu, 17 Oct 2024 09:44:09 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20d17fa5d55sm46684745ad.109.2024.10.17.09.44.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Oct 2024 09:44:08 -0700 (PDT) Date: Thu, 17 Oct 2024 09:41:26 -0700 From: Stephen Hemminger To: Howard Wang Cc: , Subject: Re: [PATCH v2 00/18] net/r8169: add r8169 pmd to dpdk Message-ID: <20241017094126.0514df4b@hermes.local> In-Reply-To: <20241017063200.26101-1-howard_wang@realsil.com.cn> References: <20241017063200.26101-1-howard_wang@realsil.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 17 Oct 2024 14:31:42 +0800 Howard Wang wrote: > PATCH v2: modify some code as suggested by the maintainer. > > Howard Wang (18): > net/r8169: add PMD driver skeleton > net/r8169: add logging structure > net/r8169: add hardware registers access routines > net/r8169: implement core logic for Tx/Rx > net/r8169: add support for hw config > net/r8169: add phy registers access routines > net/r8169: add support for hardware operations > net/r8169: add support for phy configuration > net/r8169: add support for hw initialization > net/r8169: add link status and interrupt management > net/r8169: implement Rx path > net/r8169: implement Tx path > net/r8169: implement device statistics > net/r8169: implement promisc and allmulti modes > net/r8169: impelment MTU configuration > net/r8169: add support for getting fw version > net/r8169: add driver_start and driver_stop > doc/guides/nics: add documents for r8169 pmd > > MAINTAINERS | 9 + > doc/guides/nics/features/r8169.ini | 32 + > doc/guides/nics/index.rst | 1 + > doc/guides/nics/r8169.rst | 17 + > drivers/net/meson.build | 1 + > drivers/net/r8169/base/rtl8125a.c | 413 ++++ > drivers/net/r8169/base/rtl8125a_mcu.c | 1586 +++++++++++++ > drivers/net/r8169/base/rtl8125a_mcu.h | 15 + > drivers/net/r8169/base/rtl8125b.c | 391 ++++ > drivers/net/r8169/base/rtl8125b_mcu.c | 1068 +++++++++ > drivers/net/r8169/base/rtl8125b_mcu.h | 15 + > drivers/net/r8169/base/rtl8125bp.c | 116 + > drivers/net/r8169/base/rtl8125bp_mcu.c | 289 +++ > drivers/net/r8169/base/rtl8125bp_mcu.h | 14 + > drivers/net/r8169/base/rtl8125d.c | 245 ++ > drivers/net/r8169/base/rtl8125d_mcu.c | 618 +++++ > drivers/net/r8169/base/rtl8125d_mcu.h | 14 + > drivers/net/r8169/base/rtl8126a.c | 534 +++++ > drivers/net/r8169/base/rtl8126a_mcu.c | 2994 ++++++++++++++++++++++++ > drivers/net/r8169/base/rtl8126a_mcu.h | 17 + > drivers/net/r8169/meson.build | 21 + > drivers/net/r8169/r8169_base.h | 625 +++++ > drivers/net/r8169/r8169_dash.c | 230 ++ > drivers/net/r8169/r8169_dash.h | 58 + > drivers/net/r8169/r8169_ethdev.c | 812 +++++++ > drivers/net/r8169/r8169_ethdev.h | 146 ++ > drivers/net/r8169/r8169_hw.c | 1590 +++++++++++++ > drivers/net/r8169/r8169_hw.h | 115 + > drivers/net/r8169/r8169_logs.h | 53 + > drivers/net/r8169/r8169_phy.c | 898 +++++++ > drivers/net/r8169/r8169_phy.h | 148 ++ > drivers/net/r8169/r8169_rxtx.c | 1481 ++++++++++++ > 32 files changed, 14566 insertions(+) > create mode 100644 doc/guides/nics/features/r8169.ini > create mode 100644 doc/guides/nics/r8169.rst > create mode 100644 drivers/net/r8169/base/rtl8125a.c > create mode 100644 drivers/net/r8169/base/rtl8125a_mcu.c > create mode 100644 drivers/net/r8169/base/rtl8125a_mcu.h > create mode 100644 drivers/net/r8169/base/rtl8125b.c > create mode 100644 drivers/net/r8169/base/rtl8125b_mcu.c > create mode 100644 drivers/net/r8169/base/rtl8125b_mcu.h > create mode 100644 drivers/net/r8169/base/rtl8125bp.c > create mode 100644 drivers/net/r8169/base/rtl8125bp_mcu.c > create mode 100644 drivers/net/r8169/base/rtl8125bp_mcu.h > create mode 100644 drivers/net/r8169/base/rtl8125d.c > create mode 100644 drivers/net/r8169/base/rtl8125d_mcu.c > create mode 100644 drivers/net/r8169/base/rtl8125d_mcu.h > create mode 100644 drivers/net/r8169/base/rtl8126a.c > create mode 100644 drivers/net/r8169/base/rtl8126a_mcu.c > create mode 100644 drivers/net/r8169/base/rtl8126a_mcu.h > create mode 100644 drivers/net/r8169/meson.build > create mode 100644 drivers/net/r8169/r8169_base.h > create mode 100644 drivers/net/r8169/r8169_dash.c > create mode 100644 drivers/net/r8169/r8169_dash.h > create mode 100644 drivers/net/r8169/r8169_ethdev.c > create mode 100644 drivers/net/r8169/r8169_ethdev.h > create mode 100644 drivers/net/r8169/r8169_hw.c > create mode 100644 drivers/net/r8169/r8169_hw.h > create mode 100644 drivers/net/r8169/r8169_logs.h > create mode 100644 drivers/net/r8169/r8169_phy.c > create mode 100644 drivers/net/r8169/r8169_phy.h > create mode 100644 drivers/net/r8169/r8169_rxtx.c > Lots of whitespace errors when test applying this patch. Applying: net/r8169: add PMD driver skeleton /home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:56: new blank line at EOF. + /home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:78: new blank line at EOF. + /home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:263: new blank line at EOF. + /home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:310: new blank line at EOF. + warning: 4 lines add whitespace errors. Applying: net/r8169: add logging structure /home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:54: new blank line at EOF. + /home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:113: new blank line at EOF. + warning: 2 lines add whitespace errors. Applying: net/r8169: add hardware registers access routines /home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:539: new blank line at EOF. + /home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:574: new blank line at EOF. + warning: 2 lines add whitespace errors. Applying: net/r8169: implement core logic for Tx/Rx /home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:142: new blank line at EOF. + warning: 1 line adds whitespace errors. Applying: net/r8169: add support for hw config /home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:938: new blank line at EOF. + /home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:1020: new blank line at EOF. + /home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:1047: new blank line at EOF. + warning: 3 lines add whitespace errors. Applying: net/r8169: add phy registers access routines /home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:245: new blank line at EOF. + warning: 1 line adds whitespace errors. Applying: net/r8169: add support for hardware operations /home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:460: new blank line at EOF. + /home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:2052: new blank line at EOF. + /home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:2073: new blank line at EOF. + /home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:2470: new blank line at EOF. + /home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:3544: new blank line at EOF. + warning: squelched 12 whitespace errors warning: 17 lines add whitespace errors. Applying: net/r8169: add support for phy configuration /home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:512: new blank line at EOF. + warning: 1 line adds whitespace errors. Applying: net/r8169: add support for hw initialization /home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:189: new blank line at EOF. + /home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:230: new blank line at EOF. + /home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:978: new blank line at EOF. + warning: 3 lines add whitespace errors. Applying: net/r8169: add link status and interrupt management /home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:600: new blank line at EOF. + warning: 1 line adds whitespace errors. Applying: net/r8169: implement Rx path /home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:1030: new blank line at EOF. + warning: 1 line adds whitespace errors. Applying: net/r8169: implement Tx path Applying: net/r8169: implement device statistics /home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:225: new blank line at EOF. + warning: 1 line adds whitespace errors. Applying: net/r8169: implement promisc and allmulti modes Applying: net/r8169: impelment MTU configuration Applying: net/r8169: add support for getting fw version Applying: net/r8169: add driver_start and driver_stop /home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:205: new blank line at EOF. + warning: 1 line adds whitespace errors. Applying: doc/guides/nics: add documents for r8169 pmd