From: Stephen Hemminger <stephen@networkplumber.org>
To: Howard Wang <howard_wang@realsil.com.cn>
Cc: <dev@dpdk.org>, <pro_nic_dpdk@realtek.com>
Subject: Re: [PATCH v2 18/18] doc/guides/nics: add documents for r8169 pmd
Date: Thu, 17 Oct 2024 09:43:43 -0700 [thread overview]
Message-ID: <20241017094343.798da31a@hermes.local> (raw)
In-Reply-To: <20241017063200.26101-19-howard_wang@realsil.com.cn>
On Thu, 17 Oct 2024 14:32:00 +0800
Howard Wang <howard_wang@realsil.com.cn> wrote:
> Signed-off-by: Howard Wang <howard_wang@realsil.com.cn>
> ---
> MAINTAINERS | 2 ++
> doc/guides/nics/features/r8169.ini | 32 ++++++++++++++++++++++++++++++
> doc/guides/nics/index.rst | 1 +
> doc/guides/nics/r8169.rst | 17 ++++++++++++++++
> 4 files changed, 52 insertions(+)
> create mode 100644 doc/guides/nics/features/r8169.ini
> create mode 100644 doc/guides/nics/r8169.rst
Build is failing because the tx_tail field is using stdatomic but
the field is not marked with atomic attribute.
Think you need:
diff --git a/drivers/net/r8169/r8169_rxtx.c b/drivers/net/r8169/r8169_rxtx.c
index b1a1eea033..97e0195995 100644
--- a/drivers/net/r8169/r8169_rxtx.c
+++ b/drivers/net/r8169/r8169_rxtx.c
@@ -76,7 +76,7 @@ struct rtl_tx_queue {
struct rtl_hw *hw;
uint64_t hw_ring_phys_addr;
uint16_t nb_tx_desc;
- uint32_t tx_tail;
+ RTE_ATOMIC(uint32_t) tx_tail;
uint16_t tx_head;
uint16_t queue_id;
uint16_t port_id;
next prev parent reply other threads:[~2024-10-17 16:44 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-17 6:31 [PATCH v2 00/18] net/r8169: add r8169 pmd to dpdk Howard Wang
2024-10-17 6:31 ` [PATCH v2 01/18] net/r8169: add PMD driver skeleton Howard Wang
2024-10-17 16:30 ` Stephen Hemminger
2024-10-17 6:31 ` [PATCH v2 02/18] net/r8169: add logging structure Howard Wang
2024-10-17 16:32 ` Stephen Hemminger
2024-10-17 6:31 ` [PATCH v2 03/18] net/r8169: add hardware registers access routines Howard Wang
2024-10-17 16:34 ` Stephen Hemminger
2024-10-18 3:41 ` 答复: " 王颢
2024-10-17 6:31 ` [PATCH v2 04/18] net/r8169: implement core logic for Tx/Rx Howard Wang
2024-10-17 6:31 ` [PATCH v2 05/18] net/r8169: add support for hw config Howard Wang
2024-10-17 16:35 ` Stephen Hemminger
2024-10-18 5:45 ` 答复: " 王颢
2024-10-17 6:31 ` [PATCH v2 06/18] net/r8169: add phy registers access routines Howard Wang
2024-10-17 6:31 ` [PATCH v2 07/18] net/r8169: add support for hardware operations Howard Wang
2024-10-17 6:31 ` [PATCH v2 08/18] net/r8169: add support for phy configuration Howard Wang
2024-10-17 6:31 ` [PATCH v2 09/18] net/r8169: add support for hw initialization Howard Wang
2024-10-17 6:31 ` [PATCH v2 10/18] net/r8169: add link status and interrupt management Howard Wang
2024-10-17 6:31 ` [PATCH v2 11/18] net/r8169: implement Rx path Howard Wang
2024-10-17 16:11 ` Stephen Hemminger
2024-10-18 2:02 ` 答复: " 王颢
2024-10-17 6:31 ` [PATCH v2 12/18] net/r8169: implement Tx path Howard Wang
2024-10-17 8:13 ` [PATCH " Howard Wang
2024-10-17 6:31 ` [PATCH v2 13/18] net/r8169: implement device statistics Howard Wang
2024-10-17 6:31 ` [PATCH v2 14/18] net/r8169: implement promisc and allmulti modes Howard Wang
2024-10-17 6:31 ` [PATCH v2 15/18] net/r8169: impelment MTU configuration Howard Wang
2024-10-17 6:31 ` [PATCH v2 16/18] net/r8169: add support for getting fw version Howard Wang
2024-10-17 6:31 ` [PATCH v2 17/18] net/r8169: add driver_start and driver_stop Howard Wang
2024-10-17 6:32 ` [PATCH v2 18/18] doc/guides/nics: add documents for r8169 pmd Howard Wang
2024-10-17 16:43 ` Stephen Hemminger [this message]
2024-10-17 16:41 ` [PATCH v2 00/18] net/r8169: add r8169 pmd to dpdk Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241017094343.798da31a@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=howard_wang@realsil.com.cn \
--cc=pro_nic_dpdk@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).