From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2DE4A45B60; Thu, 17 Oct 2024 18:44:06 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 20BDD4025F; Thu, 17 Oct 2024 18:44:06 +0200 (CEST) Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by mails.dpdk.org (Postfix) with ESMTP id 06A804021E for ; Thu, 17 Oct 2024 18:44:05 +0200 (CEST) Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-20b5affde14so8347765ad.3 for ; Thu, 17 Oct 2024 09:44:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729183444; x=1729788244; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=POJjIABdqjIpyGilMj5+DOxEpudsus3ZW085rAfZZc8=; b=Exfhf3zIHDen+kWI5QJOFOCeHwj+iLHXLn9QtJDFyTJgxwnwrI/Nz/MzuN8QGz+10p sqzR3hkxFnqTpwFWOBgQpO3PDqGp5wd34p0gJBT9vpLdiWgu3Sdz4vuNbvf8Q5DDwNpN mjDzMPScYo5fQ78Dj3LPV+VF9uLBaDvwgY6CBAlLxPRYKcIawcO7xcAFrCsaDxUtOyc+ qrtrlTLg7OkzWcfYKH+W92kTo2ww+U8/Y0oQ/Xfat7aPFTLcjAJldR0qe8Wapgw0Mtt6 SnilyxLKODk+qkbXUvAkp0S6mG5jPjFYgc+WpQFRo94wB1cmMI/yIVcwvpOi1BiBPZHV R3nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729183444; x=1729788244; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=POJjIABdqjIpyGilMj5+DOxEpudsus3ZW085rAfZZc8=; b=Gb4qKmSCiuWlY9oQguA+/CpqNdgCD1rNfW0gZWNz25fy9d1iFbFiyWXFyDG9uNxkAG e5j+Xl0WxFpOUGfUC7541gjJqzWleGDxj7lSItG5V+0uojcN/SKFotAFpoqlNBBmjl65 AowV8yjqnlizLUPMarQAJRDSM4pzgBKUhz4Dp2qwQi7IB0taS4j2xD1h8ZEbxwFgA/Hh 5atRximtT2qPIdVqLC5nGK6/DZaovK6TlLS0P/NE3epc8Uzskrfq9aWu0BSGQK+dK0yv fvh1HPWk6cscPX0o+u43/ax4F1x8zPkEOxNqKObHcQW2QfV1vl6vm38BE/hvQO5WYBLt 6y7w== X-Gm-Message-State: AOJu0Yx1A8LB/PXmycEy4Ftdd7QGNKGnIJ7tei1zWtxKTHtqCCj/Zkq9 V8xZiKkDTcQSTklund/tU03UA4gVMor82u2dbdpm9ZSu9bwEH0z3yqC6WcEfXx4= X-Google-Smtp-Source: AGHT+IHeU+37H8eNUBnZpYppx1Ix4Zx9XEhEOplcmTzpv1FzhWhoq631BZqE/TVYp+xcpv0YFuKqCw== X-Received: by 2002:a17:902:f687:b0:20c:7181:51cb with SMTP id d9443c01a7336-20d27ea8547mr119420705ad.18.1729183444023; Thu, 17 Oct 2024 09:44:04 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20d17fa5d55sm46684745ad.109.2024.10.17.09.44.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Oct 2024 09:44:03 -0700 (PDT) Date: Thu, 17 Oct 2024 09:43:43 -0700 From: Stephen Hemminger To: Howard Wang Cc: , Subject: Re: [PATCH v2 18/18] doc/guides/nics: add documents for r8169 pmd Message-ID: <20241017094343.798da31a@hermes.local> In-Reply-To: <20241017063200.26101-19-howard_wang@realsil.com.cn> References: <20241017063200.26101-1-howard_wang@realsil.com.cn> <20241017063200.26101-19-howard_wang@realsil.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 17 Oct 2024 14:32:00 +0800 Howard Wang wrote: > Signed-off-by: Howard Wang > --- > MAINTAINERS | 2 ++ > doc/guides/nics/features/r8169.ini | 32 ++++++++++++++++++++++++++++++ > doc/guides/nics/index.rst | 1 + > doc/guides/nics/r8169.rst | 17 ++++++++++++++++ > 4 files changed, 52 insertions(+) > create mode 100644 doc/guides/nics/features/r8169.ini > create mode 100644 doc/guides/nics/r8169.rst Build is failing because the tx_tail field is using stdatomic but the field is not marked with atomic attribute. Think you need: diff --git a/drivers/net/r8169/r8169_rxtx.c b/drivers/net/r8169/r8169_rxtx.c index b1a1eea033..97e0195995 100644 --- a/drivers/net/r8169/r8169_rxtx.c +++ b/drivers/net/r8169/r8169_rxtx.c @@ -76,7 +76,7 @@ struct rtl_tx_queue { struct rtl_hw *hw; uint64_t hw_ring_phys_addr; uint16_t nb_tx_desc; - uint32_t tx_tail; + RTE_ATOMIC(uint32_t) tx_tail; uint16_t tx_head; uint16_t queue_id; uint16_t port_id;