From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id D18A645B60;
	Thu, 17 Oct 2024 19:17:15 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id A8C3E4025F;
	Thu, 17 Oct 2024 19:17:15 +0200 (CEST)
Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com
 [209.85.215.176])
 by mails.dpdk.org (Postfix) with ESMTP id DBB3D4021E
 for <dev@dpdk.org>; Thu, 17 Oct 2024 19:17:13 +0200 (CEST)
Received: by mail-pg1-f176.google.com with SMTP id
 41be03b00d2f7-7ae3d7222d4so903925a12.3
 for <dev@dpdk.org>; Thu, 17 Oct 2024 10:17:13 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729185433;
 x=1729790233; darn=dpdk.org; 
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:subject:cc:to:from:date:from:to:cc:subject:date
 :message-id:reply-to;
 bh=2xsf8SRNO/jdZipoLxOmRhloM/IoPO/TJcp06sUNhTI=;
 b=Hd1mrqKlSW7SHHtmyqlzF3e3I/1SoKQtlH/hSzFPTsO+5yhuNF/+2CK3/OiFCJiHrI
 KtPAUXI6+JmQ2A30lXLyDgwTXIMMg8/uzAEfVrvMk+Jg2IR6kwo1afuG41w4/64NtCu+
 esRvparFip5XPn7W2wQH6YBhpaFSAf7PHuFMTBjh18TFclOpOSslH7vw7VJcVwjqaEeW
 gr7ttrOoxdLnW0T0Azn0C1IA85XF3jas6fsb+KA9JuF/+e/3eKz8RrtjHV9LwuDBibJh
 xfmQICkpEYO60z2vQeTzRafu1VGqDVyb9oZh1XhF+VOYAk2GRIh6jXQqDQ0MQE64p8HN
 d+9Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1729185433; x=1729790233;
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=2xsf8SRNO/jdZipoLxOmRhloM/IoPO/TJcp06sUNhTI=;
 b=dj6t/Ar0iRd/59MCsrOLuORq58TJLBaUHY7R3tn7+J6zfQcrIIxe5u+m94jkKyf6S7
 ZljbaEM96/SDFH0kbSnd7ZHG8opjOjGDIrXV0yXo4aTFJlGVUoo2cVHFIvZtMkcWkDyR
 gRaaEWgqkWj+DZXgcmWIpcpG0AxujkWX9QHu8VBJMvzY9bXcTD9MHRlBnN7rwIVQhy1i
 sux0rnHqdnPNbJr6IkW/aJUMRAF8S4Qghhu9s1mlMv518BUzvKhVdU+64deTXCKlBtp7
 EOFdy4frnT/8MvM1S2sxH/TwxlfJjMBlN+2u9S/D8wETtBYKCfkwPVweKr/VAQ5GKlBg
 AnEQ==
X-Gm-Message-State: AOJu0YywfydWM4apHiUNmjh3GjmMlrBCsW/Q36amqgviy/EeB5UJMAPz
 9IKFadcCkJnkdyE9X5Z1lqhmZ6/864b3jBILkP+sQXTBNkET6GH0r2WhmIvt1Cs=
X-Google-Smtp-Source: AGHT+IGDzreyR1Xpu9RUDX8ChvmNJ4ZO52JodS81XaDa5OgMnx+SE78ZeDFVLsQFBL9ZxC3jFgFMmA==
X-Received: by 2002:a05:6a20:b920:b0:1d9:bce:17be with SMTP id
 adf61e73a8af0-1d90bce1827mr6526222637.11.1729185432945; 
 Thu, 17 Oct 2024 10:17:12 -0700 (PDT)
Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226])
 by smtp.gmail.com with ESMTPSA id
 d2e1a72fcca58-71e774cb61esm4980933b3a.162.2024.10.17.10.17.12
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 17 Oct 2024 10:17:12 -0700 (PDT)
Date: Thu, 17 Oct 2024 10:17:10 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, Tyler Retzlaff <roretzla@linux.microsoft.com>, Morten
 =?UTF-8?B?QnLDuHJ1cA==?= <mb@smartsharesystems.com>, Bruce Richardson
 <bruce.richardson@intel.com>, Chengwen Feng <fengchengwen@huawei.com>
Subject: Re: [PATCH v26 05/15] eal: do not duplicate rte_init_alert() messages
Message-ID: <20241017101710.739c8939@hermes.local>
In-Reply-To: <CAJFAV8z1-PagjJ7Wc5SBeJ2SgMkZsRx2n-J9uRaA27Qmjg-0Pw@mail.gmail.com>
References: <20200814173441.23086-1-stephen@networkplumber.org>
 <20241016202343.190653-1-stephen@networkplumber.org>
 <20241016202343.190653-6-stephen@networkplumber.org>
 <CAJFAV8z1-PagjJ7Wc5SBeJ2SgMkZsRx2n-J9uRaA27Qmjg-0Pw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Thu, 17 Oct 2024 18:47:54 +0200
David Marchand <david.marchand@redhat.com> wrote:

> > diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c
> > index 40d750ed0d..c53a051405 100644
> > --- a/lib/eal/linux/eal.c
> > +++ b/lib/eal/linux/eal.c
> > @@ -830,8 +830,7 @@ rte_eal_iopl_init(void)
> >
> >  static void rte_eal_init_alert(const char *msg)
> >  {
> > -       fprintf(stderr, "EAL: FATAL: %s\n", msg);
> > -       EAL_LOG(ERR, "%s", msg);
> > +       EAL_LOG(ALERT, "%s", msg);
> >  }
> >
> >  /*  
> 
> Any reason why Windows was not changed?
> 
> I can add the missing bit when applying.


No reason that Windows was not changed, just forgot about it.