DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>
Subject: [PATCH 0/6] Reduce scope address-of-packed-member warning
Date: Thu, 17 Oct 2024 15:22:07 +0100	[thread overview]
Message-ID: <20241017142214.1669370-1-bruce.richardson@intel.com> (raw)

The warning for address-of-packed-member was being disabled globally in
DPDK.  While for drivers which need to access hardware-defined
data-structures the use of packed may make sense, for normal libs and
applications the use of packed data should be generally avoided.

This patchset initially applies some fixes for cases where we are
unnecessarily causing the warning to trigger. Thereafter the 6th patch
removes the global enabling of the warning and replaces it with more
selective disabling for drivers and for a couple of other components
which have not yet been fixed.

Bruce Richardson (6):
  ip_frag: remove use of unaligned variable
  efd: remove unnecessary packed attributes
  bus/ifpga: remove packed attribute
  pipeline: remove packed attribute
  net: add smaller IPv4 cksum function for simple cases
  build: limit scope of packed member warning disabling

 app/test-eventdev/test_pipeline_common.c | 25 +-----------
 app/test-pmd/icmpecho.c                  | 23 +----------
 app/test-pmd/txonly.c                    | 22 +----------
 app/test/packet_burst_generator.c        | 49 +-----------------------
 app/test/test_reassembly_perf.c          | 29 +-------------
 config/meson.build                       |  1 -
 drivers/bus/ifpga/bus_ifpga_driver.h     |  2 +-
 drivers/meson.build                      |  9 +++--
 examples/ipsec-secgw/meson.build         |  6 +++
 lib/efd/rte_efd.c                        |  4 +-
 lib/ip_frag/rte_ipv4_reassembly.c        |  4 +-
 lib/net/rte_ip.h                         | 33 ++++++++++++++++
 lib/pipeline/rte_table_action.c          |  2 +-
 lib/vhost/meson.build                    |  5 ++-
 14 files changed, 60 insertions(+), 154 deletions(-)

--
2.43.0


             reply	other threads:[~2024-10-17 14:22 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-17 14:22 Bruce Richardson [this message]
2024-10-17 14:22 ` [PATCH 1/6] ip_frag: remove use of unaligned variable Bruce Richardson
2024-10-17 16:26   ` Stephen Hemminger
2024-10-17 16:42   ` Konstantin Ananyev
2024-10-17 14:22 ` [PATCH 2/6] efd: remove unnecessary packed attributes Bruce Richardson
2024-10-17 16:22   ` Stephen Hemminger
2024-10-17 14:22 ` [PATCH 3/6] bus/ifpga: remove packed attribute Bruce Richardson
2024-10-17 14:52   ` Xu, Rosen
2024-10-17 16:25   ` Stephen Hemminger
2024-10-17 14:22 ` [PATCH 4/6] pipeline: " Bruce Richardson
2024-10-17 14:24   ` Bruce Richardson
2024-10-17 16:25   ` Stephen Hemminger
2024-10-17 14:22 ` [PATCH 5/6] net: add smaller IPv4 cksum function for simple cases Bruce Richardson
2024-10-17 16:24   ` Stephen Hemminger
2024-10-17 17:01     ` Bruce Richardson
2024-10-17 17:15   ` Morten Brørup
2024-10-17 19:03     ` Bruce Richardson
2024-10-17 19:34       ` Stephen Hemminger
2024-10-18  0:32         ` Morten Brørup
2024-10-17 14:22 ` [PATCH 6/6] build: limit scope of packed member warning disabling Bruce Richardson
2024-10-17 16:21 ` [PATCH 0/6] Reduce scope address-of-packed-member warning Stephen Hemminger
2024-10-17 17:02   ` Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241017142214.1669370-1-bruce.richardson@intel.com \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).