From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3DD9145B5F; Thu, 17 Oct 2024 16:22:34 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D38FB4025F; Thu, 17 Oct 2024 16:22:33 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) by mails.dpdk.org (Postfix) with ESMTP id 65F1F4021E for ; Thu, 17 Oct 2024 16:22:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1729174953; x=1760710953; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=1nG5jWe9rGj8HqcR8L2g3LwQ1mBaXF6J6qrRdl66/94=; b=CmLHoKCd5jNzRIX9F46e+iEL3MEZV/AJe2zMfH2cTvCVOj/YTJLdIl+U pOvzb6i7idaOaL+/m/9t2SnT4wCo6mre5s5GWgTp0/ELHUlS092azkeCH 5jub/2YJNLJXFM5ZT/Y5JxqGWD1Zpp5254vMGqpd7hMNfUBpTjcY4gyxe 00N3rV5iAydrH1EJYmypm5UDl3pjpUVNXdMgXHDyXdWk8IZEsTeAAcHQC zOGhY8o0gOYRf6p959oskY6VajOV+0LPf6/AFeeHm3+vjwhY+QEPochm7 ZKzPVlOFBmui1HWJCushWV597hHRrQGCtxC2hPMWdSon8Y5Dy52nOdtyI Q==; X-CSE-ConnectionGUID: dKApfnKRR8y8x3vvtswa4w== X-CSE-MsgGUID: 7dvMYyHEQxqS9x++I41HCw== X-IronPort-AV: E=McAfee;i="6700,10204,11228"; a="28131717" X-IronPort-AV: E=Sophos;i="6.11,211,1725346800"; d="scan'208";a="28131717" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Oct 2024 07:22:31 -0700 X-CSE-ConnectionGUID: UuA6D9fqTOiOAO7ys9X6Xg== X-CSE-MsgGUID: 3NC+zrEETaS9rLojbiMeyA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,211,1725346800"; d="scan'208";a="101867828" Received: from unknown (HELO silpixa00401385.ir.intel.com) ([10.237.214.25]) by fmviesa002.fm.intel.com with ESMTP; 17 Oct 2024 07:22:30 -0700 From: Bruce Richardson To: dev@dpdk.org Cc: Bruce Richardson Subject: [PATCH 0/6] Reduce scope address-of-packed-member warning Date: Thu, 17 Oct 2024 15:22:07 +0100 Message-ID: <20241017142214.1669370-1-bruce.richardson@intel.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The warning for address-of-packed-member was being disabled globally in DPDK. While for drivers which need to access hardware-defined data-structures the use of packed may make sense, for normal libs and applications the use of packed data should be generally avoided. This patchset initially applies some fixes for cases where we are unnecessarily causing the warning to trigger. Thereafter the 6th patch removes the global enabling of the warning and replaces it with more selective disabling for drivers and for a couple of other components which have not yet been fixed. Bruce Richardson (6): ip_frag: remove use of unaligned variable efd: remove unnecessary packed attributes bus/ifpga: remove packed attribute pipeline: remove packed attribute net: add smaller IPv4 cksum function for simple cases build: limit scope of packed member warning disabling app/test-eventdev/test_pipeline_common.c | 25 +----------- app/test-pmd/icmpecho.c | 23 +---------- app/test-pmd/txonly.c | 22 +---------- app/test/packet_burst_generator.c | 49 +----------------------- app/test/test_reassembly_perf.c | 29 +------------- config/meson.build | 1 - drivers/bus/ifpga/bus_ifpga_driver.h | 2 +- drivers/meson.build | 9 +++-- examples/ipsec-secgw/meson.build | 6 +++ lib/efd/rte_efd.c | 4 +- lib/ip_frag/rte_ipv4_reassembly.c | 4 +- lib/net/rte_ip.h | 33 ++++++++++++++++ lib/pipeline/rte_table_action.c | 2 +- lib/vhost/meson.build | 5 ++- 14 files changed, 60 insertions(+), 154 deletions(-) -- 2.43.0