From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D14A845B5F; Thu, 17 Oct 2024 16:22:45 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F389640652; Thu, 17 Oct 2024 16:22:37 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) by mails.dpdk.org (Postfix) with ESMTP id B0AE5402ED for ; Thu, 17 Oct 2024 16:22:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1729174955; x=1760710955; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Y1VI/wwwc0lrY2TYzj5hdeulL4Dz0LnGvy20WCgcpoM=; b=m76IrDH6dM51jgN92QRMXqZQSEESNNLxPSGrOFGJhrxvAPC0K2ibCg05 fTap87umz0RVmv/oEX5jGyJyAXMs4Bi+ofw6xOZEV8bAcTb9SN0iQG7Sb NZrRXl5yCneYC4d+Pc0v8cdVdkn/aW/m7Y/b53ydYFEDlXtxn8rGRflED gX49hPakYht5l1rA7BB1b2McuUXJfWZdUZYVwm57Chb8WaeruTL4d9c2j I5qy6CdbdUJ92OLW5Au5RU9Jq80dmHNNgSN2c5fgy/+YNlby6PEFc63dx ekxjBtwx8dSFva2OceloRv2GB2kcqGAJJJyKEHV4lYqs54BaD0VYzNng1 A==; X-CSE-ConnectionGUID: ohDiHmo8TBOFJENG86Rz9A== X-CSE-MsgGUID: 4DbERZBHSVi/lqHFZZP9eA== X-IronPort-AV: E=McAfee;i="6700,10204,11228"; a="28131723" X-IronPort-AV: E=Sophos;i="6.11,211,1725346800"; d="scan'208";a="28131723" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Oct 2024 07:22:34 -0700 X-CSE-ConnectionGUID: 9SY6r+IjRgW+gOJLtW2iOA== X-CSE-MsgGUID: H+/5jGZjQESbH3orAvwaWw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,211,1725346800"; d="scan'208";a="101867838" Received: from unknown (HELO silpixa00401385.ir.intel.com) ([10.237.214.25]) by fmviesa002.fm.intel.com with ESMTP; 17 Oct 2024 07:22:32 -0700 From: Bruce Richardson To: dev@dpdk.org Cc: Bruce Richardson , Byron Marohn , Yipeng Wang Subject: [PATCH 2/6] efd: remove unnecessary packed attributes Date: Thu, 17 Oct 2024 15:22:09 +0100 Message-ID: <20241017142214.1669370-3-bruce.richardson@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241017142214.1669370-1-bruce.richardson@intel.com> References: <20241017142214.1669370-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The structure "efd_online_group_entry" only consists of values which are typedefs of "uint16_t", so packing the structure has no effect. The "efd_online_chunk" structure has a mix of "uint8_t" and the "efd_online_group_entry" struct, i.e. uint16_t values, but since the first, uint8_t, member array is of even size, the packed attribute does not affect the structure layout. Removing these packed attributes allows the library to compile cleanly without "-Wno-address-of-packed-member" compiler flag. Signed-off-by: Bruce Richardson --- lib/efd/rte_efd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/efd/rte_efd.c b/lib/efd/rte_efd.c index d3b732f2e8..3cbb3c2719 100644 --- a/lib/efd/rte_efd.c +++ b/lib/efd/rte_efd.c @@ -212,7 +212,7 @@ struct efd_offline_chunk_rules { struct efd_online_group_entry { efd_hashfunc_t hash_idx[RTE_EFD_VALUE_NUM_BITS]; efd_lookuptbl_t lookup_table[RTE_EFD_VALUE_NUM_BITS]; -} __rte_packed; +}; /** * A single chunk record, containing EFD_TARGET_CHUNK_NUM_RULES rules. @@ -228,7 +228,7 @@ struct efd_online_chunk { struct efd_online_group_entry groups[EFD_CHUNK_NUM_GROUPS]; /**< Array of all the groups in the chunk. */ -} __rte_packed; +}; /** * EFD table structure -- 2.43.0