From: Stephen Hemminger <stephen@networkplumber.org>
To: Ajit Khaparde <ajit.khaparde@broadcom.com>
Cc: dev@dpdk.org, thomas@monjalon.net, eagostini@nvidia.com
Subject: Re: [PATCH 2/2] gpu/cuda: extend cuda code to get PA of GPU
Date: Thu, 17 Oct 2024 15:40:22 -0700 [thread overview]
Message-ID: <20241017154022.7650159b@hermes.local> (raw)
In-Reply-To: <20240906041614.36962-3-ajit.khaparde@broadcom.com>
On Thu, 5 Sep 2024 21:16:14 -0700
Ajit Khaparde <ajit.khaparde@broadcom.com> wrote:
> + sym_gdr_p2p_dma_map_buffer = dlsym(gdrclib, "gdr_p2p_dma_map_buffer");
> + if (sym_gdr_p2p_dma_map_buffer == NULL) {
> + rte_cuda_log(ERR, "Failed to load GDRCopy symbol gdr_p2p_dma_map_buffer\n");
> + printf("Failed to load GDRCopy symbol gdr_p2p_dma_map_buffer\n");
> + return -1;
> + }
No calls to printf() are acceptable in DPDK drivers.
There is a log message, that is sufficient here.
prev parent reply other threads:[~2024-10-17 22:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-06 4:16 [PATCH 0/2] add API to get GPU physical address Ajit Khaparde
2024-09-06 4:16 ` [PATCH 1/2] gpudev: " Ajit Khaparde
2024-09-06 4:16 ` [PATCH 2/2] gpu/cuda: extend cuda code to get PA of GPU Ajit Khaparde
2024-10-17 22:40 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241017154022.7650159b@hermes.local \
--to=stephen@networkplumber.org \
--cc=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=eagostini@nvidia.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).