From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D8EDB45B61; Fri, 18 Oct 2024 01:02:44 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5307C40654; Fri, 18 Oct 2024 01:02:44 +0200 (CEST) Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by mails.dpdk.org (Postfix) with ESMTP id EEEBA40268 for ; Fri, 18 Oct 2024 01:02:42 +0200 (CEST) Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-20c7ee8fe6bso14099965ad.2 for ; Thu, 17 Oct 2024 16:02:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729206162; x=1729810962; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=z62vHnza7rq6jRlJ5Dssn0C3agXRyPzrP3qHN7qvcsY=; b=FKtJomfuljXVqNg2PqK5KFCSAtyWsN8jMBUpdm9BYU2GmGDrCkegopBKKtvmk5JCOW bcePSpByZnLHh7SmlHirz1mACKf3gF71n0dV+uAs8El5BSCg86kRWoWu3kKltlQz/usa 7Pj4KcXE4FoJLL0FyfROQ025lf30GvyZvCdDgmnj9xXoI/+szx2hN0QlKnzjztnebB6h CN6xB+1FySZAN2xUjhEnBZ/DosHldbYDVDToyGiikyCOoJG23DaRclo2Arp22f/HZyiZ Nd5ityXA2fG9O/7yHYwKxahiHr1MWye44LTiNULh6v0uDIib8qDMmrOL2wBDKF5oLseq 20oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729206162; x=1729810962; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=z62vHnza7rq6jRlJ5Dssn0C3agXRyPzrP3qHN7qvcsY=; b=vNP/htNRCV02hnhiiQStMrHRF2v74/YgwLqCFZXcH4T0gQO9M8QhmK9Q3RFsXva6+f KZbG5Oy8j7GM2GZjthQQ1y/oHwqmnbXwUEThdP6h3Q+X/mrsVpJfDUekSq+Vh1M15BmC sawlfMKJjypCrd3+9MMJci112OJ00jkEqyPiPZp3tpMBUvNEW8HJRgU6b7FAvyIs4eQy aesZW1pFKoZXsdDq1vuodcDBzpDQdRqUG/KqY7PrSADIpHobDgs3aKKaOANgj+igkETH O3NeqasyfXT1E6iBuFbJ2CJtKg7JpFmTFVwKg1dbDhdK3/YbeIOnIO3y74eu5lRLEj5g A5kA== X-Forwarded-Encrypted: i=1; AJvYcCWyfmEGQnraM9jvx/2CqjlSu2dNCf84vHrzQ6cqu4W4mP/WolDIlu7tNdqdF7pN0YWt4Sk=@dpdk.org X-Gm-Message-State: AOJu0YyWjnIeEo0s7yPQ21j4yGUq6AQoSxi55eze93yARtIEiKF1xWFj doCfQS/C5I5GBY/CMoJYHyLRks55/1ibyUktV1wnrGVhxLtzBWbrpiQAImZPBns= X-Google-Smtp-Source: AGHT+IH0PH2fXKugh8eXN3H8JuJ863cdv+JJTfEwjd+En7SueDJ+6kvn40owT/48IG65c4FDk5y3Zg== X-Received: by 2002:a17:902:e5cd:b0:20c:b3d9:f5bd with SMTP id d9443c01a7336-20e5a75a9a7mr7715605ad.18.1729206162065; Thu, 17 Oct 2024 16:02:42 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20e5a71eb1fsm1579005ad.46.2024.10.17.16.02.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Oct 2024 16:02:41 -0700 (PDT) Date: Thu, 17 Oct 2024 16:02:39 -0700 From: Stephen Hemminger To: Long Li Cc: "longli@linuxonhyperv.com" , Ferruh Yigit , Andrew Rybchenko , "dev@dpdk.org" , "stable@dpdk.org" Subject: Re: [Patch v5] net/netvsc: fix number Tx queues > Rx queues Message-ID: <20241017160239.1fbd09a4@hermes.local> In-Reply-To: References: <1729192829-30211-1-git-send-email-longli@linuxonhyperv.com> <20241017153420.7960ca92@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 17 Oct 2024 22:38:49 +0000 Long Li wrote: > > Subject: Re: [Patch v5] net/netvsc: fix number Tx queues > Rx queues > > > > On Thu, 17 Oct 2024 12:20:29 -0700 > > longli@linuxonhyperv.com wrote: > > > > > +static void > > > +hn_rx_queue_free_common(struct hn_rx_queue *rxq) { > > > + if (!rxq) > > > + return; > > > + > > > + rte_free(rxq->rxbuf_info); > > > + rte_free(rxq->event_buf); > > > + rte_free(rxq); > > > +} > > > > Minor nit, DPDK style is for the bracket on the next line. > > Checkpatch will complain about this. > > Is it okay to take the patch as is, or should I send a v6 to have it fixed? It is ok as is, but followup to fix the minor stuff like this would be good.