From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2AE7045B60; Thu, 17 Oct 2024 18:08:07 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 913C84025F; Thu, 17 Oct 2024 18:08:06 +0200 (CEST) Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) by mails.dpdk.org (Postfix) with ESMTP id 093774021E for ; Thu, 17 Oct 2024 18:08:05 +0200 (CEST) Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-71e625b00bcso867681b3a.3 for ; Thu, 17 Oct 2024 09:08:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729181284; x=1729786084; darn=dpdk.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=2TTtBBS4ZHJ/OjGTlXf67q7RirjO+MrMWAZP8v0FFiI=; b=qK8I6x82HL1ZccGQaR/xaxtLiLnv5nHQ+44RoKhgOf82vZ5cfemWqBYPC35Wd9F+5g 8LIT6pgMdRvMIOH04wMrRkDeNUh7i+88gVqSNSjBhjzCQ0fqlBuQNP/y0QoR2s71duA9 1CfiDNNLXzh4OzJuQ4zZYc7q/aExTGVmQ+PQXxn/NC+1CA/vajUr1PqsGbh2zSdwZ6xJ 22yJxdk9uO16u9XsrPtV+5JjJA34WhsfzB/VjTsuHADDCnkv/jwe9sVOkFfK4sm1qSmX qsehYYIT28phOT1ZURxN+LQmaQZAlt6zx71jrARyZyuRFN4SAgKYSOxEA5rvCgOf2vQj FJzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729181284; x=1729786084; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2TTtBBS4ZHJ/OjGTlXf67q7RirjO+MrMWAZP8v0FFiI=; b=qu7dXM6JxkwXK0vuXIp0llKcbadKC1JetQDbjaREvkD2iOu4sw6Z3X7RSLOlUqT/SH BjknGks6rDyt6d7k8rasrW8nqM7Y0xaDfQYJZz90VSYG1xUEVndEW0F6dtKj40bGEWsx JyjBDS0Mpouoh6U8Clk1eQVlDhNBhO1/53yOL3sA+CI8fbc1rlpluYHWM9Ec2aZctu3W JCI/WkHBstZCUPnp7st0Plt+UPgP2dUsSddyYQFa2exVnZ/U/IUVjG9eL22kiIaudE+i e58LivZcFO01ujfmop4PSSVlI2QhFtMmOkHOuoWh+JF0iQgBMTg+53g0/XfhCtUEm0zS bQEQ== X-Gm-Message-State: AOJu0Yw4Tsi9j+RTT8g3L8Go1duDM97j7vSJH1RLTJvQWOrj73JQmSBu qyrY2l5ECwcKByV1Plofn1jwBMk5UvVvbx/TeQ5bCGEGkDgJhtvdSSgs/Xu0v7NrcPXgNeV1ERm O X-Google-Smtp-Source: AGHT+IH+S6LcvJtc4EcxFLjTGKXQgtlOX7Wf5b7ifhi7ZC81prqN/VWfsyMsvnOAA1jobQcKddVGEw== X-Received: by 2002:aa7:8e49:0:b0:71e:4c01:b3da with SMTP id d2e1a72fcca58-71e4c01b577mr20998272b3a.5.1729181284120; Thu, 17 Oct 2024 09:08:04 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71e773a2ff0sm4888662b3a.80.2024.10.17.09.08.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Oct 2024 09:08:03 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , asekhar@marvell.com, Kai Ji Subject: [PATCH] crypto/openssl: fix potential string overflow Date: Thu, 17 Oct 2024 09:07:53 -0700 Message-ID: <20241017160754.132762-1-stephen@networkplumber.org> X-Mailer: git-send-email 2.45.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The algorithm name is a string and should be copied with strlcpy() rather than rte_memcpy(). This fixes a warning detected with clang and ASAN. Bugzilla ID: 1565 Fixes: 2b9c693f6ef5 ("crypto/openssl: support AES-CMAC operations") Cc: asekhar@marvell.com Signed-off-by: Stephen Hemminger --- drivers/crypto/openssl/rte_openssl_pmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c b/drivers/crypto/openssl/rte_openssl_pmd.c index 9657b70c7a..bb706dd3e8 100644 --- a/drivers/crypto/openssl/rte_openssl_pmd.c +++ b/drivers/crypto/openssl/rte_openssl_pmd.c @@ -692,7 +692,7 @@ openssl_set_session_auth_parameters(struct openssl_session *sess, else return -EINVAL; - rte_memcpy(algo_name, algo, strlen(algo) + 1); + strlcpy(algo_name, algo, sizeof(algo_name)); params[0] = OSSL_PARAM_construct_utf8_string( OSSL_MAC_PARAM_CIPHER, algo_name, 0); params[1] = OSSL_PARAM_construct_end(); -- 2.45.2