From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BB9C445B63; Fri, 18 Oct 2024 03:20:40 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 657544064C; Fri, 18 Oct 2024 03:20:34 +0200 (CEST) Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by mails.dpdk.org (Postfix) with ESMTP id 2E0CC4021E for ; Fri, 18 Oct 2024 03:20:29 +0200 (CEST) Received: from mail.maildlp.com (unknown [172.19.162.254]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4XV6KN4SfMz1T8Y6; Fri, 18 Oct 2024 09:18:32 +0800 (CST) Received: from kwepemf500004.china.huawei.com (unknown [7.202.181.242]) by mail.maildlp.com (Postfix) with ESMTPS id 371C01800F2; Fri, 18 Oct 2024 09:20:27 +0800 (CST) Received: from localhost.localdomain (10.28.79.22) by kwepemf500004.china.huawei.com (7.202.181.242) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Fri, 18 Oct 2024 09:20:26 +0800 From: Jie Hai To: , , CC: , , Subject: [PATCH v4 2/2] examples/l3fwd: add option to set mbuf cache size Date: Fri, 18 Oct 2024 09:08:52 +0800 Message-ID: <20241018010852.32095-3-haijie1@huawei.com> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20241018010852.32095-1-haijie1@huawei.com> References: <20241012084052.3485-1-haijie1@huawei.com> <20241018010852.32095-1-haijie1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.28.79.22] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To kwepemf500004.china.huawei.com (7.202.181.242) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The mempool cache size of mbuf is set to RTE_MEMPOOL_CACHE_MAX_SIZE as default. This patch allows users to configure the cache size by "--mbcache", and limits the parameter to a maximum of RTE_MEMPOOL_CACHE_MAX_SIZE. Signed-off-by: Jie Hai Acked-by: Huisong Li Acked-by: Morten Brørup Acked-by: Chengwen Feng --- examples/l3fwd/l3fwd.h | 1 + examples/l3fwd/main.c | 33 ++++++++++++++++++++++++++++++--- 2 files changed, 31 insertions(+), 3 deletions(-) diff --git a/examples/l3fwd/l3fwd.h b/examples/l3fwd/l3fwd.h index 618e0eaa3af1..0cce3406ee7d 100644 --- a/examples/l3fwd/l3fwd.h +++ b/examples/l3fwd/l3fwd.h @@ -117,6 +117,7 @@ extern struct acl_algorithms acl_alg[]; extern uint32_t max_pkt_len; extern uint32_t nb_pkt_per_burst; +extern uint32_t mb_mempool_cache_size; /* Send burst of packets on an output interface */ static inline int diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c index 8b7a07cc7d67..7d58ae3c11bc 100644 --- a/examples/l3fwd/main.c +++ b/examples/l3fwd/main.c @@ -58,6 +58,7 @@ static_assert(MEMPOOL_CACHE_SIZE >= MAX_PKT_BURST, "MAX_PKT_BURST should be at m uint16_t nb_rxd = RX_DESC_DEFAULT; uint16_t nb_txd = TX_DESC_DEFAULT; uint32_t nb_pkt_per_burst = DEFAULT_PKT_BURST; +uint32_t mb_mempool_cache_size = MEMPOOL_CACHE_SIZE; /**< Ports set in promiscuous mode off by default. */ static int promiscuous_on; @@ -399,6 +400,7 @@ print_usage(const char *prgname) " [--rx-queue-size NPKTS]" " [--tx-queue-size NPKTS]" " [--burst NPKTS]" + " [--mbcache CACHESZ]" " [--eth-dest=X,MM:MM:MM:MM:MM:MM]" " [--max-pkt-len PKTLEN]" " [--no-numa]" @@ -426,6 +428,8 @@ print_usage(const char *prgname) " Default: %d\n" " --burst NPKTS: Burst size in decimal\n" " Default: %d\n" + " --mbcache CACHESZ: Mbuf cache size in decimal\n" + " Default: %d\n" " --eth-dest=X,MM:MM:MM:MM:MM:MM: Ethernet destination for port X\n" " --max-pkt-len PKTLEN: maximum packet length in decimal (64-9600)\n" " --no-numa: Disable numa awareness\n" @@ -455,7 +459,7 @@ print_usage(const char *prgname) " another is route entry at while line leads with character '%c'.\n" " --rule_ipv6=FILE: Specify the ipv6 rules entries file.\n" " --alg: ACL classify method to use, one of: %s.\n\n", - prgname, RX_DESC_DEFAULT, TX_DESC_DEFAULT, DEFAULT_PKT_BURST, + prgname, RX_DESC_DEFAULT, TX_DESC_DEFAULT, DEFAULT_PKT_BURST, MEMPOOL_CACHE_SIZE, ACL_LEAD_CHAR, ROUTE_LEAD_CHAR, alg); } @@ -673,6 +677,22 @@ parse_lookup(const char *optarg) return 0; } +static void +parse_mbcache_size(const char *optarg) +{ + unsigned long mb_cache_size; + char *end = NULL; + + mb_cache_size = strtoul(optarg, &end, 10); + if ((optarg[0] == '\0') || (end == NULL) || (*end != '\0')) + return; + if (mb_cache_size <= RTE_MEMPOOL_CACHE_MAX_SIZE) + mb_mempool_cache_size = (uint32_t)mb_cache_size; + else + rte_exit(EXIT_FAILURE, "mbcache must be >= 0 and <= %d\n", + RTE_MEMPOOL_CACHE_MAX_SIZE); +} + static void parse_pkt_burst(const char *optarg) { @@ -748,6 +768,7 @@ static const char short_options[] = #define CMD_LINE_OPT_RULE_IPV6 "rule_ipv6" #define CMD_LINE_OPT_ALG "alg" #define CMD_LINE_OPT_PKT_BURST "burst" +#define CMD_LINE_OPT_MB_CACHE_SIZE "mbcache" enum { /* long options mapped to a short option */ @@ -777,7 +798,8 @@ enum { CMD_LINE_OPT_ENABLE_VECTOR_NUM, CMD_LINE_OPT_VECTOR_SIZE_NUM, CMD_LINE_OPT_VECTOR_TMO_NS_NUM, - CMD_LINE_OPT_PKT_BURST_NUM + CMD_LINE_OPT_PKT_BURST_NUM, + CMD_LINE_OPT_MB_CACHE_SIZE_NUM }; static const struct option lgopts[] = { @@ -805,6 +827,7 @@ static const struct option lgopts[] = { {CMD_LINE_OPT_RULE_IPV6, 1, 0, CMD_LINE_OPT_RULE_IPV6_NUM}, {CMD_LINE_OPT_ALG, 1, 0, CMD_LINE_OPT_ALG_NUM}, {CMD_LINE_OPT_PKT_BURST, 1, 0, CMD_LINE_OPT_PKT_BURST_NUM}, + {CMD_LINE_OPT_MB_CACHE_SIZE, 1, 0, CMD_LINE_OPT_MB_CACHE_SIZE_NUM}, {NULL, 0, 0, 0} }; @@ -897,6 +920,10 @@ parse_args(int argc, char **argv) parse_pkt_burst(optarg); break; + case CMD_LINE_OPT_MB_CACHE_SIZE_NUM: + parse_mbcache_size(optarg); + break; + case CMD_LINE_OPT_ETH_DEST_NUM: parse_eth_dest(optarg); break; @@ -1089,7 +1116,7 @@ init_mem(uint16_t portid, unsigned int nb_mbuf) portid, socketid); pktmbuf_pool[portid][socketid] = rte_pktmbuf_pool_create(s, nb_mbuf, - MEMPOOL_CACHE_SIZE, 0, + mb_mempool_cache_size, 0, RTE_MBUF_DEFAULT_BUF_SIZE, socketid); if (pktmbuf_pool[portid][socketid] == NULL) rte_exit(EXIT_FAILURE, -- 2.22.0