From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BA05345B6A; Fri, 18 Oct 2024 18:39:56 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4CC274027C; Fri, 18 Oct 2024 18:39:56 +0200 (CEST) Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by mails.dpdk.org (Postfix) with ESMTP id 0E7CB40268 for ; Fri, 18 Oct 2024 18:39:55 +0200 (CEST) Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-20cf3e36a76so24345215ad.0 for ; Fri, 18 Oct 2024 09:39:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729269594; x=1729874394; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=T+iBbIY0faKYlnbinbLKkrTsDj90ZaACAD1CmOVKbn0=; b=JmOACWVAAkt5HyY9aepabvkNdW7KZtTqXZ3IkPGq+mEfgcCgoqyrk9u/sC89e/00n5 xx8jYe+tzANpKocDLfkNYU3fMCFOwbenduDw1QEL8KML+qLaH2QP8YvkqWB0bJLWXNrL DLIQcQFMUHjgQwzUfshnXl47ky/yoKGsUXEBeYw6jGyHmjOvRrRPkqJMpNH9xDEAETfa czhTujBwRYqCGJbfO6l0vjl8ZtTLo1vjbHZEPWkjy5d7HiBMMkyCHSv7JTE6qtt0/Eah OxfAmYjS7MXMzaq7T/NTzrm8YEZ6/lbFN/1btCIknSFfPzZnLLhhYS96H29w9a38OT5Q nl/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729269594; x=1729874394; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=T+iBbIY0faKYlnbinbLKkrTsDj90ZaACAD1CmOVKbn0=; b=K29EfQAY+1uO9E3bCxDl5htGYx6pylvHHzRANBYYJZB7BlT8jKcRADGgfTGW/ir+dG iSlud8wPoXZsuced5geCZzjV843rcttljtirElbHB7kBDjUlW/93/gRwy3pcka3oflp5 baq1bEncezTiem3pAuo2Os9WYdAag7n+9v9NQSVRgKnvQKw86Om9UZg2sw8susQutFfc WBXqoz3kDqI1WhnL5T40f2bu5sSAT7HUDGJRiNRdvNtDYC96P6OSk3h551RiRGd8UXLx Gnu/Yd8s02JVvEQJvv93BzBzZST5MO+tPKAN4gKQSECH62oC2hnENzKBJii+ogJQwlOG Syag== X-Gm-Message-State: AOJu0YwF/SQyfv7ocHmQ37ClDalPHIAAB2Y8KJcz8AeIYIF+5Yd4cOYJ J6p9Rzkf1x1ORdAa8quPlZ/Hs+bj3fgeb05hyZbLkHrWeyhCW37tOFklpo39Iy0= X-Google-Smtp-Source: AGHT+IFyj7te49mkQ5mhUrCEjKQ9qqVRy/YCwJu8SOHpHkzqbzcvfavhv1HoV2evggFp/VRFt3AJxQ== X-Received: by 2002:a17:902:d484:b0:20c:98f8:e0f5 with SMTP id d9443c01a7336-20e5a8f3e6emr35764855ad.43.1729269594024; Fri, 18 Oct 2024 09:39:54 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20e5a751ed2sm14747095ad.96.2024.10.18.09.39.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Oct 2024 09:39:53 -0700 (PDT) Date: Fri, 18 Oct 2024 09:39:51 -0700 From: Stephen Hemminger To: =?UTF-8?B?546L6aKi?= Cc: "dev@dpdk.org" , "pro_nic_dpdk@realtek.com" Subject: Re: [PATCH v2 11/18] net/r8169: implement Rx path Message-ID: <20241018093951.4117b4fc@hermes.local> In-Reply-To: <63ab5f1211dd4afca0c7cdd5ffea76d8@realsil.com.cn> References: <20241017063200.26101-1-howard_wang@realsil.com.cn> <20241017063200.26101-12-howard_wang@realsil.com.cn> <20241017091120.679ee0bc@hermes.local> <63ab5f1211dd4afca0c7cdd5ffea76d8@realsil.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 18 Oct 2024 02:02:47 +0000 =E7=8E=8B=E9=A2=A2 wrote: > Dear Stephen, >=20 > These CamelCase are from our linux kernel drivers. In order to maintain c= onsistency with Linux kernel drivers and facilitate maintenance, our DPDK P= MD has adopted this naming convention. May we continue using CamelCase? >=20 > Best Regards, > Howard Wang No problem with most of the CamelCase in this driver. But the Jumbo_Frame_9k can be replaced with something like. #define ETH_HLEN RTE_ETHER_HDR_LEN #define VLAN_HLEN RTE_VLAN_HLEN #define JUMBO_9K (9 * 1024 - ETH_HLEN - VLAN_HLEN - RTE_ETHER_CRC_LEN) Also, the Linux kernel driver has more complex handling of max mtu. It bases max mtu on the Phy type, the DPDK driver may need the same treatme= nt.