From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C5B2C45B6A; Fri, 18 Oct 2024 18:41:31 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B49C44027C; Fri, 18 Oct 2024 18:41:31 +0200 (CEST) Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by mails.dpdk.org (Postfix) with ESMTP id 30E5140268 for ; Fri, 18 Oct 2024 18:41:30 +0200 (CEST) Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-20c693b68f5so26162475ad.1 for ; Fri, 18 Oct 2024 09:41:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729269689; x=1729874489; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=JVJK8ltbj9YdJ807MJqbiIHxkSTFOulHqS9i6LATxYw=; b=Ig8Hg6nHjb+n8prMsM2yW0AiWFY2MIi4jTKfJMXXqqtSNVkr6M1irLhfnZdFy+JVJI mEpxh9yPyNFYK5MdrVUUpoROdlPBIKvMNcvnCWdwS9Y97YplzoURyLW7pe80lF5FHzNt HQo/+IfrdfvFo3YawlD1Clxv6JsJZxMvfJcv56+/nDAYzfue6G3hLw0D3eSB5qkIIdy0 HEKjviNQs5F9qNHsZheKWhLqCAgJRUjl+ejfq3jQC+fhATcX3VRYOEeGhdlFkKQ3gFYC 26kHDEviGPKFuGRQkpuaOAROSk3ZQNBskY6MrFuYicwvuKEviSnHqoGZJsDKp4Hw25Ki /Dfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729269689; x=1729874489; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JVJK8ltbj9YdJ807MJqbiIHxkSTFOulHqS9i6LATxYw=; b=LtjDFxWZBO0Q1x2s03gfh/n9JTEELVGHcLF/9OlmeSYGVK8fZ27kpC3lohCR+JwGYV ON5cYfzj3TYfVYfctk3jOPj6s2A2AzA+a9KVRy5iP3DM85sLLMveEzAqKz2faJVcOyoq 3BP9d03kWzcxBkWGibQnYTHmLilOVq21TNfFNkOGZRe9mgLiWA9RmgnBHi1kiUNy/I9Q ZPor6VeqBjP6ZOT3OrUim7vbqRj1HIrbWHlV2hKNK37dqbaecpwIxKM2jn/CQw2F2auu JreD9tkUFfHPyzMD64XjPOstoW/gcVSHmxWoRRg//09vtIDohleVKoDKdsCNwD49z59r 0oLA== X-Gm-Message-State: AOJu0YxxWKnecFyn9iU3Z0U5Rwi9E6ouw9ZA6vf7sJx3CZPmrlk0Q7sn 5yG8TwvfBc8Zr6ytATAkgw6ZbGgaHIFEeSs458JmaQUIjTeRjishkM8nQRL2KgY= X-Google-Smtp-Source: AGHT+IF9WkZpiQ4PnOce2RHHwr8ArPJidgwsXjqfZVdgjHzfZGKKXJ8RHtlBf8szw+86O1/sl3NHDQ== X-Received: by 2002:a17:902:ecd1:b0:20c:8907:90a with SMTP id d9443c01a7336-20e5a70d0d5mr38349135ad.5.1729269689304; Fri, 18 Oct 2024 09:41:29 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20e5a8f97d4sm14701085ad.191.2024.10.18.09.41.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Oct 2024 09:41:29 -0700 (PDT) Date: Fri, 18 Oct 2024 09:41:27 -0700 From: Stephen Hemminger To: Jie Hai Cc: , , , Yisen Zhuang , , Subject: Re: [PATCH 4/4] net/hns3: support outer VLAN flow match Message-ID: <20241018094127.0b3b5a33@hermes.local> In-Reply-To: <20241018061941.29960-5-haijie1@huawei.com> References: <20241018061941.29960-1-haijie1@huawei.com> <20241018061941.29960-5-haijie1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 18 Oct 2024 14:19:41 +0800 Jie Hai wrote: > @@ -306,11 +324,16 @@ hns3_parse_devargs(struct rte_eth_dev *dev) > &hns3_parse_dev_caps_mask, &dev_caps_mask); > (void)rte_kvargs_process(kvlist, HNS3_DEVARG_MBX_TIME_LIMIT_MS, > &hns3_parse_mbx_time_limit, &mbx_time_limit_ms); > - if (!hns->is_vf) > + if (!hns->is_vf) { > (void)rte_kvargs_process(kvlist, > HNS3_DEVARG_FDIR_VALN_MATCH_MODE, > &hns3_parse_vlan_match_mode, > &hns->pf.fdir.vlan_match_mode); > + (void)rte_kvargs_process(kvlist, > + HNS3_DEVARG_FDIR_TUPLE_CONFIG, > + &hns3_parse_fdir_tuple_config, > + &hns->pf.fdir.tuple_cfg); > + } > Side question, why the casts to void here? Is there some tool that is complaining (like old lint), or is there some error handling missing.