From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 19B2845B77; Sat, 19 Oct 2024 17:38:15 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CFD9240671; Sat, 19 Oct 2024 17:38:14 +0200 (CEST) Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) by mails.dpdk.org (Postfix) with ESMTP id 458314066F for ; Sat, 19 Oct 2024 17:38:13 +0200 (CEST) Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-2e56df894d4so1240567a91.3 for ; Sat, 19 Oct 2024 08:38:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729352292; x=1729957092; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=gxbHIpsxyiz060VMXDKEr1yV4NbYZ7cHf1dnC9S54JE=; b=HdFCkzEivuezLwYXiChLKzWxz+aW9s9hoA4qzei3gh+nDjc6BMwZO8S3jgufntVb2m Fn71p3QwAik2lZolRME0KeLaNOv3YI61qNPljlYcRksYklcNhz72A85XfPN9Ivamx6L/ Ye4MLX09jtLG3sRtXroMZ/RXBpj21CcTqat3xnpzCAgyHD+C5vRVSZQeLRqaRoLMaDd7 1L/df/SYSLM4eIY2bgioJsmylpk6WoK/k8tBtNL8EoAVLYQGyI+yqdx7FlS+jcbrxCb8 3Si9R7QLPBFLYNppqy8g0ijY9FtS8mApBrIbc45X1eDNinF5UKlzFtHN/5vI2w5NtEaP LZkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729352292; x=1729957092; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gxbHIpsxyiz060VMXDKEr1yV4NbYZ7cHf1dnC9S54JE=; b=LXeQH4EAXT+5A6vX+ay1RNV/BoE2rYS2Qc6W51pJbrYjLD0CGO4fQ0/6u7PZpOXBdZ VsvvDSCZLtDLWo+CUCfLXjE/9TdyTZsVvjIqfbFYlJXgqs2DmMN4o/jj3urP6XUmR9XC No7HNBepzqmR+fmrgCzxhRucWXfybbDzmadVHscUcFV4L4MPq16LEjkJI78C9Rcg0hwq M4hRraEjfN21HFcN/bIG3EQzQxJo/7QJKysvEnd5cR/yotLlbNiny8APBAJs6WUV44i1 eYBuvqENJan5IPLtpfNbHrtpriuwJ+nnKwOM3WJyN9oxMrHIMQ8LZFz50/x3yJI9KEOG K+pA== X-Gm-Message-State: AOJu0YwflkHYmFF7cfhAYUQDM6HxP2k3V3RNg0KBM3LCReSwDJf7RpVK rZu0pr6bNvCULtKqRgv5deITWHEyOUEEkqPOPyews30xGYG2GWgF5s5p76NXQNY= X-Google-Smtp-Source: AGHT+IGGt6ew5R9eaWjxqInq5KJ3s6XvIkDI86MiIwkP+pzl9dZvhCoCW6a9JdVQxU2YbbXpKeHiNg== X-Received: by 2002:a17:90a:8c9:b0:2e2:e4d3:3401 with SMTP id 98e67ed59e1d1-2e561855fd7mr7682033a91.20.1729352292230; Sat, 19 Oct 2024 08:38:12 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e5612d25f7sm4235906a91.48.2024.10.19.08.38.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 19 Oct 2024 08:38:12 -0700 (PDT) Date: Sat, 19 Oct 2024 08:38:11 -0700 From: Stephen Hemminger To: Bruce Richardson Cc: dev@dpdk.org, Radu Nicolau , Akhil Goyal , Maxime Coquelin , Chenbo Xia Subject: Re: [PATCH 6/6] build: limit scope of packed member warning disabling Message-ID: <20241019083811.2dee2ec8@hermes.local> In-Reply-To: <20241017142214.1669370-7-bruce.richardson@intel.com> References: <20241017142214.1669370-1-bruce.richardson@intel.com> <20241017142214.1669370-7-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 17 Oct 2024 15:22:13 +0100 Bruce Richardson wrote: > The flag '-Wno-address-of-packed-member' is a global warning flag in > DPDK. Rather than disabling this warning globally, it is better to just > have it enabled for components that may need it. This patch limits the > scope of it in the following ways: > > * limit the use of the flag to the drivers subfolder only - all libs and > apps should be buildable without the warning. > * exception is made for the vhost library and the ipsec-secgw example > for now, as making them buildable with the warning enabled is more > complicated. This exception can hopefully be removed in future. > > Limiting the scope further within the drivers directory is also left for > future consideration. However, since HW drivers often have to use packed > structures to align with hardware-implemented data layouts, it may be > more practical to keep the warning disabled in the longer term. > > Signed-off-by: Bruce Richardson > --- > config/meson.build | 1 - > drivers/meson.build | 9 ++++++--- > examples/ipsec-secgw/meson.build | 6 ++++++ > lib/vhost/meson.build | 5 ++++- > 4 files changed, 16 insertions(+), 5 deletions(-) Good first step, followups can fix ipsec and vhost later. Acked-by: Stephen Hemminger