From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 190D845B8A; Mon, 21 Oct 2024 01:26:01 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9D6454021F; Mon, 21 Oct 2024 01:26:00 +0200 (CEST) Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by mails.dpdk.org (Postfix) with ESMTP id 3D3E5400EF for ; Mon, 21 Oct 2024 01:25:59 +0200 (CEST) Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-20c803787abso29129505ad.0 for ; Sun, 20 Oct 2024 16:25:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729466758; x=1730071558; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=gVoxoufzHUsZCHH6QbeKEQe6EyCREce+JEAUt3iOl/s=; b=jEX8ksVeXmE7R+QVWoSv1+ccXZRQhkjU2O3UxB+hRWaS5+9tOAWDnp2MqmC1FpwIK0 Oxn/8t4s8YvzoPnoAMvR5WY30t+6WfuDTRW1teFJpnb/ew+6/3yGdiaQesAjYXcjMgQ6 fZ6uRMywsDJ8ZoqOe8c69U1EEamSGNpgO3cGczDGZiKjCqNnHjPlUkrZNEIECQ/Qq48I NFdY9cQYTejPY+Rolie+LkAAMxnMWe3RK2gdXXCzPgavD6+qoZH7BhJqoSysIbGyDB15 PiZKwely04kIhoOBMaXe8hJT64PIhJTNoGwlAYyEenWYnlDyQB2smtTZY5daqMQwZxpl 3rbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729466758; x=1730071558; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gVoxoufzHUsZCHH6QbeKEQe6EyCREce+JEAUt3iOl/s=; b=HSfKXWf0Sg7xxUyO1eBRcC9gb0hhYcCT3MyENMxu8M2iwcoGmRr0xmKV7XjHWZdXGO /vau7yuLnaRy9WTvqJFvQrCpFWh3AzuLY1H5z4vV81sD6yfJhz/Afocgs3A2ZnkcHPlU bZa6Pu3gyH7TaY4LdDD4LuRvWv98OQL2PBkzqtKIwLA3E/ndLZcGIz/9SlQqsbGajLrR j3wg8MN723HAS6K5uNKgigMBRO+80DMN5GtHJrDWpprMXWsbI1PypSH4rGl7Yzwely92 jtYZxj2AIzkX+dXhCqK0/sqEKfWS4EvVUyp2xhBTzcycW0SYCzMpnqN+8Z5rVzq++SMY oCVw== X-Forwarded-Encrypted: i=1; AJvYcCXA5n1sCjOhG9gvCqzs9fk7e5FCRk/HJuHJN2IdKkJI62bbnZ65CCRURCCkhGCLYkLQeX0=@dpdk.org X-Gm-Message-State: AOJu0YxIA2FyzHMHIZ/nQFgy0HCnp7P99OuH5PhbrUroXvIrv25s1B2Q 5cgJQxRWIfdqww37UfpF7aBZxs1pQJ+lQZmlhzLjq0M+pLXP/OISiAm/VCRAn3k= X-Google-Smtp-Source: AGHT+IF7pD5entPGbHNRmoQiOyzTo2PWZQsBd6klXMuRwOOisI9HQd20w1pQY2Lb43jwrvyUgxTqDw== X-Received: by 2002:a17:902:ce0f:b0:20b:51c2:d792 with SMTP id d9443c01a7336-20e5c0d31f6mr168521165ad.2.1729466758149; Sun, 20 Oct 2024 16:25:58 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20e7eee89d8sm14880635ad.14.2024.10.20.16.25.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Oct 2024 16:25:57 -0700 (PDT) Date: Sun, 20 Oct 2024 16:25:55 -0700 From: Stephen Hemminger To: Sivaprasad Tummala Cc: , , , , , , , , , Subject: Re: [PATCH v6 2/5] power: refactor uncore power management library Message-ID: <20241020162555.65a0bb8f@hermes.local> In-Reply-To: <20241020092233.2906612-3-sivaprasad.tummala@amd.com> References: <20241017102650.1041030-1-sivaprasad.tummala@amd.com> <20241020092233.2906612-1-sivaprasad.tummala@amd.com> <20241020092233.2906612-3-sivaprasad.tummala@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sun, 20 Oct 2024 09:22:29 +0000 Sivaprasad Tummala wrote: > diff --git a/lib/power/rte_power_uncore.c b/lib/power/rte_power_uncore.c > index 48c75a5da0..f11238cc34 100644 > --- a/lib/power/rte_power_uncore.c > +++ b/lib/power/rte_power_uncore.c > @@ -10,100 +10,53 @@ > =20 > #include "power_common.h" > #include "rte_power_uncore.h" > -#include "power_intel_uncore.h" > =20 > -enum rte_uncore_power_mgmt_env default_uncore_env =3D RTE_UNCORE_PM_ENV_= NOT_SET; > +static enum rte_uncore_power_mgmt_env global_uncore_env =3D RTE_UNCORE_P= M_ENV_NOT_SET; > +static struct rte_power_uncore_ops *global_uncore_ops; > =20 > static rte_spinlock_t global_env_cfg_lock =3D RTE_SPINLOCK_INITIALIZER; > +static RTE_TAILQ_HEAD(, rte_power_uncore_ops) uncore_ops_list =3D > + TAILQ_HEAD_INITIALIZER(uncore_ops_list); > =20 Need to include rte_debug.h now? _github build: failed_ Build URL: https://github.com/ovsrobot/dpdk/actions/runs/11425299483 Build Logs: -----------------------Summary of failed steps----------------------- "ubuntu-22.04-gcc-ppc64le" failed at step Build and test "ubuntu-22.04-gcc-riscv64" failed at step Build and test ----------------------End summary of failed steps-------------------- -------------------------------BEGIN LOGS---------------------------- ###########################################################################= ######### #### [Begin job log] "ubuntu-22.04-gcc-ppc64le" at step Build and test ###########################################################################= ######### [325/3576] Generating symbol file lib/librte_latencystats.so.25.0.p/librte_= latencystats.so.25.0.symbols [326/3576] Generating symbol file lib/librte_jobstats.so.25.0.p/librte_jobs= tats.so.25.0.symbols [327/3576] Compiling C object lib/librte_member.a.p/member_rte_member_ht.c.o [328/3576] Generating symbol file lib/librte_ip_frag.so.25.0.p/librte_ip_fr= ag.so.25.0.symbols [329/3576] Compiling C object drivers/libtmp_rte_bus_platform.a.p/bus_platf= orm_platform_params.c.o [330/3576] Compiling C object lib/librte_member.a.p/member_rte_member_vbf.c= .o [331/3576] Compiling C object lib/librte_power.a.p/power_power_common.c.o [332/3576] Compiling C object lib/librte_power.a.p/power_rte_power.c.o [333/3576] Compiling C object lib/librte_power.a.p/power_rte_power_uncore.c= .o FAILED: lib/librte_power.a.p/power_rte_power_uncore.c.o=20 ccache powerpc64le-linux-gnu-gcc -Ilib/librte_power.a.p -Ilib -I../lib -Ili= b/power -I../lib/power -I. -I.. -Iconfig -I../config -Ilib/eal/include -I..= /lib/eal/include -Ilib/eal/linux/include -I../lib/eal/linux/include -Ilib/e= al/ppc/include -I../lib/eal/ppc/include -Ilib/eal/common -I../lib/eal/commo= n -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs -Ilib/log -I../lib/lo= g -Ilib/metrics -I../lib/metrics -Ilib/telemetry -I../lib/telemetry -Ilib/t= imer -I../lib/timer -Ilib/ethdev -I../lib/ethdev -Ilib/net -I../lib/net -Il= ib/mbuf -I../lib/mbuf -Ilib/mempool -I../lib/mempool -Ilib/ring -I../lib/ri= ng -Ilib/meter -I../lib/meter -fdiagnostics-color=3Dalways -pipe -D_FILE_OF= FSET_BITS=3D64 -Wall -Winvalid-pch -Wextra -Werror -std=3Dc11 -O2 -g -inclu= de rte_config.h -Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral -Wfor= mat-security -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -= Wold-style-definition -Wpointer-arith -Wsign-compare -Wstrict-prototypes -W= undef -Wwrite-strings -Wno-address-of-packed-member -Wno-packed-not-aligned= -Wno-missing-field-initializers -Wno-psabi -D_GNU_SOURCE -fPIC -mcpu=3Dpow= er8 -mtune=3Dpower8 -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -Wno-form= at-truncation -DRTE_LOG_DEFAULT_LOGTYPE=3Dlib.power -MD -MQ lib/librte_powe= r.a.p/power_rte_power_uncore.c.o -MF lib/librte_power.a.p/power_rte_power_u= ncore.c.o.d -o lib/librte_power.a.p/power_rte_power_uncore.c.o -c ../lib/po= wer/rte_power_uncore.c ../lib/power/rte_power_uncore.c: In function =E2=80=98rte_power_get_uncore_= freq=E2=80=99: ../lib/power/rte_power_uncore.c:149:9: error: implicit declaration of funct= ion =E2=80=98RTE_ASSERT=E2=80=99; did you mean =E2=80=98RTE_STR=E2=80=99? [= -Werror=3Dimplicit-function-declaration] 149 | RTE_ASSERT(global_uncore_ops !=3D NULL); | ^~~~~~~~~~ | RTE_STR ../lib/power/rte_power_uncore.c:149:9: error: nested extern declaration of = =E2=80=98RTE_ASSERT=E2=80=99 [-Werror=3Dnested-externs] cc1: all warnings being treated as errors [334/3576] Compiling C object lib/librte_member.a.p/member_rte_member_sketc= h.c.o [335/3576] Generating lpm.sym_chk with a custom command (wrapped by meson t= o capture output) [336/3576] Compiling C object lib/librte_pcapng.a.p/pcapng_rte_pcapng.c.o [337/3576] Compiling C object lib/librte_power.a.p/power_rte_power_pmd_mgmt= .c.o [338/3576] Generating eventdev.sym_chk with a custom command (wrapped by me= son to capture output) ninja: build stopped: subcommand failed. ##[error]Process completed with exit code 1. ###########################################################################= ######### #### [End job log] "ubuntu-22.04-gcc-ppc64le" at step Build and test ###########################################################################= #########