From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 000F345B94; Mon, 21 Oct 2024 18:05:27 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 601534060F; Mon, 21 Oct 2024 18:05:23 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 19BD54060F for ; Mon, 21 Oct 2024 18:05:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729526721; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zzkXXuM/dthnwEOBJ1XPi9YzBBioWxmpTNMh0zHKVTk=; b=gcf9LHp2azgJZ7bj2xgblPkvBgKvo1G0c5SF6y/qLYrljzgkk+yOMTo+aBqN+oeZe99r1V 9odiLcx3GpQwa68yEi6psLAlyLFSsPrKXEAA/79g3BwN8bMLV0fhtZCqNPaV7GyvZCz0h2 yUT4bPl2H+rsZRphEDL8SA+O3bVeM4w= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-678-xwAN8vLdOlaXGrBnTLkZLA-1; Mon, 21 Oct 2024 12:05:18 -0400 X-MC-Unique: xwAN8vLdOlaXGrBnTLkZLA-1 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7DB5E1955F54; Mon, 21 Oct 2024 16:05:17 +0000 (UTC) Received: from dmarchan.redhat.com (unknown [10.45.224.57]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id A13C119560AA; Mon, 21 Oct 2024 16:05:15 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: thomas@monjalon.net, bruce.richardson@intel.com, ktraynor@redhat.com, Tyler Retzlaff Subject: [PATCH v3 4/4] buildtools/chkincs: check driver specific headers Date: Mon, 21 Oct 2024 18:04:47 +0200 Message-ID: <20241021160447.3538245-5-david.marchand@redhat.com> In-Reply-To: <20241021160447.3538245-1-david.marchand@redhat.com> References: <20241015121046.2556695-1-david.marchand@redhat.com> <20241021160447.3538245-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Only driver headers exported by libraries were checked. Add driver specific headers to the checked headers list. This reveals a small issue with the vmbus driver header as some driver headers rely on it. Fixes: b232b2aa212b ("buildtools/chkincs: check SDK headers for C++ compatibility") Fixes: 84aaf06d817c ("bus/vmbus: make driver-only headers private") Signed-off-by: David Marchand --- buildtools/chkincs/meson.build | 3 +++ drivers/meson.build | 1 + 2 files changed, 4 insertions(+) diff --git a/buildtools/chkincs/meson.build b/buildtools/chkincs/meson.build index 787d70272b..ed65105599 100644 --- a/buildtools/chkincs/meson.build +++ b/buildtools/chkincs/meson.build @@ -19,6 +19,9 @@ sources += gen_c_files.process(dpdk_chkinc_headers) # some driver SDK headers depend on these two buses, which are mandatory in build # so we always include them in deps list deps = [get_variable('shared_rte_bus_vdev'), get_variable('shared_rte_bus_pci')] +if dpdk_conf.has('RTE_BUS_VMBUS') + deps += get_variable('shared_rte_bus_vmbus') +endif # add the rest of the libs to the dependencies foreach l:dpdk_libs_enabled deps += get_variable('shared_rte_' + l) diff --git a/drivers/meson.build b/drivers/meson.build index 2733306698..5270160c56 100644 --- a/drivers/meson.build +++ b/drivers/meson.build @@ -220,6 +220,7 @@ foreach subpath:subdirs if get_option('enable_driver_sdk') install_headers(driver_sdk_headers) endif + dpdk_chkinc_headers += driver_sdk_headers if headers.length() > 0 dpdk_includes += include_directories(drv_path) -- 2.46.2