From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 104D445B96; Tue, 22 Oct 2024 01:12:54 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7E40D402CD; Tue, 22 Oct 2024 01:12:53 +0200 (CEST) Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by mails.dpdk.org (Postfix) with ESMTP id ED3C24027E for ; Tue, 22 Oct 2024 01:12:51 +0200 (CEST) Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-2e18293a5efso3298647a91.3 for ; Mon, 21 Oct 2024 16:12:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729552371; x=1730157171; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=DnSr1a/OtR4xVNe0QEOiiYAqkBXBEYofyx01W85J8mA=; b=qhV9bIGfBkkq4ZO/RL28AB5aSn3HTLJlEU862vxjpo0q0ezlMgm8cl9eyOt/co1Lnv /h5Pry1yAo3XCbRwykgq82KqpZwBkVHy+hmwjw7vSP/BSjvyKM6bKMWnIo2uBH2LLZjh bpc+eJY6a+iZheifj5BVW0PZRuxG9WlL6D56wmx7mQstr0gKrsdNGaRUF2yXoVowC6O0 k/farj6WpS8KP7GWn+u3L0yxykDtBXuz3Fx84h88fSByXU6adWARr7+mXzDrQGuS4CrR XaA0yzgZybSrvgPyGUQnEydauSmyfVWZhUKbQLbab4wl1sntKAcPNPDUFG8X/Dz04ZoU RtHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729552371; x=1730157171; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DnSr1a/OtR4xVNe0QEOiiYAqkBXBEYofyx01W85J8mA=; b=hAN9UMmz8nnaOySRnICXxmksly81P29DY9/4MGE8xLyl2xu8kjuSNFP1ctMi4F+ddm rND/97gioz0u7UZKzlbhs170hrXtGXqux6Y1/Dk8x7nuJHgUIDZHstFq7iijtl555A+Q tas57W+jBRMHVDEzxYcAXVBuxRoGZwbivA9AypqIx9ddoVYe4Vie9+p2bMBjUFrKjj0D 1TjGELKgeIltlI0ssQmS6z0Y2eGyvR1PvD/42E2y2P/nvntd1Vdk27JO1ezEJXogw69+ Dg2RWwR/7gEo/4BBWIOL6kpMRAGa9MUFe4aINItQJn2zyOujtXujrnxcLfF4Ls+zVSw5 vGHA== X-Gm-Message-State: AOJu0Yw/sNiR04ct9I/GJw5Y0gxFpoC3a/EuwcHkT24ASfoUSIAWZgss EF1KmCWaJAie8/ndD8uPMPJvg+zjRksxhTORFavKaQrGl7wus7roDvU39MHkQ/U= X-Google-Smtp-Source: AGHT+IF7TSdGjGMU2iWLa5whAYeBNYdUshr+SCSFzTFL25mW3GBgx/kdXp6hzl2RCdL/7x+D6lyFTA== X-Received: by 2002:a17:90a:7105:b0:2e2:b64e:f4f7 with SMTP id 98e67ed59e1d1-2e5616eab4emr14147322a91.29.1729552371088; Mon, 21 Oct 2024 16:12:51 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e5ad389244sm4510851a91.28.2024.10.21.16.12.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Oct 2024 16:12:50 -0700 (PDT) Date: Mon, 21 Oct 2024 16:12:49 -0700 From: Stephen Hemminger To: Serhii Iliushyk Cc: dev@dpdk.org, mko-plv@napatech.com, ckm@napatech.com, andrew.rybchenko@oktetlabs.ru, ferruh.yigit@amd.com, dvo-plv@napatech.com Subject: Re: [PATCH v1 52/73] net/ntnic: update alignment for virt queue structs Message-ID: <20241021161249.445ec518@hermes.local> In-Reply-To: <20241021210527.2075431-53-sil-plv@napatech.com> References: <20241021210527.2075431-1-sil-plv@napatech.com> <20241021210527.2075431-53-sil-plv@napatech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 21 Oct 2024 23:04:54 +0200 Serhii Iliushyk wrote: > truct __rte_aligned(8) virtq_avail { > +struct __rte_packed __rte_aligned(1) virtq_avail { > uint16_t flags; > uint16_t idx; > uint16_t ring[]; /* Queue Size */ > }; > > -struct __rte_aligned(8) virtq_used_elem { > +struct __rte_packed __rte_aligned(1) virtq_used_elem { > /* Index of start of used descriptor chain. */ > uint32_t id; > /* Total length of the descriptor chain which was used (written to) */ > uint32_t len; > }; > > -struct __rte_aligned(8) virtq_used { > +struct __rte_packed __rte_aligned(1) virtq_used { > uint16_t flags; > uint16_t idx; > struct virtq_used_elem ring[]; /* Queue Size */ If you use __rte_packed doesn't it assume no alignment.