From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D656F45B96; Tue, 22 Oct 2024 01:22:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 658AC402E4; Tue, 22 Oct 2024 01:22:37 +0200 (CEST) Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) by mails.dpdk.org (Postfix) with ESMTP id 18199402E3 for ; Tue, 22 Oct 2024 01:22:36 +0200 (CEST) Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-71e67d12d04so3890664b3a.1 for ; Mon, 21 Oct 2024 16:22:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729552955; x=1730157755; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=sIMFQ2yPus3TSNQ/qHg8bwJBQs585lncdIpoFoxl14w=; b=cOU0upHGHg5b5e9vhP0yw7gEvBzXjDXDszD+FZxlN3vouIwWgE2Odc39cbEoNBw0Iq 92RDg5uGcB1uFQWVqBCE17SkqDhmh1DhFP4Xya7vxdJjmy5kcJChRti6qPyYffLAatxV UZw22K8GHGmh0SYfqqO+lfYWSsy+yLkrhc4nxMIAUWsDssQDvthlnl/SKDwXwzWaQlsq f5px54T0X4pzfzTBqCknCyMN37ixLyzYk01ZREqHoBcj0KpMhEIRm+fABxOxNSYotTDv +jPfUr9PkXQp+QvhFUvkBMimHHnFMzU/y8Wzk7QmyLljcUjmUQ2iqZzyjwpu9awF/fBq ExNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729552955; x=1730157755; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sIMFQ2yPus3TSNQ/qHg8bwJBQs585lncdIpoFoxl14w=; b=bEshtcHxZyIahO2diEtJSnOU7e3tvVkBQXGORSTNIe9q0+bAl26TzjDHfp/sqBG3NI V/Gt1Tl4jqE8fcgh65s+Yg99UytdT/o2M/jKT5iP9jqJrd0N/6FTukWShDj9xQfEwevd I9Id17AUc2yFCWqMgUghRYQb9DjZaJDHy2IxhoZu7KGAzrV0fbuRfjNY120HLZuvfIZ/ BsxnV0FE+lLV+2XfCD6/G5F4QAPgH/ppj9QnBFPpx+9yROqSqePsdjjsg9m9zXls3ph5 nAHZ+Zm0XcHHFjE9SZUYFhX8i+aO+4X39yc37E+W39uIz5j7SMHNA2RKUfkcp4rJdrkM FFZw== X-Gm-Message-State: AOJu0YyxUiP5CpkQZRWQqxNHzIJsw5R+hNIwCwxvS+dUZ5gI2m4/nAjx 4ptodb5O10643qJo0/RGDe/R6J/cOrxOsTYBe8di4nCsh48ai8sREPRXTgEVM2s= X-Google-Smtp-Source: AGHT+IHFp6QD6l+I03tknwwKed8nz2hLU8XVUM+bdH2GICQTJ2VbRHJR2LF0gu8YbTYGWZsvauEU9A== X-Received: by 2002:a05:6a00:b51:b0:71e:5fa1:d3e4 with SMTP id d2e1a72fcca58-71ee4138f86mr1224129b3a.2.1729552954968; Mon, 21 Oct 2024 16:22:34 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71ec1407de8sm3443977b3a.209.2024.10.21.16.22.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Oct 2024 16:22:34 -0700 (PDT) Date: Mon, 21 Oct 2024 16:22:33 -0700 From: Stephen Hemminger To: Serhii Iliushyk Cc: dev@dpdk.org, mko-plv@napatech.com, ckm@napatech.com, andrew.rybchenko@oktetlabs.ru, ferruh.yigit@amd.com, Danylo Vodopianov Subject: Re: [PATCH v1 68/73] net/ntnic: add aged flow event Message-ID: <20241021162233.7e06699c@hermes.local> In-Reply-To: <20241021210527.2075431-69-sil-plv@napatech.com> References: <20241021210527.2075431-1-sil-plv@napatech.com> <20241021210527.2075431-69-sil-plv@napatech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 21 Oct 2024 23:05:10 +0200 Serhii Iliushyk wrote: > From: Danylo Vodopianov > > Port thread was extended with new age event callback handler. > LRN, INF, STA registers getter setter was added. > > Signed-off-by: Danylo Vodopianov > --- This patch and other parts of the flow API have problems if built with stdatomic and Clang. It is missing use of RTE_ATOMIC() ../drivers/net/ntnic/nthw/flow_api/profile_inline/flm_age_queue.c:20:9: error: address argument to atomic operation must be a pointer to _Atomic type ('uint16_t *' (aka 'unsigned short *') invalid) return rte_atomic_load_explicit(&age_event[port], rte_memory_order_seq_cst); ^ ~~~~~~~~~~~~~~~~ ../lib/eal/include/rte_stdatomic.h:69:2: note: expanded from macro 'rte_atomic_load_explicit' atomic_load_explicit(ptr, memorder) ^ ~~~ /usr/lib/llvm-16/lib/clang/16/include/stdatomic.h:134:30: note: expanded from macro 'atomic_load_explicit' #define atomic_load_explicit __c11_atomic_load ^ ../drivers/net/ntnic/nthw/flow_api/profile_inline/flm_age_queue.c:25:2: error: address argument to atomic operation must be a pointer to _Atomic type ('uint16_t *' (aka 'unsigned short *') invalid) rte_atomic_store_explicit(&age_event[port], 1, rte_memory_order_seq_cst); ^ ~~~~~~~~~~~~~~~~ ../lib/eal/include/rte_stdatomic.h:72:2: note: expanded from macro 'rte_atomic_store_explicit' atomic_store_explicit(ptr, val, memorder) ^ ~~~ /usr/lib/llvm-16/lib/clang/16/include/stdatomic.h:131:31: note: expanded from macro 'atomic_store_explicit' #define atomic_store_explicit __c11_atomic_store ^ ../drivers/net/ntnic/nthw/flow_api/profile_inline/flm_age_queue.c:30:2: error: member reference base type 'uint16_t' (aka 'unsigned short') is not a structure or union rte_atomic_flag_clear_explicit(&age_event[port], rte_memory_order_seq_cst); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../lib/eal/include/rte_stdatomic.h:109:2: note: expanded from macro 'rte_atomic_flag_clear_explicit' atomic_flag_clear_explicit(ptr, memorder) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /usr/lib/llvm-16/lib/clang/16/include/stdatomic.h:181:79: note: expanded from macro 'atomic_flag_clear_explicit' #define atomic_flag_clear_explicit(object, order) __c11_atomic_store(&(object)->_Value, 0, order) ~~~~~~~~^ ~~~~~~ ../drivers/net/ntnic/nthw/flow_api/profile_inline/flm_age_queue.c:38:3: error: member reference base type 'uint16_t' (aka 'unsigned short') is not a structure or union rte_atomic_flag_clear_explicit(&age_event[port], rte_memory_order_seq_cst); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../lib/eal/include/rte_stdatomic.h:109:2: note: expanded from macro 'rte_atomic_flag_clear_explicit' atomic_flag_clear_explicit(ptr, memorder) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /usr/lib/llvm-16/lib/clang/16/include/stdatomic.h:181:79: note: expanded from macro 'atomic_flag_clear_explicit' #define atomic_flag_clear_explicit(object, order) __c11_atomic_store(&(object)->_Value, 0, order) ~~~~~~~~^ ~~~~~~ ../drivers/net/ntnic/nthw/flow_api/profile_inline/flm_age_queue.c:82:2: error: member reference base type 'uint16_t' (aka 'unsigned short') is not a structure or union rte_atomic_flag_clear_explicit(&age_event[port], rte_memory_order_seq_cst); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../lib/eal/include/rte_stdatomic.h:109:2: note: expanded from macro 'rte_atomic_flag_clear_explicit' atomic_flag_clear_explicit(ptr, memorder) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /usr/lib/llvm-16/lib/clang/16/include/stdatomic.h:181:79: note: expanded from macro 'atomic_flag_clear_explicit' #define atomic_flag_clear_explicit(object, order) __c11_atomic_store(&(object)->_Value, 0, order)