From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id B2C4D45B97;
	Tue, 22 Oct 2024 03:35:07 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 9B10740615;
	Tue, 22 Oct 2024 03:35:07 +0200 (CEST)
Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com
 [209.85.215.173])
 by mails.dpdk.org (Postfix) with ESMTP id A6F77402E9
 for <dev@dpdk.org>; Tue, 22 Oct 2024 03:35:05 +0200 (CEST)
Received: by mail-pg1-f173.google.com with SMTP id
 41be03b00d2f7-7ea8c4ce232so4298298a12.0
 for <dev@dpdk.org>; Mon, 21 Oct 2024 18:35:05 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729560905;
 x=1730165705; darn=dpdk.org; 
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:subject:cc:to:from:date:from:to:cc:subject:date
 :message-id:reply-to;
 bh=wRMISTFOZewT+a0xFabx+b0Y4hboA+Cm95Ms+1Tz86M=;
 b=I0kYjojBVQO6LddHZL60BSL+d8WtnX4DXdVrSpIAtiwaicYnpXO6xy9KQj+rjjhcPn
 /Io38cRzZ0WodJdSYl3NPwuXlfICMsvgj/8yaWZqCYY9rRjRcvKMcduHwLEw63LOh44J
 Hgzo1zCv7TBdBBr3NrvLykRvY4zqVIBzSQOuDTzNkGZ4FfiSCDVZZ5Vu+czsvqA9Pu+A
 fpTQUospxsgBcBs2RmyXZxiGicBj2Nvn1zMgx3SfVPHvwux3r1qivwmot08AC71/JgI4
 ZDNemHlKRyAV6T3N1H4cA9KVZXV559woIltvGZ7/ZXwHmdkJu6wtviq2N3M7+i1P315p
 vbZg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1729560905; x=1730165705;
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=wRMISTFOZewT+a0xFabx+b0Y4hboA+Cm95Ms+1Tz86M=;
 b=e3ziCmtxcU2yHi3fggL1fJyh23G6Suu79Vkb+eymIYMmHHJ6WARLw5YrS7xmaOMt11
 ukuoyV02ut0alLqHfEENW+qlnPcSs7enaEwMEUTBFtALB/PYog2rB4Db6HX/XTZLsVvW
 O+KC/dxCPkykO0u/o2XgJpYJ2LYVvrI57+vtYUXjJLuvzc26VVOsIKqasg/FUrSumY6k
 BFh2OE7E6e6VMMy1k1vnksY+Jxxw6NfN6k8JrYXNAg5/xJN4Ejr7VOvkPLCOp5jbjyp4
 nqIsM8KvgKxT0oQTUy/N/oSt/hlzg2bHE6noUbwDTFXhvlHJN7txGUTfgtcadPbeki1F
 T+yA==
X-Forwarded-Encrypted: i=1;
 AJvYcCWweXFzF4n8kjh/SMEdd+ixISFW6vZKbLDw+NQxJqv56Gwx0jWzZx2RyWbNSsqcVzxG9qw=@dpdk.org
X-Gm-Message-State: AOJu0YyPUd96NBp1bG5sIqAEVP5Dpy1JLgt1Lp05vv7o1dD2puehHjav
 rLjeLDjQrof4lOYxpe4soA9H+PhOrw5n+IwDjGuxZyxyBfXtBL9rYTtBZaIgmn0=
X-Google-Smtp-Source: AGHT+IHLcMoBVWoAtyKuLHHTFb0EyGfjWoQ5fhlBuwcIoKe2ylox3FUI3EroUl8eIpCUEfj18InRzw==
X-Received: by 2002:a05:6a20:921e:b0:1d9:237a:2d56 with SMTP id
 adf61e73a8af0-1d92c5bdbedmr12854398637.48.1729560904854; 
 Mon, 21 Oct 2024 18:35:04 -0700 (PDT)
Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226])
 by smtp.gmail.com with ESMTPSA id
 41be03b00d2f7-7eaeabbca78sm3815687a12.58.2024.10.21.18.35.04
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 21 Oct 2024 18:35:04 -0700 (PDT)
Date: Mon, 21 Oct 2024 18:18:41 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
Cc: <david.hunt@intel.com>, <anatoly.burakov@intel.com>,
 <jerinj@marvell.com>, <radu.nicolau@intel.com>, <gakhil@marvell.com>,
 <cristian.dumitrescu@intel.com>, <ferruh.yigit@amd.com>,
 <konstantin.ananyev@huawei.com>, <lihuisong@huawei.com>, <dev@dpdk.org>
Subject: Re: [PATCH v7 2/5] power: refactor uncore power management library
Message-ID: <20241021181841.4f8fb66d@hermes.local>
In-Reply-To: <20241021040724.3325876-3-sivaprasad.tummala@amd.com>
References: <20241020092233.2906612-1-sivaprasad.tummala@amd.com>
 <20241021040724.3325876-1-sivaprasad.tummala@amd.com>
 <20241021040724.3325876-3-sivaprasad.tummala@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Mon, 21 Oct 2024 04:07:20 +0000
Sivaprasad Tummala <sivaprasad.tummala@amd.com> wrote:

> diff --git a/lib/power/rte_power_uncore_ops.h b/lib/power/rte_power_uncore_ops.h
> new file mode 100644
> index 0000000000..f91994d3c1
> --- /dev/null
> +++ b/lib/power/rte_power_uncore_ops.h
> @@ -0,0 +1,230 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright(c) 2022 Intel Corporation
> + * Copyright(c) 2024 Advanced Micro Devices, Inc.
> + */
> +
> +#ifndef RTE_POWER_UNCORE_OPS_H
> +#define RTE_POWER_UNCORE_OPS_H
> +
> +/**
> + * @file
> + * RTE Uncore Frequency Management
> + */
> +
> +#include <rte_compat.h>
> +#include <rte_common.h>
> +
> +#ifdef __cplusplus
> +extern "C" {
> +#endif

Since this all internal doesn't really require C++ guards.