From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6063445BA3; Tue, 22 Oct 2024 17:35:00 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1F1BF4064A; Tue, 22 Oct 2024 17:35:00 +0200 (CEST) Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by mails.dpdk.org (Postfix) with ESMTP id 327B840272 for ; Tue, 22 Oct 2024 17:34:58 +0200 (CEST) Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-20cb7139d9dso52856575ad.1 for ; Tue, 22 Oct 2024 08:34:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729611297; x=1730216097; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=OmluKdhE6cV3TYF3ZKfhwVc3rWBiUB7pbr9QudyEQXE=; b=txC0TjzPVX0qO3vFzdDjc3RvKWZswnDq3Gb0774fDZTc61xExb7GIpT9+0W4KzmHkD ICisFXi20DSU0FsYrRnAiD1/YpsNEp9wp4yKY2WfHC4Ww632bCUfBkMsCNgwv+dCe16+ B/LfakJWt9RtYJZG1W8AcDVIkv0PcyVRl8IfGnWL1n+KINZ0XvYoARBy6bWyDkxnm8Jm KerJTWyrbNwQCw8G24wEBtOYOARmufVH4hBEMRGvuOj9d+LKq3hJLvmi4UYeoX0ZWtL3 DB4M9NKArY6mL6CXUXH7CxuNKaG2tC1jCNz2icE0kwXee3vW1+f/ZeRBfTPUoLTDx4Q4 D+rA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729611297; x=1730216097; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OmluKdhE6cV3TYF3ZKfhwVc3rWBiUB7pbr9QudyEQXE=; b=DVOmgHNdi/UajxeCuMsLtKR7Xz1nrQ0yAQWEaRM3ATP0EIlwEdYYiGHUuh770/Yb+8 MAi67caehI7KqtJJdzS0wKqDkpOz7IeRPOiLWrNQdEv0IgZ3iXJJnj6uXF558YD1k+Iq EpkW2gE9uopZxfGt/GR1SfhDOVqHndcGPfRMCJzxUooSjXte3KGHJNYY5IdNh7gx80SX 03t+Eo0Zg7YG9d4xZeEkmxQl3TrO224QfhGD9RxxJGWwX9R1jquYdwjcSYCyyLTzKYMk rhRYXuBtl0NV/b6g6R82JVdi2cZ254OUIn2m/YrYApk06li68i9YzEyakDWXAkgR1F/k Qtiw== X-Gm-Message-State: AOJu0YyAImYFSz/y/JAQN38lX7nwiMpad9JtIdlih0fzf7KLD9DsPp8J 8Ca0EfVRBza845wvKHyHJHz7aSHt37PXmJPQDHst5LmMbGOe2YW1IPkzfODr2xioIsVRppPKLXh tC+g= X-Google-Smtp-Source: AGHT+IF2tgeGXoHgPqbTH7ZWA/zWmi+VBy5386FDx8dC/N+2eernI+Zf5+njhHLaAT/zBwCuCbtulA== X-Received: by 2002:a17:902:ecc9:b0:20d:27f8:d72a with SMTP id d9443c01a7336-20e5a955803mr204433825ad.61.1729611297298; Tue, 22 Oct 2024 08:34:57 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20e9b080935sm13179975ad.134.2024.10.22.08.34.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Oct 2024 08:34:57 -0700 (PDT) Date: Tue, 22 Oct 2024 08:34:55 -0700 From: Stephen Hemminger To: lew@perftech.com Cc: dev@dpdk.org Subject: Re: [PATCH] ixgbe: Removed FreeBSD forcing wait in ixgbe_dev_link_update_share() Message-ID: <20241022083455.65cbfb9a@hermes.local> In-Reply-To: <20241022144205.49664-1-lew@perftech.com> References: <20241022144205.49664-1-lew@perftech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 22 Oct 2024 09:42:05 -0500 lew@perftech.com wrote: > From: Lewis Donzis > > Forcing wait true prevents checking link status without delay, because the function will wait more than 10 seconds for link status to be true. > > Signed-off-by: Lewis Donzis A little concerned that original patch was trying to address a problem. Fixes: 0012111a3d87 ("net/ixgbe: fix link status synchronization on BSD")