From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 89DA145BA3; Tue, 22 Oct 2024 17:58:55 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7C0254029B; Tue, 22 Oct 2024 17:58:55 +0200 (CEST) Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by mails.dpdk.org (Postfix) with ESMTP id E752640272 for ; Tue, 22 Oct 2024 17:58:53 +0200 (CEST) Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-2e2e88cb0bbso4276226a91.3 for ; Tue, 22 Oct 2024 08:58:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729612733; x=1730217533; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=5ckaGPWo5xxvbbHLN4DN3h7SZvpnQFtw71XntjRTWN8=; b=JitTbWmhiuoDjBX2F60EW/B3EQ8iI9VmwfaSpZaUH97mGWh5RFLnnEV2apBec98L1p Wmcmu9SwgQhZ2sV8A/0Gyl7NaTZ0DRMAXUkyxH68uWupc5VNObWDJcj6js5H6rutjGhM 1nId4URg215LhWewOGiFQFtc/iniYZGEqJyCUmGofu0oNcAjzPVaVz2UstUuQs6FVzEk b7AWGRdLV7Vd0ui31fqMwwsZ2VniDeOPUGkuwu4o9Fc8AMuK3O/xFut//O3LkYw9w5mz DfDIwxxL9jHyWuToda5X8GSPGaZF6N7OCqs+wFSOsjbBYZakfEZg7kQIAXgSZQDLUW09 Bwyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729612733; x=1730217533; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5ckaGPWo5xxvbbHLN4DN3h7SZvpnQFtw71XntjRTWN8=; b=X6sgy5pM701i8KKhT8HX3GHJpfvQNnqV6aDMNV4I7Uz2+9v7KHWeCRKqdIb0yCX+U9 BdWYhB1mmSKUXEZCf+bj1sf7jHOrcGUyrHQTbVjZzu/C+d1L1XxfBJ1P+glFFZiu7vnW HRTXoRq7FlB/tpzbq4J5MDJFDm0HfpkdvDQgivRTOBcq8w5YPoLSJf74sLrIH+cUNNZC 7Ke/X1Xyxx0uSf52K7sI5DAHMJ44uufjgs4eCF0laHEGhBs6sPRQfW1QMPRtFvu3yQyn gW4Z8cOhiWgQLGn/lcIbFl2nh6/ZfDMQOnVVliHojycCW2OySmj5KYMqoQ2x5Ivsd/u7 lBpg== X-Gm-Message-State: AOJu0YzxOAmYx1cRGNTnV8PBHpO8mpbW4hj1mQsjOZviyjpWNThKM4V6 ht906w3lzol3dvzPnYBGf5ZdW8Lg1m07LjXtVgJhZ5emJ4+c8oa3tJPRmKbZbms= X-Google-Smtp-Source: AGHT+IEPeGP1WrHPl51VTwZ4622o90KK8GMfXfz0ItXpJT+AcdgGUjDYeY2YKlsAymKZUiRVnUPgEw== X-Received: by 2002:a17:90b:2242:b0:2e5:5ab5:ba4b with SMTP id 98e67ed59e1d1-2e56164957fmr16103985a91.22.1729612732950; Tue, 22 Oct 2024 08:58:52 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e5ad510671sm6373234a91.47.2024.10.22.08.58.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Oct 2024 08:58:52 -0700 (PDT) Date: Tue, 22 Oct 2024 08:58:51 -0700 From: Stephen Hemminger To: Junlong Wang Cc: dev@dpdk.org, Hanxiao Li Subject: Re: [PATCH v13 03/12] common/zsda: add some common functions Message-ID: <20241022085851.34352ce4@hermes.local> In-Reply-To: <20241022125931.2128534-4-wang.junlong1@zte.com.cn> References: <20241019110428.1970056-2-li.hanxiao@zte.com.cn> <20241022125931.2128534-1-wang.junlong1@zte.com.cn> <20241022125931.2128534-4-wang.junlong1@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 22 Oct 2024 20:59:09 +0800 Junlong Wang wrote: > +#pragma pack(1) > +struct qinfo { > + uint16_t q_type; > + uint16_t wq_tail; > + uint16_t wq_head; > + uint16_t cq_tail; > + uint16_t cq_head; > + uint16_t cycle; > +}; > + > +struct zsda_admin_resp_qcfg { > + uint16_t msg_type; > + struct qinfo qcfg; > + uint8_t data[14]; > +}; > +#pragma pack() > + Not sure why you used a pragma here and __rte_packed in all other cases. Its ok, the effect is the same, but maybe better to be consistent. Packed is not even needed here, the compiler will do the same layout with or without packed in this case. No need for a new version but you may want to look into it.