From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B180A45BA3; Tue, 22 Oct 2024 19:17:51 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 485C240298; Tue, 22 Oct 2024 19:17:51 +0200 (CEST) Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by mails.dpdk.org (Postfix) with ESMTP id 46A3B40272 for ; Tue, 22 Oct 2024 19:17:49 +0200 (CEST) Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-20cb89a4e4cso41833875ad.3 for ; Tue, 22 Oct 2024 10:17:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729617468; x=1730222268; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=2hiMP5R8I9/5KQRTKN/JK0KdNSeNDZ/vuAQil6P3uCQ=; b=sjh7bA/NvO5Hu+SIIX+CXCHuT8TykBu+EHqmXF7ike2M0zU84UoSxOJTau/a97HpGI RBcVIPf2J0N6ghuMld0mAVd1ehJQ/N0f/Ef/vYXvEsVPiV7S27W1uO2sYz3ZypDMmqPR 8sUoApi3bi9i4/xxB+cMcKQ/0B2jG0B+pdfVdKhJ7G4qbP79kb6uaSFebDBMmddIr2An klapUbCWVYRWgNdJau24oX7jAmzFcMUdK21t+4ichgkSoJzQKcIAoP4PhtD9u/TwV68U YbTL+fsDI+XU2tIPlD98kP23d8afMSFFwYTz7A1v4yFIFuq0SPSPlYYt/zUEhv/9nFVI hitA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729617468; x=1730222268; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2hiMP5R8I9/5KQRTKN/JK0KdNSeNDZ/vuAQil6P3uCQ=; b=gCxfcoZps3BUnReDoxTfD8EQEuhGnQnpEFMe3VKRLJMN63zZ30v2pt5WP7Qh5jxDR8 e3aBxzSdxT6fAcm7ltaqZx5z3cWT2FW8jLpiphCyp7bSHqHrQ6ECoBtHsSFcRUebJlbN TpTGOAQRR3XcfKA+JhxTdMUxN3ywrc2yphpR3jIhyiKtn9upXH5a2K9BPt5HtohUOuzu zwHOI8NEY8FnIO0qLyrWghkv8RzVRpwhS2ArbigSbCwuO0kstVABH85JbNWWR3c4FH4Q ThPiPPasZR0+m+o8c3RunZNEvdOHWky6dt4R3Lt7fQqf9g70e19mf3E2Q6StbI/qI7RB ZnDQ== X-Gm-Message-State: AOJu0YxPIPrf10vKmFWA8ilM2s/6mjAfd8B6KA3zpZgVKX8JifcUQfuk 8ErX2iiYXcWnSGn6/ub7o8RSP6cIbd4BzWdYVd6WvoV1AY7y3maLyFbep1kbIuY= X-Google-Smtp-Source: AGHT+IHm4yjM7Ab2KRFZJOGTW5xpQ8ffXD/wQEZTLE6HcrF5qtOwdyEc0Ne2hrF1XzJvhIya2szt2A== X-Received: by 2002:a17:903:2301:b0:20c:9eb3:c1ff with SMTP id d9443c01a7336-20e5a94b609mr210685415ad.59.1729617468243; Tue, 22 Oct 2024 10:17:48 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20e9b0b33adsm14091925ad.237.2024.10.22.10.17.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Oct 2024 10:17:48 -0700 (PDT) Date: Tue, 22 Oct 2024 10:17:45 -0700 From: Stephen Hemminger To: Serhii Iliushyk Cc: dev@dpdk.org, mko-plv@napatech.com, ckm@napatech.com, andrew.rybchenko@oktetlabs.ru, ferruh.yigit@amd.com Subject: Re: [PATCH v2 07/73] net/ntnic: add NT flow profile management implementation Message-ID: <20241022101745.4e664dc4@hermes.local> In-Reply-To: <20241022165541.3186140-8-sil-plv@napatech.com> References: <20241021210527.2075431-1-sil-plv@napatech.com> <20241022165541.3186140-1-sil-plv@napatech.com> <20241022165541.3186140-8-sil-plv@napatech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 22 Oct 2024 18:54:24 +0200 Serhii Iliushyk wrote: > diff --git a/drivers/net/ntnic/include/flow_api.h b/drivers/net/ntnic/include/flow_api.h > index 790b2f6b03..748da89262 100644 > --- a/drivers/net/ntnic/include/flow_api.h > +++ b/drivers/net/ntnic/include/flow_api.h > @@ -61,6 +61,10 @@ struct flow_nic_dev { > void *km_res_handle; > void *kcc_res_handle; > > + void *group_handle; > + void *hw_db_handle; > + void *id_table_handle; > + Use of untyped pointers (void *) can lead to errors, it would have been better to make these struct pointers.