From: lew@perftech.com
To: dev@dpdk.org
Cc: Lewis Donzis <lew@perftech.com>
Subject: [PATCH] ixgbe: Removed FreeBSD forcing wait in ixgbe_dev_link_update_share()
Date: Tue, 22 Oct 2024 09:42:05 -0500 [thread overview]
Message-ID: <20241022144205.49664-1-lew@perftech.com> (raw)
From: Lewis Donzis <lew@perftech.com>
Forcing wait true prevents checking link status without delay, because the function will wait more than 10 seconds for link status to be true.
Signed-off-by: Lewis Donzis <lew@perftech.com>
---
drivers/net/ixgbe/ixgbe_ethdev.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index ab37c37469..008760e315 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -4314,11 +4314,6 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev,
if (wait_to_complete == 0 || dev->data->dev_conf.intr_conf.lsc != 0)
wait = 0;
-/* BSD has no interrupt mechanism, so force NIC status synchronization. */
-#ifdef RTE_EXEC_ENV_FREEBSD
- wait = 1;
-#endif
-
if (vf)
diag = ixgbevf_check_link(hw, &link_speed, &link_up, wait);
else
--
2.46.2
next reply other threads:[~2024-10-22 14:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-22 14:42 lew [this message]
2024-10-22 15:34 ` Stephen Hemminger
2024-10-22 15:58 ` Lewis Donzis
2024-10-22 16:16 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241022144205.49664-1-lew@perftech.com \
--to=lew@perftech.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).