From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3A71645B4C; Tue, 22 Oct 2024 16:42:46 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BC91E4029B; Tue, 22 Oct 2024 16:42:45 +0200 (CEST) Received: from fbdev.perftech.com (fbdev.perftech.com [206.210.221.26]) by mails.dpdk.org (Postfix) with ESMTP id 85F474029A for ; Tue, 22 Oct 2024 16:42:44 +0200 (CEST) Received: from root (uid 0) (envelope-from root@fbdev.perftech.com) id 71936 by fbdev.perftech.com (DragonFly Mail Agent v0.13+ on fbdev.perftech.com); Tue, 22 Oct 2024 09:42:43 -0500 From: lew@perftech.com To: dev@dpdk.org Cc: Lewis Donzis Subject: [PATCH] ixgbe: Removed FreeBSD forcing wait in ixgbe_dev_link_update_share() Date: Tue, 22 Oct 2024 09:42:05 -0500 Message-ID: <20241022144205.49664-1-lew@perftech.com> X-Mailer: git-send-email 2.46.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Lewis Donzis Forcing wait true prevents checking link status without delay, because the function will wait more than 10 seconds for link status to be true. Signed-off-by: Lewis Donzis --- drivers/net/ixgbe/ixgbe_ethdev.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index ab37c37469..008760e315 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -4314,11 +4314,6 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev, if (wait_to_complete == 0 || dev->data->dev_conf.intr_conf.lsc != 0) wait = 0; -/* BSD has no interrupt mechanism, so force NIC status synchronization. */ -#ifdef RTE_EXEC_ENV_FREEBSD - wait = 1; -#endif - if (vf) diag = ixgbevf_check_link(hw, &link_speed, &link_up, wait); else -- 2.46.2