From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 754DE45A68; Tue, 22 Oct 2024 20:30:18 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6815440651; Tue, 22 Oct 2024 20:30:18 +0200 (CEST) Received: from egress-ip11a.ess.de.barracuda.com (egress-ip11a.ess.de.barracuda.com [18.184.203.234]) by mails.dpdk.org (Postfix) with ESMTP id 5B13E40614 for ; Tue, 22 Oct 2024 20:30:15 +0200 (CEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05lp2107.outbound.protection.outlook.com [104.47.18.107]) by mx-outbound40-26.eu-central-1c.ess.aws.cudaops.com (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 22 Oct 2024 18:30:14 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=k9ob8PRjq8uSibBrl3t3zjiH+vfxcOqiB9EhJutTsKrif0NhHpbOipnLsvn8tuhEECkP3I1MVe8qovYedHQ4hM3i2JLHxmh2pPx87QrfI8P/z+feYj9X5kTVuxPMaSqEWzE5/3V4BC6BaUDk0qEOibEkx+Tr9JH0AdRpz/Ocs0tLDocx5SejNs1mUbrjs/UI7r5QQX5bSRAzfYTvfMSCJEdp9VQerJMgzkE6UJSOLPzg0g3ZhP8LZasutF7eiD4tENpG9KJu8zBqHYKEmFuHWFq9uWWYdZCz7PBI11+Is8YINVPudWXgehAiGg1/CYPchMQ6JTA0ihj6We7mc2OWrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8NFiLkeljKrC5AYmmMuS17C4vL868yfqae+jovAMpb8=; b=NyNqFw/OmZwilIfIhCryYb/suddfan20l4mLgikJf5YHva9dS2OpDObPAvEohXV9RPCc8qeeZWcZzOD/JPKDZJAEWesNWDpna4m6W034R6F+YL/Mc51C6ATteXL+RwOjHe8NCC7457vPOROAiL+RTdVSEzDgTHFGSyM0781cbqRHHc5mutOmQ9RMq+JkXWlYmdFbt879HgvRWJqXS858NH01mMbXm28thqnrV69xCOnzBNzea7hoyRB6sDkBfJbgO5iU7DZt2jrFT5xyfNzu9R+G44rXFF5AQ/wR6ytIgHZcwj2YEA3w4ANV6dU0PTBpuyOtuMQDIP3HWqQogk4dFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 178.72.21.4) smtp.rcpttodomain=dpdk.org smtp.mailfrom=napatech.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=napatech.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=napatech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8NFiLkeljKrC5AYmmMuS17C4vL868yfqae+jovAMpb8=; b=mpoEFwtZ41iQUFEsLEVVCVhLir/cNUytuqq3h/x6m3DFk5/4DTzsEkTA1Z1X9JDA9/q1+TnZnE09qz8LTt3NTrCsyJ2dQTHrAaukpqi6FXEXbzn1xQPC1z1EKvXgzgup5MQnKlEC9s3dIqE+WMQ3JsbfpgWjE+jwUBHAkazN+Wg= Received: from DB9PR06CA0024.eurprd06.prod.outlook.com (2603:10a6:10:1db::29) by PR3P190MB0809.EURP190.PROD.OUTLOOK.COM (2603:10a6:102:82::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8069.28; Tue, 22 Oct 2024 16:56:54 +0000 Received: from DU2PEPF0001E9C2.eurprd03.prod.outlook.com (2603:10a6:10:1db:cafe::a5) by DB9PR06CA0024.outlook.office365.com (2603:10a6:10:1db::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8069.29 via Frontend Transport; Tue, 22 Oct 2024 16:56:53 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 178.72.21.4) smtp.mailfrom=napatech.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=napatech.com; Received-SPF: Fail (protection.outlook.com: domain of napatech.com does not designate 178.72.21.4 as permitted sender) receiver=protection.outlook.com; client-ip=178.72.21.4; helo=localhost.localdomain; Received: from localhost.localdomain (178.72.21.4) by DU2PEPF0001E9C2.mail.protection.outlook.com (10.167.8.71) with Microsoft SMTP Server id 15.20.8093.14 via Frontend Transport; Tue, 22 Oct 2024 16:56:53 +0000 From: Serhii Iliushyk To: dev@dpdk.org Cc: mko-plv@napatech.com, sil-plv@napatech.com, ckm@napatech.com, andrew.rybchenko@oktetlabs.ru, ferruh.yigit@amd.com, stephen@networkplumber.org Subject: [PATCH v2 52/73] net/ntnic: update alignment for virt queue structs Date: Tue, 22 Oct 2024 18:55:09 +0200 Message-ID: <20241022165541.3186140-53-sil-plv@napatech.com> X-Mailer: git-send-email 2.45.0 In-Reply-To: <20241022165541.3186140-1-sil-plv@napatech.com> References: <20241021210527.2075431-1-sil-plv@napatech.com> <20241022165541.3186140-1-sil-plv@napatech.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PEPF0001E9C2:EE_|PR3P190MB0809:EE_ Content-Type: text/plain X-MS-Office365-Filtering-Correlation-Id: 5b98d76c-8848-44ca-3ada-08dcf2ba87fe X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|36860700013|376014|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?65HAcxnlRi98t1hEWK63q9WXKVA9ssez8vEisyQ1I8+WQF+R4j3cIT2vXEk0?= =?us-ascii?Q?JItZaP1R9RuINO43hn6tfH1MULd222DiXN123IFeUW0Jl3Hq9ya1TMPe1jKt?= =?us-ascii?Q?aiKwi2Z9PRC9WD20Qot1fZmGEi4ST8m5e766qU0HF9x3IR81kQSz5Bu2T2zK?= =?us-ascii?Q?51/bDjVkIzEA5XaU+lpTmFLqedWvQR5IwOU8VbcidWe3ZBTnlVhT0Yl0iIrj?= =?us-ascii?Q?qjRX9B/HHyIjMB7Q5qvFUFyI59B4oWlD0WJ5ksWjAgNGlmKJGlTSHx2fkMvR?= =?us-ascii?Q?J8mv3NGGUNrKHFO9XvcvKYyZjVu0UQ9kSk3zopOWg3NbV8SFKuPTbQsHcbaW?= =?us-ascii?Q?3y2Gn5GGx5WngTpGYF0OixCUCpFkqY2XTwHe2Wiad0DN4ILQZefJBIfcMpy+?= =?us-ascii?Q?zWS+g9FwIfCNh2rLNRj3X+uyNQTBacnjf7x9TGyr/5qKo3Ed46tWLBA/X9+K?= =?us-ascii?Q?oP1Ej7sxXssIdmwjHJ7J5unMne497xgFdfwhC+6Rphj7xwElDzWv/KJxbRR1?= =?us-ascii?Q?O8KsjJx0tFj1lbDMuYk9It30TynXXov8NrLSFY/iq1Z2UblXpc/vOrM0tcde?= =?us-ascii?Q?2LI+mJDoWrjYiaLUEtAPfMHuS0/ID8raKqmV06AkfYdWq136YydKfUJMipMJ?= =?us-ascii?Q?6D3WwgOl5pX7CG86IDouDLz6qBBCUOkaJysknO9UnKhd+lcZlJRETJDydSse?= =?us-ascii?Q?rlX/7O7EZZ47/oxYEKfn9r7ds/6n3Faml6r5Mf7JH/JLJg76+Ayu/kTHS/3u?= =?us-ascii?Q?/gjxuQHAA7yT8N3uxMuvielqcA50Q1hbKOgfDse9ruzB0L6iYjLQiniDHQ+S?= =?us-ascii?Q?CzPBdv99Z040bRnJd2Hnlq6k/uXxo8QP5bhkaUhIA4Cj9zwNVZkzpwOZcBX6?= =?us-ascii?Q?apfd7tAHR+wB+bgneDUhB2CQOGktVSF+C2i6f1jNuOj0Mt1Q86QRftrc08ya?= =?us-ascii?Q?++QH6MzDO7VUmgosbBMOUjbwvpkVbS11tgbzes5eDuTJtc85MFkrwrx38qie?= =?us-ascii?Q?hF4OBE6JQms60N+tdee0i193Wco+3EkKXKDvFvyI4pvBBObuAD+E8btu3XBb?= =?us-ascii?Q?PYDnAjJVuN1bkFujbDv4Xrsgu+kA1NiwCSBJsQ2u9ozb3o8BwNWQlFwCbedc?= =?us-ascii?Q?1cMwZ8KnvdDuHnJZ8u9Vzihnnuc/AN/oPkqIKI3YyarxBTMYJvKSjjRG+cJ/?= =?us-ascii?Q?4GnjAsRmgKyE1zD19DIWHB//s0cOMgW1yi8GIseCiREvKPQF+4+YolQxRhKR?= =?us-ascii?Q?mRubmYzh3q9rAXgjzhJJeA1sXqRtJzRRS5fnhX8JRBl0gN0+RmdLia0dhJ71?= =?us-ascii?Q?VefN9pPLrPN/5BZEiLHgfkCvVFmmZsOxQ/A0+/fWFdwBoKKmxFRpJt9Zxhn8?= =?us-ascii?Q?WEw8LkyV2lsHnYzZ+m42s4/efesvZ1lsgNFcrWHpu4A8prt/xQ=3D=3D?= X-Forefront-Antispam-Report: CIP:178.72.21.4; CTRY:DK; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:localhost.localdomain; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(1800799024)(36860700013)(376014)(82310400026); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: plxnlKTQFS4dx3ji3Y5NWFPuT1QeOpD1jBAZ3/pX7MCO86KC+QwDXB/Qcof5Ce/PA+Io1tNy0ZHwR7Xhq61+P+2UD6/+PA14WAxo1KfRsVD2iH4xRqvLkXnv0fE0BI9DhnxAgsiDUtGYC6rN7aBYozun9gxDPZF/stc9KY2fNmrH7j98tr6fyUnfWpeOcmu/WNBhAzES5RFAC7L6L5VN1A2QPM6nRAMsQqwjMX3ZjVmwfPE+xwHyhXnSw42/w84oV5oWAWftxjIwLJ3XjzOLobrVcgtcpKVfa9KFEVgDwJ6Fd/j6S+vivjHeM3qsdNb3Lu8fr3dCJBGOoZr6yJd6A/0W7TfslbiHKS6maqPU8gU+ndfPXNwtMP46UAxR5xxxDjK8zSV8BlFHSTWXcjlKH8+mRCa3zYcGUQJBcpijtDhJYkVbk2rBVE49J0SLCH/PBcBKctr2S4IqDfja7y3CJgZY+4sneHz2mb928IB8wbJ7oJlUiqzrLDCRsG676wPBncpBMuRtSMLdH9dM8bTqo8sPRHEDBM/eXFQsGBrZyET+/wWxc8+WSjjcDf3tp5sLtoHpheoNZBpOPkLMvEweciS6gfjcRmfObpXU5MWhY1D+jJefzipTQaAUAjXhRTViPC9lNR7CPtY3RItuA/RQ+vPRUiiRcFE+TQbpPnjCInY= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Oct 2024 16:56:53.6379 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5b98d76c-8848-44ca-3ada-08dcf2ba87fe X-MS-Exchange-CrossTenant-Id: c4540d0b-728a-4233-9da5-9ea30c7ec3ed X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=c4540d0b-728a-4233-9da5-9ea30c7ec3ed; Ip=[178.72.21.4]; Helo=[localhost.localdomain] X-MS-Exchange-CrossTenant-AuthSource: DU2PEPF0001E9C2.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3P190MB0809 X-OriginatorOrg: napatech.com X-BESS-ID: 1729621814-310266-12658-16895-1 X-BESS-VER: 2019.1_20241018.1852 X-BESS-Apparent-Source-IP: 104.47.18.107 X-BESS-Parts: H4sIAAAAAAACA4uuVkqtKFGyUioBkjpK+cVKVobGFsZAVgZQMNnEwDw1LTXRxN LMwiglySDNONk41cTA1NDCwsDELMlMqTYWAHortgVBAAAA X-BESS-Outbound-Spam-Score: 0.00 X-BESS-Outbound-Spam-Report: Code version 3.2, rules version 3.2.2.259903 [from cloudscan23-254.eu-central-1b.ess.aws.cudaops.com] Rule breakdown below pts rule name description ---- ---------------------- -------------------------------- 0.00 BSF_BESS_OUTBOUND META: BESS Outbound X-BESS-Outbound-Spam-Status: SCORE=0.00 using account:ESS113687 scores of KILL_LEVEL=7.0 tests=BSF_BESS_OUTBOUND X-BESS-BRTS-Status: 1 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Update incorrect alignment Signed-off-by: Serhii Iliushyk --- v2 * Fix __rte_packed usage Original NT PMD driver use pragma pack(1) wich is similar with combination attributes packed and aligned In this case aligned(1) can be ignored in case of use attribute packed --- drivers/net/ntnic/dbsconfig/ntnic_dbsconfig.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/ntnic/dbsconfig/ntnic_dbsconfig.c b/drivers/net/ntnic/dbsconfig/ntnic_dbsconfig.c index bde0fed273..e46a3bef28 100644 --- a/drivers/net/ntnic/dbsconfig/ntnic_dbsconfig.c +++ b/drivers/net/ntnic/dbsconfig/ntnic_dbsconfig.c @@ -3,6 +3,7 @@ * Copyright(c) 2023 Napatech A/S */ +#include #include #include "ntos_drv.h" @@ -67,20 +68,20 @@ } \ } while (0) -struct __rte_aligned(8) virtq_avail { +struct __rte_packed virtq_avail { uint16_t flags; uint16_t idx; uint16_t ring[]; /* Queue Size */ }; -struct __rte_aligned(8) virtq_used_elem { +struct __rte_packed virtq_used_elem { /* Index of start of used descriptor chain. */ uint32_t id; /* Total length of the descriptor chain which was used (written to) */ uint32_t len; }; -struct __rte_aligned(8) virtq_used { +struct __rte_packed virtq_used { uint16_t flags; uint16_t idx; struct virtq_used_elem ring[]; /* Queue Size */ -- 2.45.0