From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8F57745BA6; Wed, 23 Oct 2024 03:04:22 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7B7CD40272; Wed, 23 Oct 2024 03:04:22 +0200 (CEST) Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by mails.dpdk.org (Postfix) with ESMTP id 4C5F940151 for ; Wed, 23 Oct 2024 03:04:21 +0200 (CEST) Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-2e5a0177531so2447649a91.2 for ; Tue, 22 Oct 2024 18:04:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729645460; x=1730250260; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=qF/buSsvoGgka3dIMGlZMVJEwsCWbvoADfM0qttVTA0=; b=wDRpk8g1HEzS2wQ+/5ON0ZzeUxpmOVW7i5upxiC0bPWXyA94z4k2S5dTO4yQ6W7x0E ORtC5rS4gqKsvOkE0lK3pJu1mkacyC1NspFqVZgBRKdEOMB4uvFxtHeo2FcHqxPCkWix L224zvkQnd610UW9J9lIhyixfsfg5602MeAWZjkSRjZE8Et2U1CATwSF5BrAz4dkzzm2 D+MVhyGTuGpCRLVpyDlC1TI2T7wIWYZTr/ErX7npabuJG39VJhRWw5QRfWKjRulRiQDD KzTHooxSjQHpd/yIluSEQZY+he8TxZpzYaM1fmSPqcNZz6P4wTreqQA3B9n7iL5bm8k1 tW4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729645460; x=1730250260; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qF/buSsvoGgka3dIMGlZMVJEwsCWbvoADfM0qttVTA0=; b=IMv2NQxaI8YQoNYZTQUAsGaNhp3BD2PmnNX12DfSGUVb45bMZyQDRUw7BF3zD3eQVo ALavK9lKBmbL5NrqrfW8CBaX1iBsMJfGKvEdjB55mdTp9nuoYucIsUg9+tLwsx5NkU75 l5xY16YKhnzHny+BxjXu01RbpGvkxKSxSaw8A7eawcbyVD8bCd9D9arXD9ygPT3nVcGS aLmfVWXgTN0ggeG1jzOul0N7uPtq15g+Ik/W4AiDhL2LOYXnIG2BTYyKGfaF8Jhkoqm+ 3+h37nBux8hbS80sc/4mGg4jq8ZOPze/HQCyAZAK+FOlyRbQLj5Wq1HQaMlmc1c2ys/H tB0Q== X-Gm-Message-State: AOJu0YzatZlu+0vVFbHw2yxSgMTa5VX1b6YNkA4jbMMCq3r2WO9VxAaq 1lanL0+kcpum9jGyemAS/ojacMN90VkMp1h6RgfP5FGoeHov7++klWkEcxznYCY= X-Google-Smtp-Source: AGHT+IEv+4L+/jKddqcfRnvJL8ronjGUNmWErJSFEA0aKkLh2q/Mp7VeFGQvF14x7vCSME+xC6QEAg== X-Received: by 2002:a17:90a:bc85:b0:2e2:d197:40f3 with SMTP id 98e67ed59e1d1-2e76b71105fmr924183a91.35.1729645460437; Tue, 22 Oct 2024 18:04:20 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e76df29cbdsm94727a91.12.2024.10.22.18.04.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Oct 2024 18:04:20 -0700 (PDT) Date: Tue, 22 Oct 2024 17:52:51 -0700 From: Stephen Hemminger To: vanshika.shukla@nxp.com Cc: dev@dpdk.org, Hemant Agrawal , Sachin Saxena , Jun Yang Subject: Re: [v4 23/42] net/dpaa2: flow API refactor Message-ID: <20241022175251.654d8e5a@hermes.local> In-Reply-To: <20241022191256.516818-24-vanshika.shukla@nxp.com> References: <20241014120126.170790-1-vanshika.shukla@nxp.com> <20241022191256.516818-1-vanshika.shukla@nxp.com> <20241022191256.516818-24-vanshika.shukla@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 23 Oct 2024 00:42:36 +0530 vanshika.shukla@nxp.com wrote: > From: Jun Yang > > 1) Gather redundant code with same logic from various protocol > handlers to create common functions. > 2) struct dpaa2_key_profile is used to describe each extract's > offset of rule and size. It's easy to insert new extract previous > IP address extract. > 3) IP address profile is used to describe ipv4/v6 addresses extracts > located at end of rule. > 4) L4 ports profile is used to describe the ports positions and offsets > of rule. > 5) Once the extracts of QoS/FS table are update, go through all > the existing flows of this table to update the rule data. > > Signed-off-by: Jun Yang Before it looked possible to dump flow info to file, now it only goes to stdout. Is that ok?