From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0C76545BA6; Wed, 23 Oct 2024 03:02:47 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9D13F40272; Wed, 23 Oct 2024 03:02:46 +0200 (CEST) Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by mails.dpdk.org (Postfix) with ESMTP id 0D95140151 for ; Wed, 23 Oct 2024 03:02:45 +0200 (CEST) Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-20cb7139d9dso57266085ad.1 for ; Tue, 22 Oct 2024 18:02:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729645364; x=1730250164; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=AcMAtBthBnYH7C8m5S2fxLSeYs69q/7almRniSxk1s8=; b=LI0GiWw2UznnAt98b/mWstavqAqe5cEzQjAPqztH0AjwZz0T+0NDnE6kZovP23+S6n vy9G2hK24zYF/YktaCf9S8pfh9DAAr/UDU/nN433NE8tzucKiCKQt83G8YnrZzMT/mRL 0iJIfpOraXPEYqE50oUCsNlw7Ir0drcukTlRQG9qVSQAWShZz9ySF6Yms+a2vDQDSAuy A3NrjT1ec8fOXnJFXrw2vlV/n2yYQu3yGb6V/zSOZR2aI+YWIkQqYKZVcpUHQu6bnO3n XLK/UrLY19L+daNvvOQHlCwVsCpZBAFky8LOVsJJA+2QDWrnmRZu0ta9uHrAagGxm50a IVOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729645364; x=1730250164; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AcMAtBthBnYH7C8m5S2fxLSeYs69q/7almRniSxk1s8=; b=STlrkyH7ffDP5ZguV1AVvpJ2nRy7P3bmixEEXjs2UIFGmiszuyjp2Fv6+/bDp68CGT kjtSKzz5hOjXP7zhQVVh0zcZsnYqO+ZSzAaO5x+haXCqJOF2NpAkB4dDF7NbXkFx0Tg9 /Ez0e/O75913Ap4hBLoJxi8B6DRZ2vlNsa+ccQnuE2Xw2aSG/oZlncdzxTDYJC8rgHdP aORW3g6+/GOq/qS1ASmgpXOvEzyZvTCc53qJakgZZtTxWq1RLdHrRaRQ2TqECzmt08Cz DIcenaLzce+12Jqi58nEUyeO7eo7J7ewhVmzoS6cuYqoqOOlWflt8CBCqrFrOT5FDcAF g9fQ== X-Gm-Message-State: AOJu0Yzh6XOhqgyScOy8CWbb/ig9eJ2WqjaJrCr5H28Z9lj/+ZcVNVYp aUd+iJvHu6lZrKHGmiyNLpkGxDu4fd0HiqwCLar/kyhuvxwjOOsW/e0Z5MWeDK3kT6sH9hJrd5p s X-Google-Smtp-Source: AGHT+IEc6d4DlH6sfokGa+2s24VmTv8+3jiwli/Qu8XccZzQ0ppnD4azROOMfDsTQVOnvzf9BK2x+g== X-Received: by 2002:a17:902:f7c9:b0:20c:ccb7:df84 with SMTP id d9443c01a7336-20fa9ea090emr10774225ad.42.1729645364149; Tue, 22 Oct 2024 18:02:44 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20e7f0c0e2dsm48068075ad.123.2024.10.22.18.02.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Oct 2024 18:02:43 -0700 (PDT) Date: Tue, 22 Oct 2024 18:02:41 -0700 From: Stephen Hemminger To: vanshika.shukla@nxp.com Cc: dev@dpdk.org, Hemant Agrawal , Sachin Saxena , Gagandeep Singh , Jun Yang Subject: Re: [v4 16/42] bus/fslmc: dynamic IOVA mode configuration Message-ID: <20241022180241.55e19e10@hermes.local> In-Reply-To: <20241022191256.516818-17-vanshika.shukla@nxp.com> References: <20241014120126.170790-1-vanshika.shukla@nxp.com> <20241022191256.516818-1-vanshika.shukla@nxp.com> <20241022191256.516818-17-vanshika.shukla@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 23 Oct 2024 00:42:29 +0530 vanshika.shukla@nxp.com wrote: > + if (mem_rsp->mp_param.result == SOCKET_OK) { > + rte_memcpy(&fslmc_memsegs, > + &mem_rsp->memsegs, > + sizeof(struct fslmc_dmaseg_list)); > + rte_memcpy(&fslmc_memsegs, > + &mem_rsp->memsegs, > + sizeof(struct fslmc_dmaseg_list)); Why are you using rte_memcpy() instead of a structure assignment. Using memcpy loses type safety.