From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0AE0545BA5; Tue, 22 Oct 2024 20:42:25 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B821040B99; Tue, 22 Oct 2024 20:42:20 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2084.outbound.protection.outlook.com [40.107.244.84]) by mails.dpdk.org (Postfix) with ESMTP id 6023A40DDA for ; Tue, 22 Oct 2024 20:42:10 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hJJSda5HgJNTcxVHZi41tx9j/gYBY9/il03AL4KJKgCh4rtyJoxh9tSptptN0oWwpvU4joRN4qwFhW4v7NRG0xVvPWS+XEDO0GdPZqjnJnZWXdo0i5PJhqCEZC6iw1BH6KWH+63V2iHKOlHL6mIXRyRXoDDUN4Jt1FXUJtQ+7Fnbc30Vt+eCqO1+8VTMiMKsLZRc/Dy/d9Z2peGAKvErjutDHEgudDWXJ7nQ5pPKky7xybiZz/x8dl+p9AInX4TT18VmTfrPI91SjCd1/Gb+l61Sb0xao8RdWuZteLzbj/BlbYNwQQdH/edUTzCgVYq5Qy8XmaL0JJ5nw3SFBuK5qA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=A7Uf3Jw2cJ3E7iCkMoYaS7w0bT4qgeYpA3+tXTFvpgs=; b=p3gj+xNcWb2msOFh61/Dil4aI8sAAxzSlxNaC0Atr0KAZhYXT1rPHNTC/+Ty3cETF/Iq4AykcEvcZ34J9w8gM0UH3pRmcreoZzbX8cHygpmN9RPQQ8P1v4ntdcwTIZMzgcP6mNTjdaw+6//yCWBez8cLpxzo30ClfjdBa2jP73p6AGdDOBIN8Lw9kcj5SYpX5hbTxF+fZwoEjv4RjaLLrWuzZzhzaoD8qjiP1EZn1wnZMM45fIZt+BQ2FH2p8BxxyDwwKkxNvt0XAW2RRc3tiZs9sMi9dHUciJwjNh1hgNG0ujYYxfKl/6ge0afhTo0b2vek5rJyLAx6Bq5gJaZoeQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A7Uf3Jw2cJ3E7iCkMoYaS7w0bT4qgeYpA3+tXTFvpgs=; b=a71zzkkzCa1xl5GR1HojG+D7UEFhjjHoTE95b5YpkUAYjQnj6XBjGY8ahkQtzvFEeQzJhVa1uo8tOCMbKWomEQsFVcqkPZTsw3QpiS/zofp+xnF+iOn4CpgFxkvJvpjSMpdhip11BYn6My6sYD5lVRT6Ca3PocYtW5j8mBPoLpM= Received: from PH7PR03CA0016.namprd03.prod.outlook.com (2603:10b6:510:339::13) by IA0PR12MB7554.namprd12.prod.outlook.com (2603:10b6:208:43e::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.17; Tue, 22 Oct 2024 18:42:04 +0000 Received: from CY4PEPF0000E9D2.namprd03.prod.outlook.com (2603:10b6:510:339:cafe::a7) by PH7PR03CA0016.outlook.office365.com (2603:10b6:510:339::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8069.29 via Frontend Transport; Tue, 22 Oct 2024 18:42:04 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CY4PEPF0000E9D2.mail.protection.outlook.com (10.167.241.137) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8093.14 via Frontend Transport; Tue, 22 Oct 2024 18:42:04 +0000 Received: from jfw9ny3-os.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 22 Oct 2024 13:42:01 -0500 From: Sivaprasad Tummala To: , , , , , , , , CC: Subject: [PATCH v8 3/6] test/power: removed function pointer validations Date: Tue, 22 Oct 2024 18:41:29 +0000 Message-ID: <20241022184133.700367-4-sivaprasad.tummala@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241022184133.700367-1-sivaprasad.tummala@amd.com> References: <20241021040724.3325876-1-sivaprasad.tummala@amd.com> <20241022184133.700367-1-sivaprasad.tummala@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9D2:EE_|IA0PR12MB7554:EE_ X-MS-Office365-Filtering-Correlation-Id: 075c013f-0bde-449b-e0f8-08dcf2c9396c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|376014|36860700013|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?hu+UvwKpr7Z51rzuaKGNG2D49djVtPDAXPEyycJXGbM/XSfkFgxjFjsUCTSI?= =?us-ascii?Q?YsAlMG/Bq92oSf88fuqjhiTtGSjgJJ+Ng9gq+Kr3p7vwHdhA+aRUilUQ9ywm?= =?us-ascii?Q?dqwVKyOVdiSvXTQBebSoJsgh52lAuHs5fjDvw81YwigOsq9iFPOQUb+g8XwR?= =?us-ascii?Q?0DFqiPKmWnumI6PVUCx0dth/kcHHrKLvubbYddDV29twb0qmPkeA3FfOHeD1?= =?us-ascii?Q?OafvFHM9RwOLqAl7BeUNUbGWDSBDE6LX6tvQtWaRmuUlak04ZqakFdQGkaxs?= =?us-ascii?Q?chg4pehuKXgS/pVIRGRTwYLX7V1Kvf86Ck/IMkfj5nP6lMj0u4th4k07cW/o?= =?us-ascii?Q?duRU7DQxUB9loJpIuMTBM3Lq+RPmdxvf+6Ql33/U+0YDV2ry3wkHCrZ/40UH?= =?us-ascii?Q?HV4KS1hMVuIG1Rq01u4CqvhNqFwvuRy81K8hsfsdJT010igBC4hmDlqMHIBS?= =?us-ascii?Q?ZS/JiYDS3RD5kBdgRmfrT9Mn6GZiBG1vQGMh++tpoREm5khL7Xzdg/vc1Nbi?= =?us-ascii?Q?c6+5gH5L1rRec0OkaaaZtKzP6eQsAvrtUiq2zeieys8sHVTEad4xdcwgbf0q?= =?us-ascii?Q?Ek3BXcyYbVb0gjbMCLw+yvezNt6wzTrdkpgy6kENTasZayn53Z44/9ECrXPp?= =?us-ascii?Q?gfBH+Naq+TCn6CMfBnsFw2jFMIhmal8oyhNQo8jyVyLqwGaqSmhKYRxmWlno?= =?us-ascii?Q?xHvozy4gZzfp7RuqHJQ4Rgw3zFf9Hn9uXc2+kTaOhKXkRAh9Nus0EQWp3JDM?= =?us-ascii?Q?5Z1+lDw6OtU+SPWiGXrRSP13s0xMyD7M8CJyNhMVqW1cmzGRLWWkNpR0Kw0O?= =?us-ascii?Q?RFtpCjWDkrLqN7rCJqCc+/dZMdkAIb0wKfbXBpVBOzE+zihcF8z2DbPz873S?= =?us-ascii?Q?Zb3oQ6Seo/+Ghb180xl1DStPwbliwAeGxsKR6aDn2W//QYTJKlU29HNAQBUz?= =?us-ascii?Q?rPN5veLHY8iFnZZOe9YrHLlcr0+PEoWKJ3xXfLettz0GT6bbgE1mfgBOtO/H?= =?us-ascii?Q?aM6Jz6cFQ1KAPfWGh3XjwJn0yv8zjz22W5EPNW3QK5S/VahBctT5o3O6Xrgo?= =?us-ascii?Q?IfiIrZj4Fw8wyotAFfzIOoexVU0GEITmDx0vMDyuqLSmudq42mWKmSaZ5abd?= =?us-ascii?Q?WD7uwTd+MwNwW8NYSn6WsgqvyRebGqVHL1WaGYdPCU2XXRVxbXlvM1jZ8UbJ?= =?us-ascii?Q?udtLItoBNSfAQ3gLduvtpuUYGPN0waTiBibssF0JO4ZOt8b5BRZTfsYIVcyo?= =?us-ascii?Q?UOIBaMh8l/3j1D733P3wIJ/0zZLJF2+ORoIrzeR6Au+VZZ6MxV0acih5g4v3?= =?us-ascii?Q?ORVi/dqRn39cmjVVt20qb5cYq+1doP+Ku8sNemRXoUR85E6OfrPAYkJuv9Oc?= =?us-ascii?Q?LAHHU9MlFVToyIn/oKjdVQ50gdYCZfWqwin/6/zFpz1dfft+4g=3D=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(1800799024)(376014)(36860700013)(82310400026); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Oct 2024 18:42:04.3990 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 075c013f-0bde-449b-e0f8-08dcf2c9396c X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9D2.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB7554 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org After refactoring the power library, power management operations are now consistently supported regardless of the operating environment, making function pointer checks unnecessary and thus removed from applications. v2: - removed function pointer validation in l3fwd-power app. Signed-off-by: Sivaprasad Tummala --- app/test/test_power.c | 95 ----------------------------------- app/test/test_power_cpufreq.c | 52 ------------------- app/test/test_power_kvm_vm.c | 36 ------------- examples/l3fwd-power/main.c | 12 ++--- 4 files changed, 4 insertions(+), 191 deletions(-) diff --git a/app/test/test_power.c b/app/test/test_power.c index 403adc22d6..5df5848c70 100644 --- a/app/test/test_power.c +++ b/app/test/test_power.c @@ -24,86 +24,6 @@ test_power(void) #include -static int -check_function_ptrs(void) -{ - enum power_management_env env = rte_power_get_env(); - - const bool not_null_expected = !(env == PM_ENV_NOT_SET); - - const char *inject_not_string1 = not_null_expected ? " not" : ""; - const char *inject_not_string2 = not_null_expected ? "" : " not"; - - if ((rte_power_freqs == NULL) == not_null_expected) { - printf("rte_power_freqs should%s be NULL, environment has%s been " - "initialised\n", inject_not_string1, - inject_not_string2); - return -1; - } - if ((rte_power_get_freq == NULL) == not_null_expected) { - printf("rte_power_get_freq should%s be NULL, environment has%s been " - "initialised\n", inject_not_string1, - inject_not_string2); - return -1; - } - if ((rte_power_set_freq == NULL) == not_null_expected) { - printf("rte_power_set_freq should%s be NULL, environment has%s been " - "initialised\n", inject_not_string1, - inject_not_string2); - return -1; - } - if ((rte_power_freq_up == NULL) == not_null_expected) { - printf("rte_power_freq_up should%s be NULL, environment has%s been " - "initialised\n", inject_not_string1, - inject_not_string2); - return -1; - } - if ((rte_power_freq_down == NULL) == not_null_expected) { - printf("rte_power_freq_down should%s be NULL, environment has%s been " - "initialised\n", inject_not_string1, - inject_not_string2); - return -1; - } - if ((rte_power_freq_max == NULL) == not_null_expected) { - printf("rte_power_freq_max should%s be NULL, environment has%s been " - "initialised\n", inject_not_string1, - inject_not_string2); - return -1; - } - if ((rte_power_freq_min == NULL) == not_null_expected) { - printf("rte_power_freq_min should%s be NULL, environment has%s been " - "initialised\n", inject_not_string1, - inject_not_string2); - return -1; - } - if ((rte_power_turbo_status == NULL) == not_null_expected) { - printf("rte_power_turbo_status should%s be NULL, environment has%s been " - "initialised\n", inject_not_string1, - inject_not_string2); - return -1; - } - if ((rte_power_freq_enable_turbo == NULL) == not_null_expected) { - printf("rte_power_freq_enable_turbo should%s be NULL, environment has%s been " - "initialised\n", inject_not_string1, - inject_not_string2); - return -1; - } - if ((rte_power_freq_disable_turbo == NULL) == not_null_expected) { - printf("rte_power_freq_disable_turbo should%s be NULL, environment has%s been " - "initialised\n", inject_not_string1, - inject_not_string2); - return -1; - } - if ((rte_power_get_capabilities == NULL) == not_null_expected) { - printf("rte_power_get_capabilities should%s be NULL, environment has%s been " - "initialised\n", inject_not_string1, - inject_not_string2); - return -1; - } - - return 0; -} - static int test_power(void) { @@ -124,10 +44,6 @@ test_power(void) return -1; } - /* Verify that function pointers are NULL */ - if (check_function_ptrs() < 0) - goto fail_all; - rte_power_unset_env(); /* Perform tests for valid environments.*/ @@ -154,22 +70,11 @@ test_power(void) return -1; } - /* Verify that function pointers are NOT NULL */ - if (check_function_ptrs() < 0) - goto fail_all; - rte_power_unset_env(); - /* Verify that function pointers are NULL */ - if (check_function_ptrs() < 0) - goto fail_all; - } return 0; -fail_all: - rte_power_unset_env(); - return -1; } #endif diff --git a/app/test/test_power_cpufreq.c b/app/test/test_power_cpufreq.c index edbd34424e..f4522747d5 100644 --- a/app/test/test_power_cpufreq.c +++ b/app/test/test_power_cpufreq.c @@ -534,58 +534,6 @@ test_power_cpufreq(void) goto fail_all; } - /* verify that function pointers are not NULL */ - if (rte_power_freqs == NULL) { - printf("rte_power_freqs should not be NULL, environment has not been " - "initialised\n"); - goto fail_all; - } - if (rte_power_get_freq == NULL) { - printf("rte_power_get_freq should not be NULL, environment has not " - "been initialised\n"); - goto fail_all; - } - if (rte_power_set_freq == NULL) { - printf("rte_power_set_freq should not be NULL, environment has not " - "been initialised\n"); - goto fail_all; - } - if (rte_power_freq_up == NULL) { - printf("rte_power_freq_up should not be NULL, environment has not " - "been initialised\n"); - goto fail_all; - } - if (rte_power_freq_down == NULL) { - printf("rte_power_freq_down should not be NULL, environment has not " - "been initialised\n"); - goto fail_all; - } - if (rte_power_freq_max == NULL) { - printf("rte_power_freq_max should not be NULL, environment has not " - "been initialised\n"); - goto fail_all; - } - if (rte_power_freq_min == NULL) { - printf("rte_power_freq_min should not be NULL, environment has not " - "been initialised\n"); - goto fail_all; - } - if (rte_power_turbo_status == NULL) { - printf("rte_power_turbo_status should not be NULL, environment has not " - "been initialised\n"); - goto fail_all; - } - if (rte_power_freq_enable_turbo == NULL) { - printf("rte_power_freq_enable_turbo should not be NULL, environment has not " - "been initialised\n"); - goto fail_all; - } - if (rte_power_freq_disable_turbo == NULL) { - printf("rte_power_freq_disable_turbo should not be NULL, environment has not " - "been initialised\n"); - goto fail_all; - } - ret = rte_power_exit(TEST_POWER_LCORE_ID); if (ret < 0) { printf("Cannot exit power management for lcore %u\n", diff --git a/app/test/test_power_kvm_vm.c b/app/test/test_power_kvm_vm.c index 464e06002e..a7d104e973 100644 --- a/app/test/test_power_kvm_vm.c +++ b/app/test/test_power_kvm_vm.c @@ -47,42 +47,6 @@ test_power_kvm_vm(void) return -1; } - /* verify that function pointers are not NULL */ - if (rte_power_freqs == NULL) { - printf("rte_power_freqs should not be NULL, environment has not been " - "initialised\n"); - return -1; - } - if (rte_power_get_freq == NULL) { - printf("rte_power_get_freq should not be NULL, environment has not " - "been initialised\n"); - return -1; - } - if (rte_power_set_freq == NULL) { - printf("rte_power_set_freq should not be NULL, environment has not " - "been initialised\n"); - return -1; - } - if (rte_power_freq_up == NULL) { - printf("rte_power_freq_up should not be NULL, environment has not " - "been initialised\n"); - return -1; - } - if (rte_power_freq_down == NULL) { - printf("rte_power_freq_down should not be NULL, environment has not " - "been initialised\n"); - return -1; - } - if (rte_power_freq_max == NULL) { - printf("rte_power_freq_max should not be NULL, environment has not " - "been initialised\n"); - return -1; - } - if (rte_power_freq_min == NULL) { - printf("rte_power_freq_min should not be NULL, environment has not " - "been initialised\n"); - return -1; - } /* Test initialisation of an out of bounds lcore */ ret = rte_power_init(TEST_POWER_VM_LCORE_OUT_OF_BOUNDS); if (ret != -1) { diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c index 2bb6b092c3..6bd76515e6 100644 --- a/examples/l3fwd-power/main.c +++ b/examples/l3fwd-power/main.c @@ -440,8 +440,7 @@ power_timer_cb(__rte_unused struct rte_timer *tim, * check whether need to scale down frequency a step if it sleep a lot. */ if (sleep_time_ratio >= SCALING_DOWN_TIME_RATIO_THRESHOLD) { - if (rte_power_freq_down) - rte_power_freq_down(lcore_id); + rte_power_freq_down(lcore_id); } else if ( (unsigned)(stats[lcore_id].nb_rx_processed / stats[lcore_id].nb_iteration_looped) < MAX_PKT_BURST) { @@ -449,8 +448,7 @@ power_timer_cb(__rte_unused struct rte_timer *tim, * scale down a step if average packet per iteration less * than expectation. */ - if (rte_power_freq_down) - rte_power_freq_down(lcore_id); + rte_power_freq_down(lcore_id); } /** @@ -1344,11 +1342,9 @@ main_legacy_loop(__rte_unused void *dummy) } if (lcore_scaleup_hint == FREQ_HIGHEST) { - if (rte_power_freq_max) - rte_power_freq_max(lcore_id); + rte_power_freq_max(lcore_id); } else if (lcore_scaleup_hint == FREQ_HIGHER) { - if (rte_power_freq_up) - rte_power_freq_up(lcore_id); + rte_power_freq_up(lcore_id); } } else { /** -- 2.34.1