From: Stephen Hemminger <stephen@networkplumber.org>
To: Howard Wang <howard_wang@realsil.com.cn>
Cc: <dev@dpdk.org>, <pro_nic_dpdk@realtek.com>
Subject: Re: [PATCH v3 01/18] net/r8169: add PMD driver skeleton
Date: Tue, 22 Oct 2024 22:17:33 -0700 [thread overview]
Message-ID: <20241022221733.464ef6a4@hermes.local> (raw)
In-Reply-To: <20241023033328.191827-2-howard_wang@realsil.com.cn>
On Wed, 23 Oct 2024 11:33:11 +0800
Howard Wang <howard_wang@realsil.com.cn> wrote:
> Meson build infrastructure, r8169_ethdev minimal skeleton,
> header with Realtek NIC device and vendor IDs.
>
> Signed-off-by: Howard Wang <howard_wang@realsil.com.cn>
This version is much better than the last.
Still has some issues:
- git whitespace
- braces
- one spelling error
For example, doing git apply showed.
Applying: net/r8169: add support for hardware operations
/home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:2381: trailing whitespace.
(BIT_15 | BIT_14 | BIT_13 | BIT_12 |
/home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:460: new blank line at EOF.
+
/home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:2052: new blank line at EOF.
+
/home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:2073: new blank line at EOF.
+
/home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:2470: new blank line at EOF.
+
warning: squelched 13 whitespace errors
warning: 18 lines add whitespace errors.
Some minor checkpatch warnings.
CHECK:BRACES: braces {} should be used on all arms of this statement
#268: FILE: drivers/net/r8169/r8169_hw.c:67:
+ if (len <= 4 - val_shift)
[...]
+ else {
[...]
CHECK:BRACES: Unbalanced braces around else statement
#270: FILE: drivers/net/r8169/r8169_hw.c:69:
+ else {
CHECK:BRACES: braces {} should be used on all arms of this statement
#334: FILE: drivers/net/r8169/r8169_hw.c:133:
+ if (len <= 4 - val_shift)
[...]
+ else {
[...]
CHECK:BRACES: Unbalanced braces around else statement
#336: FILE: drivers/net/r8169/r8169_hw.c:135:
+ else {
CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#433: FILE: drivers/net/r8169/r8169_hw.c:232:
+
+ }
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#978: FILE: drivers/net/r8169/r8169_phy.c:2:
+ * Copyright(c) 2024 Realtek Corporation. All rights reserved */
CHECK:BRACES: braces {} should be used on all arms of this statement
#273: FILE: drivers/net/r8169/r8169_phy.c:536:
+ if (hw->hw_ram_code_ver == hw->sw_ram_code_ver) {
[...]
+ } else
[...]
### [PATCH] net/r8169: impelment MTU configuration
WARNING:TYPO_SPELLING: 'impelment' may be misspelled - perhaps 'implement'?
#4:
Subject: [PATCH] net/r8169: impelment MTU configuration
^^^^^^^^^
Suprised that you have to keep track of packets in SW.
The kernel driver is able to get them from the HW.
The kernel driver gets lots more counters from the HW which could go to xstats.
next prev parent reply other threads:[~2024-10-23 5:32 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-23 3:33 [PATCH v3 00/18] Modify some code as suggested by the maintainer Howard Wang
2024-10-23 3:33 ` [PATCH v3 01/18] net/r8169: add PMD driver skeleton Howard Wang
2024-10-23 5:17 ` Stephen Hemminger [this message]
2024-10-23 5:59 ` 答复: " 王颢
2024-10-23 6:16 ` Stephen Hemminger
2024-10-23 3:33 ` [PATCH v3 02/18] net/r8169: add logging structure Howard Wang
2024-10-23 3:33 ` [PATCH v3 03/18] net/r8169: add hardware registers access routines Howard Wang
2024-10-23 3:33 ` [PATCH v3 04/18] net/r8169: implement core logic for Tx/Rx Howard Wang
2024-10-23 3:33 ` [PATCH v3 05/18] net/r8169: add support for hw config Howard Wang
2024-10-23 3:33 ` [PATCH v3 06/18] net/r8169: add phy registers access routines Howard Wang
2024-10-23 3:33 ` [PATCH v3 07/18] net/r8169: add support for hardware operations Howard Wang
2024-10-23 3:33 ` [PATCH v3 08/18] net/r8169: add support for phy configuration Howard Wang
2024-10-23 3:33 ` [PATCH v3 09/18] net/r8169: add support for hw initialization Howard Wang
2024-10-23 3:33 ` [PATCH v3 10/18] net/r8169: add link status and interrupt management Howard Wang
2024-10-23 3:33 ` [PATCH v3 11/18] net/r8169: implement Rx path Howard Wang
2024-10-23 3:33 ` [PATCH v3 12/18] net/r8169: implement Tx path Howard Wang
2024-10-23 5:22 ` Stephen Hemminger
2024-10-23 3:33 ` [PATCH v3 13/18] net/r8169: implement device statistics Howard Wang
2024-10-23 3:33 ` [PATCH v3 14/18] net/r8169: implement promisc and allmulti modes Howard Wang
2024-10-23 3:33 ` [PATCH v3 15/18] net/r8169: impelment MTU configuration Howard Wang
2024-10-23 3:33 ` [PATCH v3 16/18] net/r8169: add support for getting fw version Howard Wang
2024-10-23 3:33 ` [PATCH v3 17/18] net/r8169: add driver_start and driver_stop Howard Wang
2024-10-23 3:33 ` [PATCH v3 18/18] doc/guides/nics: add documents for r8169 pmd Howard Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241022221733.464ef6a4@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=howard_wang@realsil.com.cn \
--cc=pro_nic_dpdk@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).