From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 635FF45BAA; Wed, 23 Oct 2024 07:32:34 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E335C402E1; Wed, 23 Oct 2024 07:32:33 +0200 (CEST) Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) by mails.dpdk.org (Postfix) with ESMTP id AD73F40263 for ; Wed, 23 Oct 2024 07:32:32 +0200 (CEST) Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-71e49ad46b1so4401453b3a.1 for ; Tue, 22 Oct 2024 22:32:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729661551; x=1730266351; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=kk/FGWoH/+k5h7ZGcNeAWn4QULjVHb/fAuUAu6ow+QY=; b=3O8/oAb9yf+0mYsK+bUsOYdDQfHIqgn8bBkJRi9DvkNyr6X5kBEIR9WUz24dvLyrig 1LVP4dbg6G93DKmlGHxwCNnR1jr/zSXFQcya1ho3SaXZ415M4Fllj4ZmicAnGYqKxqFN 2CNHi+H0L/DK3/GC+u+k6yEmcQT5LUIBApEuTNxy1269wvHCgdHgnZe/UubRRS3+TeqI 8che0LwccRHPLP74uFZf+7D5nzKuoPhgjeD+YWODZ9YfL/SI5/84GDrUfTDwTEYC638S EbVf3AuHZ4quwefEQYLSbK0JoBE2sc+CIMgpa2hNB915PWkfw3Mf1ZEW/Txdw6gkoncj iwTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729661551; x=1730266351; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kk/FGWoH/+k5h7ZGcNeAWn4QULjVHb/fAuUAu6ow+QY=; b=QNvDdcb5ttfrXj0bZIMidFrvSlxXecKEklPKdc55RCqusguxoqoq59XFjvhoeCqnij 81qloyWiRYtawANsgZ9280fDj0tuOeBE8WZpR4IFWapthY5vAIjoj4dSWqgWHlamjX+B ijXnUJf6oT9os4M79Qa1YeG9Bd5fr1J7oAliRjoEtr23ndH+P95innHxr7fQvrEZcJgG Xk3kWpv8JCOQ7Cog7kF32RWRwNJZidh6q0SFc8yR3au8M15b8c8em8H1yI2UFy7ZsDUU BwMXGv/nU4kbWTn7i1LWdD9EDFyUhnpZflxuDgNdHgJJcJQRLXmYWLh4RVe0U4G8BBrd 8b2A== X-Gm-Message-State: AOJu0YwjbhavVF4uvaCZR8etrPKNOEkS+VMQa7tz7dNguVGMeFUTkhKS N1Ux0exs1NYfa+9KsgdmUYHhhGF1MPGocUyNLxYd9FHGKAmXNG3amW90HzTcn9A= X-Google-Smtp-Source: AGHT+IE4xd+wTA72MGR0x+dUNOMK2aDCa3qEvOAQvWqVHuXOXx66FIt5BsyFo6mmb20j8fKs90bPzg== X-Received: by 2002:a05:6a00:10c1:b0:71e:7887:81ac with SMTP id d2e1a72fcca58-72030ab56cfmr2364821b3a.16.1729661551444; Tue, 22 Oct 2024 22:32:31 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71ec13ea219sm5590024b3a.162.2024.10.22.22.32.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Oct 2024 22:32:31 -0700 (PDT) Date: Tue, 22 Oct 2024 22:17:33 -0700 From: Stephen Hemminger To: Howard Wang Cc: , Subject: Re: [PATCH v3 01/18] net/r8169: add PMD driver skeleton Message-ID: <20241022221733.464ef6a4@hermes.local> In-Reply-To: <20241023033328.191827-2-howard_wang@realsil.com.cn> References: <20241023033328.191827-1-howard_wang@realsil.com.cn> <20241023033328.191827-2-howard_wang@realsil.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 23 Oct 2024 11:33:11 +0800 Howard Wang wrote: > Meson build infrastructure, r8169_ethdev minimal skeleton, > header with Realtek NIC device and vendor IDs. > > Signed-off-by: Howard Wang This version is much better than the last. Still has some issues: - git whitespace - braces - one spelling error For example, doing git apply showed. Applying: net/r8169: add support for hardware operations /home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:2381: trailing whitespace. (BIT_15 | BIT_14 | BIT_13 | BIT_12 | /home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:460: new blank line at EOF. + /home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:2052: new blank line at EOF. + /home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:2073: new blank line at EOF. + /home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:2470: new blank line at EOF. + warning: squelched 13 whitespace errors warning: 18 lines add whitespace errors. Some minor checkpatch warnings. CHECK:BRACES: braces {} should be used on all arms of this statement #268: FILE: drivers/net/r8169/r8169_hw.c:67: + if (len <= 4 - val_shift) [...] + else { [...] CHECK:BRACES: Unbalanced braces around else statement #270: FILE: drivers/net/r8169/r8169_hw.c:69: + else { CHECK:BRACES: braces {} should be used on all arms of this statement #334: FILE: drivers/net/r8169/r8169_hw.c:133: + if (len <= 4 - val_shift) [...] + else { [...] CHECK:BRACES: Unbalanced braces around else statement #336: FILE: drivers/net/r8169/r8169_hw.c:135: + else { CHECK:BRACES: Blank lines aren't necessary before a close brace '}' #433: FILE: drivers/net/r8169/r8169_hw.c:232: + + } WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #978: FILE: drivers/net/r8169/r8169_phy.c:2: + * Copyright(c) 2024 Realtek Corporation. All rights reserved */ CHECK:BRACES: braces {} should be used on all arms of this statement #273: FILE: drivers/net/r8169/r8169_phy.c:536: + if (hw->hw_ram_code_ver == hw->sw_ram_code_ver) { [...] + } else [...] ### [PATCH] net/r8169: impelment MTU configuration WARNING:TYPO_SPELLING: 'impelment' may be misspelled - perhaps 'implement'? #4: Subject: [PATCH] net/r8169: impelment MTU configuration ^^^^^^^^^ Suprised that you have to keep track of packets in SW. The kernel driver is able to get them from the HW. The kernel driver gets lots more counters from the HW which could go to xstats.