DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: 王颢 <howard_wang@realsil.com.cn>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"pro_nic_dpdk@realtek.com" <pro_nic_dpdk@realtek.com>
Subject: Re: [PATCH v3 01/18] net/r8169: add PMD driver skeleton
Date: Tue, 22 Oct 2024 23:16:32 -0700	[thread overview]
Message-ID: <20241022231632.13a6386d@hermes.local> (raw)
In-Reply-To: <ee9694e087da4c90b39cd447c48634f4@realsil.com.cn>

On Wed, 23 Oct 2024 05:59:12 +0000
王颢 <howard_wang@realsil.com.cn> wrote:

> Dear Stephen,
> 
> OK, I will fix these issues.
> I would like to confirm that each document needs to have a blank line at the end, correct? 
> Apologies, but we plan to maintain our current approach regarding stats this time.
> 
> Best Regards,
> Howard Wang


Git documents this in 'git apply' man page. In this patchset, the errors appear
to be simple blank lines at the end.

       --whitespace=<action>
           When applying a patch, detect a new or modified line that has
           whitespace errors. What are considered whitespace errors is
           controlled by core.whitespace configuration. By default, trailing
           whitespaces (including lines that solely consist of whitespaces) and
           a space character that is immediately followed by a tab character
           inside the initial indent of the line are considered whitespace
           errors.

           By default, the command outputs warning messages but applies the
           patch. When git-apply is used for statistics and not applying a
           patch, it defaults to nowarn.

           You can use different <action> values to control this behavior:

           •   nowarn turns off the trailing whitespace warning.

           •   warn outputs warnings for a few such errors, but applies the
               patch as-is (default).

           •   fix outputs warnings for a few such errors, and applies the
               patch after fixing them (strip is a synonym — the tool used to
               consider only trailing whitespace characters as errors, and the
               fix involved stripping them, but modern Gits do more).

           •   error outputs warnings for a few such errors, and refuses to
               apply the patch.

           •   error-all is similar to error but shows all errors.

  reply	other threads:[~2024-10-23  6:16 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-23  3:33 [PATCH v3 00/18] Modify some code as suggested by the maintainer Howard Wang
2024-10-23  3:33 ` [PATCH v3 01/18] net/r8169: add PMD driver skeleton Howard Wang
2024-10-23  5:17   ` Stephen Hemminger
2024-10-23  5:59     ` 答复: " 王颢
2024-10-23  6:16       ` Stephen Hemminger [this message]
2024-10-23  3:33 ` [PATCH v3 02/18] net/r8169: add logging structure Howard Wang
2024-10-23  3:33 ` [PATCH v3 03/18] net/r8169: add hardware registers access routines Howard Wang
2024-10-23  3:33 ` [PATCH v3 04/18] net/r8169: implement core logic for Tx/Rx Howard Wang
2024-10-23  3:33 ` [PATCH v3 05/18] net/r8169: add support for hw config Howard Wang
2024-10-23  3:33 ` [PATCH v3 06/18] net/r8169: add phy registers access routines Howard Wang
2024-10-23  3:33 ` [PATCH v3 07/18] net/r8169: add support for hardware operations Howard Wang
2024-10-23  3:33 ` [PATCH v3 08/18] net/r8169: add support for phy configuration Howard Wang
2024-10-23  3:33 ` [PATCH v3 09/18] net/r8169: add support for hw initialization Howard Wang
2024-10-23  3:33 ` [PATCH v3 10/18] net/r8169: add link status and interrupt management Howard Wang
2024-10-23  3:33 ` [PATCH v3 11/18] net/r8169: implement Rx path Howard Wang
2024-10-23  3:33 ` [PATCH v3 12/18] net/r8169: implement Tx path Howard Wang
2024-10-23  5:22   ` Stephen Hemminger
2024-10-23  3:33 ` [PATCH v3 13/18] net/r8169: implement device statistics Howard Wang
2024-10-23  3:33 ` [PATCH v3 14/18] net/r8169: implement promisc and allmulti modes Howard Wang
2024-10-23  3:33 ` [PATCH v3 15/18] net/r8169: impelment MTU configuration Howard Wang
2024-10-23  3:33 ` [PATCH v3 16/18] net/r8169: add support for getting fw version Howard Wang
2024-10-23  3:33 ` [PATCH v3 17/18] net/r8169: add driver_start and driver_stop Howard Wang
2024-10-23  3:33 ` [PATCH v3 18/18] doc/guides/nics: add documents for r8169 pmd Howard Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241022231632.13a6386d@hermes.local \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=howard_wang@realsil.com.cn \
    --cc=pro_nic_dpdk@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).