From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9677D45BAA; Wed, 23 Oct 2024 07:12:44 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3972340B99; Wed, 23 Oct 2024 07:12:31 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2044.outbound.protection.outlook.com [40.107.244.44]) by mails.dpdk.org (Postfix) with ESMTP id AB1C040A6E for ; Wed, 23 Oct 2024 07:12:22 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=WQuM3pElfrLP5kJgnkqZkUjOpeRLKxmzi8VXkvxSSf7oF7w7J9Od/b2TkYsTF9TtWIXQFOvHv07hatk3Uo45ldVaMzJwCLVDwOmrwoR1GieW9eG3Cii8pYWXf6O43PLLKfrZP4LRaayCE82r5pTlx2eLBvuADFuy517LzZsC08bxLzAS2FBGRid8gzlRe+G4cf6n+71jErFga5kWMOU3pEsQpGm03YeyB8SUTpOa6W1Nb1uiLE4xZrQFjdt53lzY60sGCPfKQcYTUsPrLcrvLB/yHEhSEhtAFEAuHJSACLA8mTmqB2QIJlYBOj7Y3bemFpSlb/IFHquuht1TBeWmhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=A7Uf3Jw2cJ3E7iCkMoYaS7w0bT4qgeYpA3+tXTFvpgs=; b=oTe8NbU3O9zccSOVsgx4Q/D4fyqkE0nCTt5/NwnQzI/bREbw5gpgONPZwH7/JAUUbh6YsO/T/KKu8flpk0GaZmRa4ZYsKQIL5iDQhBoL7o6kDRHitS4X5xpyxjr1p7CgT52f9jv0VRGG/tEsBTHZuLwS5vHtph19UwFnkYpfe2JYF+FVlEPmXXT8kzlJkJz7HwALmaIGuithlfvvFNBeXFgbqdWddJm48jzM4NZ0KJztpsN1FAUgudsf7rRBWzez784jkvnV+flVU/jOUydhgxujGnBB0jPbpJMpwkvaZ6zVopFs5CSowGIyi5GmBlmrUnvI3RCPqOEEgWw+InOvww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A7Uf3Jw2cJ3E7iCkMoYaS7w0bT4qgeYpA3+tXTFvpgs=; b=MC1ZlBIVlBmQYPWtq59Gvcqp5pNq9PaD80tvsX6Z1reX7blJZx/dj3tk7na74FcxORdf5MRWVfVw0jPai31q7OJI6q/PLV53UL2DBJ/esPTocPCYmgMqm5NY7MreKVfDt/md4+pTf47mdC1AzDPQ+zXo/z3XJdxlfP6nUwkUrLU= Received: from BL1PR13CA0247.namprd13.prod.outlook.com (2603:10b6:208:2ba::12) by PH8PR12MB6915.namprd12.prod.outlook.com (2603:10b6:510:1bc::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8069.28; Wed, 23 Oct 2024 05:12:17 +0000 Received: from BL6PEPF00020E64.namprd04.prod.outlook.com (2603:10b6:208:2ba:cafe::38) by BL1PR13CA0247.outlook.office365.com (2603:10b6:208:2ba::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8114.5 via Frontend Transport; Wed, 23 Oct 2024 05:12:11 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BL6PEPF00020E64.mail.protection.outlook.com (10.167.249.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8093.14 via Frontend Transport; Wed, 23 Oct 2024 05:12:11 +0000 Received: from jfw9ny3-os.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 23 Oct 2024 00:12:05 -0500 From: Sivaprasad Tummala To: , , , , , , , , CC: Subject: [PATCH v9 3/6] test/power: removed function pointer validations Date: Wed, 23 Oct 2024 05:11:35 +0000 Message-ID: <20241023051139.1066426-4-sivaprasad.tummala@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241023051139.1066426-1-sivaprasad.tummala@amd.com> References: <20241022184133.700367-1-sivaprasad.tummala@amd.com> <20241023051139.1066426-1-sivaprasad.tummala@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF00020E64:EE_|PH8PR12MB6915:EE_ X-MS-Office365-Filtering-Correlation-Id: 22822529-db8a-4797-8236-08dcf3213ffb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700013|376014|82310400026|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?HhomPst3zRBBW7msFHNgtDMqVhu+rstyxKU5LJSbsQSsqWGshgOc2BfApo5O?= =?us-ascii?Q?5/R4NWXnpsssDI1z+Sjt66NI9o6+0xL23Kf3d9k/2jeLvx7ZzwyNrFBOThg8?= =?us-ascii?Q?gQuo7ZVfxPyFaXkLAN9vOO6QKb9DUK1UzBA82Cnsm7pWYXZDxKtyRbLZeKvn?= =?us-ascii?Q?Nigmt9ftnKVmKYZul8inDn1a+PSHeB8rH/7YlKtyByzS8vUqild2WFTBLXww?= =?us-ascii?Q?ZZVhiEl60VWyWtFJDpTYQpenW6guihgTv1EKmWbwCJr2NKvOTbyYFcYn0cGn?= =?us-ascii?Q?nAsuUapGzOLDtr9eH2TfjrPOnAfQWAsQR/Igsr6T8uQYK/BwJjjZTPgF0c1F?= =?us-ascii?Q?Z/UiVRc80t86GlCMNcO1i0MFXFrf9BPYLXQFSG5B7qAavgG62L+FUoEGSqs5?= =?us-ascii?Q?5V0KwPmzuJSb9UZxET/aryCj2cCi5RNodCw8epmk57bTd7JjI9XJHfWXzW7A?= =?us-ascii?Q?FRcWMkqUpeGvaKiWxVCQMnPnojVLVc+Gdv0/tqtha94yqNv+f7ArXYyNsoiw?= =?us-ascii?Q?s6JAs4YeyCM3qAT2MBAZWd2t5+c+UjLGHS3fLnY9N8DDKL2Y2JzZA8WnQeeK?= =?us-ascii?Q?tqweePxsP1gnQJMzSXfXOGYSNrdhhzQ53FmlMCwLJyYGouxKvyHH9sGPUzeV?= =?us-ascii?Q?2nWdw9OK/MQN65g2Ms05Y2Wzh2VhOlm0tBEIMQCgHwN1VsDB/78Yp2V2rFt6?= =?us-ascii?Q?eZMZF4LNIRZ4RvOTkO5pCZgc/c8EnfO5W+Azk9JRt4i7Zvg77AbUd57dHLs4?= =?us-ascii?Q?EIUR89j/zQ7SAnxw4hUuO/WfBUZavz0B2eSFftBURYIWEBgtaspWesJb54n9?= =?us-ascii?Q?MJdu4pKhWQUh6r7Q1yBvZ23aeRa8y3Hyy4LEby7IpcRIZhpYsFUdjYzDagF7?= =?us-ascii?Q?yl91gPhnmZd5lsib8Y4ED5F42y8ZtddrexjrBY0gTcT6Y6Th6DJI340SLwPn?= =?us-ascii?Q?s8oK2WONgG4IJU1f/1BaG7s7M/7UPhlSQA7hmWAuhihl+qJO+/N4a0oNHJWW?= =?us-ascii?Q?apXjgXlppGSfg4S9PKeVI4zERGDHEec4GMIWm+XAPA+jKMVn52o3iDg43YXg?= =?us-ascii?Q?E+f0v/z5mCg/QiHf02i9Jm5HewmjQmVWySGXDwXYwsaTB54Yzi/IuoZBEAzO?= =?us-ascii?Q?uDJDxDy8ZUsmEz3nIAQSggNq8QzxRE0PLNfDdfNCp+hkw9Dd2x0GxOwZf3+R?= =?us-ascii?Q?OREADtnVrvNt15Z/yBeCTroYLyDyosLuLm3s+SElENJWs+iDKjQhciDBatbt?= =?us-ascii?Q?yvctOIaQwwqxjI+BQ2nTBz+wpRjPGujYshFpbiAwNXP8GAh7bmFbxJjR0vTJ?= =?us-ascii?Q?z5p+sWjqs6XpC3+ysU/1A70JTOxQJ53lKPjQ77bFSu4JOgtahF2YbbWjM0xl?= =?us-ascii?Q?zoZxF6ri0G8Tmeie51k3hU2/e++uTAPAUxr2ftBtORPA2n5XCw=3D=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(36860700013)(376014)(82310400026)(1800799024); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2024 05:12:11.1904 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 22822529-db8a-4797-8236-08dcf3213ffb X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF00020E64.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6915 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org After refactoring the power library, power management operations are now consistently supported regardless of the operating environment, making function pointer checks unnecessary and thus removed from applications. v2: - removed function pointer validation in l3fwd-power app. Signed-off-by: Sivaprasad Tummala --- app/test/test_power.c | 95 ----------------------------------- app/test/test_power_cpufreq.c | 52 ------------------- app/test/test_power_kvm_vm.c | 36 ------------- examples/l3fwd-power/main.c | 12 ++--- 4 files changed, 4 insertions(+), 191 deletions(-) diff --git a/app/test/test_power.c b/app/test/test_power.c index 403adc22d6..5df5848c70 100644 --- a/app/test/test_power.c +++ b/app/test/test_power.c @@ -24,86 +24,6 @@ test_power(void) #include -static int -check_function_ptrs(void) -{ - enum power_management_env env = rte_power_get_env(); - - const bool not_null_expected = !(env == PM_ENV_NOT_SET); - - const char *inject_not_string1 = not_null_expected ? " not" : ""; - const char *inject_not_string2 = not_null_expected ? "" : " not"; - - if ((rte_power_freqs == NULL) == not_null_expected) { - printf("rte_power_freqs should%s be NULL, environment has%s been " - "initialised\n", inject_not_string1, - inject_not_string2); - return -1; - } - if ((rte_power_get_freq == NULL) == not_null_expected) { - printf("rte_power_get_freq should%s be NULL, environment has%s been " - "initialised\n", inject_not_string1, - inject_not_string2); - return -1; - } - if ((rte_power_set_freq == NULL) == not_null_expected) { - printf("rte_power_set_freq should%s be NULL, environment has%s been " - "initialised\n", inject_not_string1, - inject_not_string2); - return -1; - } - if ((rte_power_freq_up == NULL) == not_null_expected) { - printf("rte_power_freq_up should%s be NULL, environment has%s been " - "initialised\n", inject_not_string1, - inject_not_string2); - return -1; - } - if ((rte_power_freq_down == NULL) == not_null_expected) { - printf("rte_power_freq_down should%s be NULL, environment has%s been " - "initialised\n", inject_not_string1, - inject_not_string2); - return -1; - } - if ((rte_power_freq_max == NULL) == not_null_expected) { - printf("rte_power_freq_max should%s be NULL, environment has%s been " - "initialised\n", inject_not_string1, - inject_not_string2); - return -1; - } - if ((rte_power_freq_min == NULL) == not_null_expected) { - printf("rte_power_freq_min should%s be NULL, environment has%s been " - "initialised\n", inject_not_string1, - inject_not_string2); - return -1; - } - if ((rte_power_turbo_status == NULL) == not_null_expected) { - printf("rte_power_turbo_status should%s be NULL, environment has%s been " - "initialised\n", inject_not_string1, - inject_not_string2); - return -1; - } - if ((rte_power_freq_enable_turbo == NULL) == not_null_expected) { - printf("rte_power_freq_enable_turbo should%s be NULL, environment has%s been " - "initialised\n", inject_not_string1, - inject_not_string2); - return -1; - } - if ((rte_power_freq_disable_turbo == NULL) == not_null_expected) { - printf("rte_power_freq_disable_turbo should%s be NULL, environment has%s been " - "initialised\n", inject_not_string1, - inject_not_string2); - return -1; - } - if ((rte_power_get_capabilities == NULL) == not_null_expected) { - printf("rte_power_get_capabilities should%s be NULL, environment has%s been " - "initialised\n", inject_not_string1, - inject_not_string2); - return -1; - } - - return 0; -} - static int test_power(void) { @@ -124,10 +44,6 @@ test_power(void) return -1; } - /* Verify that function pointers are NULL */ - if (check_function_ptrs() < 0) - goto fail_all; - rte_power_unset_env(); /* Perform tests for valid environments.*/ @@ -154,22 +70,11 @@ test_power(void) return -1; } - /* Verify that function pointers are NOT NULL */ - if (check_function_ptrs() < 0) - goto fail_all; - rte_power_unset_env(); - /* Verify that function pointers are NULL */ - if (check_function_ptrs() < 0) - goto fail_all; - } return 0; -fail_all: - rte_power_unset_env(); - return -1; } #endif diff --git a/app/test/test_power_cpufreq.c b/app/test/test_power_cpufreq.c index edbd34424e..f4522747d5 100644 --- a/app/test/test_power_cpufreq.c +++ b/app/test/test_power_cpufreq.c @@ -534,58 +534,6 @@ test_power_cpufreq(void) goto fail_all; } - /* verify that function pointers are not NULL */ - if (rte_power_freqs == NULL) { - printf("rte_power_freqs should not be NULL, environment has not been " - "initialised\n"); - goto fail_all; - } - if (rte_power_get_freq == NULL) { - printf("rte_power_get_freq should not be NULL, environment has not " - "been initialised\n"); - goto fail_all; - } - if (rte_power_set_freq == NULL) { - printf("rte_power_set_freq should not be NULL, environment has not " - "been initialised\n"); - goto fail_all; - } - if (rte_power_freq_up == NULL) { - printf("rte_power_freq_up should not be NULL, environment has not " - "been initialised\n"); - goto fail_all; - } - if (rte_power_freq_down == NULL) { - printf("rte_power_freq_down should not be NULL, environment has not " - "been initialised\n"); - goto fail_all; - } - if (rte_power_freq_max == NULL) { - printf("rte_power_freq_max should not be NULL, environment has not " - "been initialised\n"); - goto fail_all; - } - if (rte_power_freq_min == NULL) { - printf("rte_power_freq_min should not be NULL, environment has not " - "been initialised\n"); - goto fail_all; - } - if (rte_power_turbo_status == NULL) { - printf("rte_power_turbo_status should not be NULL, environment has not " - "been initialised\n"); - goto fail_all; - } - if (rte_power_freq_enable_turbo == NULL) { - printf("rte_power_freq_enable_turbo should not be NULL, environment has not " - "been initialised\n"); - goto fail_all; - } - if (rte_power_freq_disable_turbo == NULL) { - printf("rte_power_freq_disable_turbo should not be NULL, environment has not " - "been initialised\n"); - goto fail_all; - } - ret = rte_power_exit(TEST_POWER_LCORE_ID); if (ret < 0) { printf("Cannot exit power management for lcore %u\n", diff --git a/app/test/test_power_kvm_vm.c b/app/test/test_power_kvm_vm.c index 464e06002e..a7d104e973 100644 --- a/app/test/test_power_kvm_vm.c +++ b/app/test/test_power_kvm_vm.c @@ -47,42 +47,6 @@ test_power_kvm_vm(void) return -1; } - /* verify that function pointers are not NULL */ - if (rte_power_freqs == NULL) { - printf("rte_power_freqs should not be NULL, environment has not been " - "initialised\n"); - return -1; - } - if (rte_power_get_freq == NULL) { - printf("rte_power_get_freq should not be NULL, environment has not " - "been initialised\n"); - return -1; - } - if (rte_power_set_freq == NULL) { - printf("rte_power_set_freq should not be NULL, environment has not " - "been initialised\n"); - return -1; - } - if (rte_power_freq_up == NULL) { - printf("rte_power_freq_up should not be NULL, environment has not " - "been initialised\n"); - return -1; - } - if (rte_power_freq_down == NULL) { - printf("rte_power_freq_down should not be NULL, environment has not " - "been initialised\n"); - return -1; - } - if (rte_power_freq_max == NULL) { - printf("rte_power_freq_max should not be NULL, environment has not " - "been initialised\n"); - return -1; - } - if (rte_power_freq_min == NULL) { - printf("rte_power_freq_min should not be NULL, environment has not " - "been initialised\n"); - return -1; - } /* Test initialisation of an out of bounds lcore */ ret = rte_power_init(TEST_POWER_VM_LCORE_OUT_OF_BOUNDS); if (ret != -1) { diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c index 2bb6b092c3..6bd76515e6 100644 --- a/examples/l3fwd-power/main.c +++ b/examples/l3fwd-power/main.c @@ -440,8 +440,7 @@ power_timer_cb(__rte_unused struct rte_timer *tim, * check whether need to scale down frequency a step if it sleep a lot. */ if (sleep_time_ratio >= SCALING_DOWN_TIME_RATIO_THRESHOLD) { - if (rte_power_freq_down) - rte_power_freq_down(lcore_id); + rte_power_freq_down(lcore_id); } else if ( (unsigned)(stats[lcore_id].nb_rx_processed / stats[lcore_id].nb_iteration_looped) < MAX_PKT_BURST) { @@ -449,8 +448,7 @@ power_timer_cb(__rte_unused struct rte_timer *tim, * scale down a step if average packet per iteration less * than expectation. */ - if (rte_power_freq_down) - rte_power_freq_down(lcore_id); + rte_power_freq_down(lcore_id); } /** @@ -1344,11 +1342,9 @@ main_legacy_loop(__rte_unused void *dummy) } if (lcore_scaleup_hint == FREQ_HIGHEST) { - if (rte_power_freq_max) - rte_power_freq_max(lcore_id); + rte_power_freq_max(lcore_id); } else if (lcore_scaleup_hint == FREQ_HIGHER) { - if (rte_power_freq_up) - rte_power_freq_up(lcore_id); + rte_power_freq_up(lcore_id); } } else { /** -- 2.34.1