From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7B44F45BB9; Thu, 24 Oct 2024 04:19:19 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 015AB427A8; Thu, 24 Oct 2024 04:19:19 +0200 (CEST) Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by mails.dpdk.org (Postfix) with ESMTP id 37C2443348 for ; Thu, 24 Oct 2024 04:19:17 +0200 (CEST) Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-2e2c6bc4840so353707a91.2 for ; Wed, 23 Oct 2024 19:19:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729736356; x=1730341156; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=uiBY4C4dmsULnw9lBqNwfAzuSoyd+CaP+5SoQnyGJDY=; b=EaNp9uqnzHnu6B8o44QpjRO1489OqP+80GDXMxFlb2/J8nW/bSMtf7dy+og+b3Ml31 m2h0SDtFzsb1nVvl9k2DWUtGW6fFmiwVHTNKXz4MtxV4xTuPNChWieasLvJLVsqOsPK8 46olY/CJXI5REZ+kLcmDulyn+9J6iM/IJQ9mCTL5AcviS4lWmXtQRqVW/6iBCBC98dsR hGNMMFw05vH4h90t4iYorhRQR2ZfZA4Y6SMPnPhNZRxsfKhTTp4N5+pjqlhTC6PL0Kbm mjqjETz/ITA+Y/q/i6Bmcw15Oi2yqlTEME36zikD1+N3WVOfKh6kRx8C8iEiZNVo9E3k 7P3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729736356; x=1730341156; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uiBY4C4dmsULnw9lBqNwfAzuSoyd+CaP+5SoQnyGJDY=; b=r7cn8iVH7N+grIXbVEc7IchfQZI8GGLZsTCNkegr5OandcBjJJftJ+EUvcj9OSQEMx 9Cyx2Z0nCqdyNQ/y8BbMyt14pgXOVKAqbLU41Vuc7topAMwBIjb84TNTf7+Zh0qTrI5y cBVwBb/jCPzaiJp275kkKiTX/uoaNnBSkNe0aIn0LRN4Yx8DfRCNkmTb8JEwaoornY42 yzRdiYNDZYXbU7TNN748kRZ4w3OPjBSBmUiBCIAt2FTdFCzVqTLwMPq/3q7Br0nOBDl7 dvfVNQ1sfhLPyJzmsriT5VsY5ZltI/6ihQI+UF60ov9ExXDdbs9/e9AA2gLcclxVrVp7 vrLw== X-Gm-Message-State: AOJu0Yy/r+lm+3brMbfO+h2AOgppy5hFhRZTnOcEgpzipCCVd+EEIbpg bxM0d1iL7C+mHULcnAGqsZWMtTF3r+wOJQHoFzWULVyOMxixoHCDSYLKoju0P9M= X-Google-Smtp-Source: AGHT+IGH3U2mnnJGa/fXshyQe/sxDAch+sjOEeAygFydqG4XzriSbWI9gaPsl0/FHo785G8Py8ffbQ== X-Received: by 2002:a17:90a:70c3:b0:2e0:a77e:8305 with SMTP id 98e67ed59e1d1-2e76b716557mr4931899a91.39.1729736356287; Wed, 23 Oct 2024 19:19:16 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e77e48ed34sm260640a91.9.2024.10.23.19.19.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Oct 2024 19:19:16 -0700 (PDT) Date: Wed, 23 Oct 2024 19:19:13 -0700 From: Stephen Hemminger To: Dmitry Kozlyuk Cc: dev@dpdk.org, Anatoly Burakov , Lewis Donzis Subject: Re: [PATCH] eal: support including mapped memory in core dump Message-ID: <20241023191913.72963a16@hermes.local> In-Reply-To: <20241023231859.1323727-1-kozlyuk@bifit.com> References: <20241023231859.1323727-1-kozlyuk@bifit.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 24 Oct 2024 02:18:59 +0300 Dmitry Kozlyuk wrote: > From: Dmitry Kozlyuk > > Commit d72e4042c5eb ("mem: exclude unused memory from core dump") > unconditionally excluded all hugepage memory managed by DPDK. > The rationale was to avoid overly large core dumps > generated from reserved (PROT_NONE) but not mapped memory. > Mapped hugepages, however, may hold data useful for debugging, > even if not being fully used and containing some garbage. > Users may want to include those hugepages in core dump. > > Add `--huge-dump` EAL command-line option to include in core dump > all mapped hugepages and also non-hugepage memory > allocated with `--no-huge` (as it substitutes for hugepages). > Using this option requires more disk storage for core dumps, > and also may include sensitive data in core dump, > which is why it must be explicitly enabled and a warning is printed. > > Linux requires /proc/self/coredump_filter adjustment > to include hugepages mapped with MAP_SHARED in core dump. > Windows EAL requires no change since it automatically > excludes reserved memory and includes committed memory. > > Signed-off-by: Dmitry Kozlyuk Has build errors.