From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 70FE345BB9; Thu, 24 Oct 2024 04:31:25 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5F8724060F; Thu, 24 Oct 2024 04:31:25 +0200 (CEST) Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) by mails.dpdk.org (Postfix) with ESMTP id 8192B402CF for ; Thu, 24 Oct 2024 04:31:23 +0200 (CEST) Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-7e6cbf6cd1dso239165a12.3 for ; Wed, 23 Oct 2024 19:31:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729737082; x=1730341882; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=mQ7veamtyLOxe6va9ZAIpcROk2O5/VKdIIfKikFrDeI=; b=EozUh9wit8IK75Q8pQ8WTN8QpemGVfTpwpNpylCAG4wvMxFLSdyNpImOIRBSVXpEOn DujKJIaOoO3MMXES5LjpDwKNlIwUpDW+bIdVdar9oerNfCHQoHAlcXIggAL2dsgk30tG GUEi6hINIRJJDG4x7D/45dFSEMf95Cib+bo2HLNUM3EWSHMT8flovj9066Ouec/UXGoL 3w5BsbAheMYWoVPB0HBosDlcSTBKOI4hZ3GjwLq31drD2wZihhl7hSwtErVCc3B5C95c /drbC6Jwz7Z4onIV/QDGTK3+zSRQsiVIj9U+qpXkd55bZa8Rqy/8NphTzbjdKdgMt/O5 RZHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729737082; x=1730341882; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mQ7veamtyLOxe6va9ZAIpcROk2O5/VKdIIfKikFrDeI=; b=v3WxQ2vzczfhFizOBatRJeKuZ1LyGUONn9ASiGyEIFzexIlf+4kRgDYaRrN4HWesVW 5Q8UOeutJLzU+ImErS5mX6Kd25VYnWEDbGALdckf6MqRFr3aHN2WTRw+btTHNkpRBfjO dbfdyqw7HahE+RvXzK7oZbgEaZBWCf7YsxcE4OXS7/c87qdj/eJt3Gtb9uThgCiaNF4p 50/WV2FMFX18tEkhZgo3vK459KNNfqAvHNktVJoJGvIfoXoFKoh2uqZOUoeg+TZ1wZp/ slIPIV5+zdcLEpkOO5YIfEsClWnMSZQGqFK93Ec0xebK9IRdMaJueFZXHHuCjGM/3qg4 NOqg== X-Gm-Message-State: AOJu0YwSnTVSAOBBwRdag4JLhn/Ktf7mS3qMapIs2e99HObPV1O/JP7K 2Brd+C4TeLbX3Y+Qr804AKMv+89vi2FLrkmBhouv7w8NpOIPWInC+eiwOwrZ+y8= X-Google-Smtp-Source: AGHT+IHpVZyTtGHr5PBLJpXuX2GaOglQxk9RzLwWT0sZVCPPECufkA4VmtJ8JnU3BL4LqJrbKGqwdw== X-Received: by 2002:a05:6a21:3942:b0:1d9:17fa:e5d8 with SMTP id adf61e73a8af0-1d978b3e396mr5705292637.26.1729737082566; Wed, 23 Oct 2024 19:31:22 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71ec1356a24sm7142720b3a.96.2024.10.23.19.31.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Oct 2024 19:31:22 -0700 (PDT) Date: Wed, 23 Oct 2024 19:31:20 -0700 From: Stephen Hemminger To: Dmitry Kozlyuk Cc: dev@dpdk.org, Anatoly Burakov , Lewis Donzis Subject: Re: [PATCH] eal: support including mapped memory in core dump Message-ID: <20241023193120.6d6ed87f@hermes.local> In-Reply-To: <20241023231859.1323727-1-kozlyuk@bifit.com> References: <20241023231859.1323727-1-kozlyuk@bifit.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 24 Oct 2024 02:18:59 +0300 Dmitry Kozlyuk wrote: > --- a/lib/eal/common/eal_internal_cfg.h > +++ b/lib/eal/common/eal_internal_cfg.h > @@ -103,6 +103,8 @@ struct internal_config { > struct simd_bitwidth max_simd_bitwidth; > /**< max simd bitwidth path to use */ > size_t huge_worker_stack_size; /**< worker thread stack size */ > + /** True to include mapped hugepages in coredump. */ > + unsigned int huge_dump; No need to waste 4 bytes for a flag. Find an existing one byte hole and use that. struct internal_config { volatile size_t memory; /* 0 8 */ volatile unsigned int force_nchannel; /* 8 4 */ volatile unsigned int force_nrank; /* 12 4 */ volatile unsigned int no_hugetlbfs; /* 16 4 */ struct hugepage_file_discipline hugepage_file; /* 20 2 */ /* XXX 2 bytes hole, try to pack */ volatile unsigned int no_pci; /* 24 4 */ volatile unsigned int no_hpet; /* 28 4 */ volatile unsigned int vmware_tsc_map; /* 32 4 */ volatile unsigned int no_shconf; /* 36 4 */ volatile unsigned int in_memory; /* 40 4 */ volatile unsigned int create_uio_dev; /* 44 4 */ volatile enum rte_proc_type_t process_type; /* 48 4 */ volatile unsigned int force_sockets; /* 52 4 */ volatile volatile uint64_t socket_mem; /* 56 256 */ /* --- cacheline 4 boundary (256 bytes) was 56 bytes ago --- */ volatile unsigned int force_socket_limits; /* 312 4 */ /* XXX 4 bytes hole, try to pack */ /* --- cacheline 5 boundary (320 bytes) --- */ volatile volatile uint64_t socket_limit; /* 320 256 */ /* --- cacheline 9 boundary (576 bytes) --- */ uintptr_t base_virtaddr; /* 576 8 */ volatile unsigned int legacy_mem; /* 584 4 */ volatile unsigned int match_allocations; /* 588 4 */ volatile unsigned int single_file_segments; /* 592 4 */ volatile int syslog_facility; /* 596 4 */ volatile enum rte_intr_mode vfio_intr_mode; /* 600 4 */ rte_uuid_t vfio_vf_token; /* 604 16 */ /* XXX 4 bytes hole, try to pack */ char * hugefile_prefix; /* 624 8 */ char * hugepage_dir; /* 632 8 */ /* --- cacheline 10 boundary (640 bytes) --- */ char * user_mbuf_pool_ops_name; /* 640 8 */ unsigned int num_hugepage_sizes; /* 648 4 */ /* XXX 4 bytes hole, try to pack */ struct hugepage_info hugepage_info[3]; /* 656 12720 */ /* --- cacheline 209 boundary (13376 bytes) --- */ enum rte_iova_mode iova_mode; /* 13376 4 */ /* XXX 4 bytes hole, try to pack */ rte_cpuset_t ctrl_cpuset; /* 13384 128 */ /* --- cacheline 211 boundary (13504 bytes) was 8 bytes ago --- */ volatile unsigned int init_complete; /* 13512 4 */ unsigned int no_telemetry; /* 13516 4 */ struct simd_bitwidth max_simd_bitwidth; /* 13520 4 */ /* XXX last struct has 1 hole */ /* XXX 4 bytes hole, try to pack */ size_t huge_worker_stack_size; /* 13528 8 */ /* size: 13536, cachelines: 212, members: 34 */ /* sum members: 13514, holes: 6, sum holes: 22 */ /* member types with holes: 1, total: 1 */ /* last cacheline: 32 bytes */ };