From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 16D9345BB9; Thu, 24 Oct 2024 05:21:15 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8413D43372; Thu, 24 Oct 2024 05:20:51 +0200 (CEST) Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by mails.dpdk.org (Postfix) with ESMTP id 1876B4335E for ; Thu, 24 Oct 2024 05:20:42 +0200 (CEST) Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-71e681bc315so331566b3a.0 for ; Wed, 23 Oct 2024 20:20:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729740041; x=1730344841; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UfF5OFU4THEiQH/INtpTpQBZpms6s7Uvj06coYmX7Vo=; b=DpPbDmYYatqCD2TlQX0nb04zWyAMwF4DKZ56yxWcc8q/rOZUrLpGwTpqtP7NpKrWwc 2OvyzmCi13EBUxi3Vm4Q2D2dum4eW9vx55XjFsOj6Wyj+NgEE1Pvdu6GnwcJSbglicJI aZgk8MjZOUMqIzuCYBTWIGTsV7Opl/e9PiCujrK3x9eiR07p+nPbQrPGPtE6ivYBKeCs P3C3ld3H+vH0YbqphNwY71Waa3Z60vY2kZ6O9jHDTlv8N1a39fRj5usCob9+BdvesoIn +GwnwfBC4pe7bGut7cLiTFZ1C84whk25m7YgKGwIVHKrNZ3RHuz70a7SRs0frjFuzXw/ d6lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729740041; x=1730344841; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UfF5OFU4THEiQH/INtpTpQBZpms6s7Uvj06coYmX7Vo=; b=HKNvbhK0l3aEfj6c4bLPWDGzRp/bCC7joT6CQ81YLJttLqnAh/op9sH+xACsOCZ7Rr R7IIP9XBVQb/6JhngAl5MHZecYZGTDUnyxe+wzx0CgWSRCG2Veg1BzcTKydkfaGxELEb SAWThFUNQTu6A8lv8VQEl3l7onLQxGzrK+7dtIt9KLKqN45GC6eyuGNZG3ZdXTptHeDM yxChf6U+EBeIksZPbIyZw+ZGY8e9YCeJyLilpgxeUXZs65byq8K6wC5YiFUn5FMxKNbD 3rmcKE7dVTQNQygPItDm7p38XGwi8P872dMdvA5mSMFc83Go/twvhvn88kmhs0ntyCh8 NB+Q== X-Gm-Message-State: AOJu0Yxof577ZCXxA4bM0KJFxt3Q/RFAxg7gq3DtygXFC7mqUQQ/hJVN mdNks5aO2itVQgr8IvpW9un1G7ET/aIWNLkSZ+CWVUiWNk8j+7HKItBUDtR7PiPQL5g8y5XUYAr 5 X-Google-Smtp-Source: AGHT+IEyBKGarYidrprhfdJGiZFkGBQbXnY+rm/w9XdfjWB0NIxtfFR73aK4qjMeA1kzNrehtCC3/A== X-Received: by 2002:a05:6a00:1818:b0:71e:71ba:9056 with SMTP id d2e1a72fcca58-720452dac73mr1104755b3a.10.1729740041052; Wed, 23 Oct 2024 20:20:41 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71ec1324d41sm6999533b3a.57.2024.10.23.20.20.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Oct 2024 20:20:40 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Tyler Retzlaff , =?UTF-8?q?Morten=20Br=C3=B8rup?= , Bruce Richardson , Chengwen Feng , Dmitry Kozlyuk Subject: [PATCH v27 05/14] eal: do not duplicate rte_init_alert() messages Date: Wed, 23 Oct 2024 20:18:43 -0700 Message-ID: <20241024032026.415122-6-stephen@networkplumber.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241024032026.415122-1-stephen@networkplumber.org> References: <20200814173441.23086-1-stephen@networkplumber.org> <20241024032026.415122-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The message already goes through logging, and does not need to be printed on stderr. Message level should be ALERT to match function name. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Bruce Richardson Acked-by: Chengwen Feng --- lib/eal/freebsd/eal.c | 3 +-- lib/eal/linux/eal.c | 3 +-- lib/eal/windows/eal.c | 1 - 3 files changed, 2 insertions(+), 5 deletions(-) diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c index d3b40e81d8..7b974608e4 100644 --- a/lib/eal/freebsd/eal.c +++ b/lib/eal/freebsd/eal.c @@ -529,8 +529,7 @@ rte_eal_iopl_init(void) static void rte_eal_init_alert(const char *msg) { - fprintf(stderr, "EAL: FATAL: %s\n", msg); - EAL_LOG(ERR, "%s", msg); + EAL_LOG(ALERT, "%s", msg); } /* Launch threads, called at application init(). */ diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c index 40d750ed0d..c53a051405 100644 --- a/lib/eal/linux/eal.c +++ b/lib/eal/linux/eal.c @@ -830,8 +830,7 @@ rte_eal_iopl_init(void) static void rte_eal_init_alert(const char *msg) { - fprintf(stderr, "EAL: FATAL: %s\n", msg); - EAL_LOG(ERR, "%s", msg); + EAL_LOG(ALERT, "%s", msg); } /* diff --git a/lib/eal/windows/eal.c b/lib/eal/windows/eal.c index a77e590a72..93f099a968 100644 --- a/lib/eal/windows/eal.c +++ b/lib/eal/windows/eal.c @@ -181,7 +181,6 @@ sync_func(void *arg __rte_unused) static void rte_eal_init_alert(const char *msg) { - fprintf(stderr, "EAL: FATAL: %s\n", msg); EAL_LOG(ERR, "%s", msg); } -- 2.45.2