From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F05E545BB9; Thu, 24 Oct 2024 05:21:21 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A63A64337B; Thu, 24 Oct 2024 05:20:52 +0200 (CEST) Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by mails.dpdk.org (Postfix) with ESMTP id D951E43361 for ; Thu, 24 Oct 2024 05:20:42 +0200 (CEST) Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-71e625b00bcso350799b3a.3 for ; Wed, 23 Oct 2024 20:20:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729740042; x=1730344842; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=o2d4foqEUlKX8e/d7INvNR8WQ2O85ZJBZV4qHltV3dM=; b=bZWVkWroZJ2KZzYVTjdrpAxT9Txt9tFZrR0aSC4KmVe/O4zAjuT0u3KzWEXyXVYjgW m3+nKNGr/1VgBktpxtThtyY3PgCO/EGNzAgnRmdq8ls5iYpToNKji1QgggbkHguc0mpn H2Xck0/GA2KRD9cQFkjG4rh/cSX9h/vTTAvdODGLjizHN975MpwI18eXOJwD3VSHbUVJ wdFElRA5P4v2cYUbUlo4FrDSzYkZSYNi4J6t1mXSmcYJixTj+Xnh97p10bH9EE5FdHIr jRnz2BZhVkL8xQWGemI+AG/IFyF72KEqP2in8LEa21OrZnXzmTeuzPyRhKKyiiTbFD1F wKCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729740042; x=1730344842; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=o2d4foqEUlKX8e/d7INvNR8WQ2O85ZJBZV4qHltV3dM=; b=ERIADx8Ho7/krdDGvJ0tums75KQ8bWPq0KHRB/LpoOR7ApsY7kpDRX6mXxhNEOv4Y8 MnRKTdKLKXAPJGu5H3g/hdU/LuIPyQunO5eh8cP2lRHHhGqs+5+cJzNjVCdu/SeD9CbG hWggwjSdCvaZNmHh3IC+PB+ZmUyU96Me+GU7h8Z7WRl++P1gVJ+P7H6eajySKGNUg1eS hJUhrmiMU8k0sS9ilUvTPUuSPbWYgSSrtPjfPqrGqedl8DqDP7g0EqSdLpbnHAVL0k43 yrBqQdFL86xLWa86v6hrX2BtcM4KRSV1b0SoMsIyNnIdaxrsFMnAknLT7v0ymrvj5JYM BMkw== X-Gm-Message-State: AOJu0Yx9yhS3djjK3YSBJvJcYqTEK1PdT9wm1/RNrICQYq0sgYuu+2Zb yD7WauoAQaUBQU8wSNX13rIbeUaoStpL/wk5uXfLpebwVqN76enmRS2gYHK7/+kFMUFAXbPJnfO g X-Google-Smtp-Source: AGHT+IHtjIr9ZlPTsk1abHNgjqE0+UpcdHMQ4uXxXf874Qa3vFvUdt3PcvLQOudtBdJ91FNkP/QneA== X-Received: by 2002:a05:6a00:856:b0:71e:65ac:33aa with SMTP id d2e1a72fcca58-72030b9d0e5mr5786847b3a.28.1729740042016; Wed, 23 Oct 2024 20:20:42 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71ec1324d41sm6999533b3a.57.2024.10.23.20.20.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Oct 2024 20:20:41 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Tyler Retzlaff , =?UTF-8?q?Morten=20Br=C3=B8rup?= , Bruce Richardson , Chengwen Feng Subject: [PATCH v27 06/14] eal: change rte_exit() output to match rte_log() Date: Wed, 23 Oct 2024 20:18:44 -0700 Message-ID: <20241024032026.415122-7-stephen@networkplumber.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241024032026.415122-1-stephen@networkplumber.org> References: <20200814173441.23086-1-stephen@networkplumber.org> <20241024032026.415122-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The rte_exit() output format confuses the timestamp and coloring options. Change it to use be a single line with proper prefix. Before: [ 0.006481] EAL: Error - exiting with code: 1 Cause: [ 0.006489] Cannot init EAL: Permission denied After: [ 0.006238] EAL: Error - exiting with code: 1 [ 0.006250] EAL: Cannot init EAL: Permission denied Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Bruce Richardson Acked-by: Chengwen Feng --- lib/eal/common/eal_common_debug.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/eal/common/eal_common_debug.c b/lib/eal/common/eal_common_debug.c index 3e77995896..bcfcd6df6f 100644 --- a/lib/eal/common/eal_common_debug.c +++ b/lib/eal/common/eal_common_debug.c @@ -36,15 +36,13 @@ rte_exit(int exit_code, const char *format, ...) va_list ap; if (exit_code != 0) - RTE_LOG(CRIT, EAL, "Error - exiting with code: %d\n" - " Cause: ", exit_code); + EAL_LOG(CRIT, "Error - exiting with code: %d", exit_code); va_start(ap, format); rte_vlog(RTE_LOG_CRIT, RTE_LOGTYPE_EAL, format, ap); va_end(ap); if (rte_eal_cleanup() != 0 && rte_errno != EALREADY) - EAL_LOG(CRIT, - "EAL could not release all resources"); + EAL_LOG(CRIT, "EAL could not release all resources"); exit(exit_code); } -- 2.45.2