From: Stephen Hemminger <stephen@networkplumber.org>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: dev@dpdk.org, techboard@dpdk.org, david.marchand@redhat.com,
thomas@monjalon.net, mb@smartsharesystems.com,
ferruh.yigit@amd.com
Subject: Re: [PATCH v1 1/3] uapi: introduce kernel uAPI headers import
Date: Thu, 24 Oct 2024 09:14:43 -0700 [thread overview]
Message-ID: <20241024091443.56214add@hermes.local> (raw)
In-Reply-To: <3eb53ec1-2c57-4efe-b797-60d3aa0785c6@redhat.com>
On Thu, 24 Oct 2024 14:45:10 +0200
Maxime Coquelin <maxime.coquelin@redhat.com> wrote:
> >>
> >>
> >> Rather than copy-pasting headers_install.sh, could you use it directly?
> >>
> >> The copy/paste from GPL-2.0 concerns me.
> >> And the potential upstream change as well.
> >>
> >
> > The downside I see by calling directly the headers_install.sh script is
> > that it could trigger some false positives if the version used for
> > import is different from the one used to check.
> >
> > What we could do it to just do our own sed command if that's really an
> > issue, that we would tailor based on our needs.
> >
> > Others, any thoughts?
>
> Following the discussion during the DPDK Release status meeting this
> morning, I will propose a new version implementing our own sed command,
> tailored to only our needs.
Or you can just ask original author of the headers_install.sh script.
Have done that many times and gotten approval every time when taking
stuff out of kernel infrastructure for DPDK.
next prev parent reply other threads:[~2024-10-24 16:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-09 8:58 [PATCH v1 0/3] Import Kernel uAPI header files Maxime Coquelin
2024-10-09 8:58 ` [PATCH v1 1/3] uapi: introduce kernel uAPI headers import Maxime Coquelin
2024-10-09 14:50 ` Stephen Hemminger
2024-10-14 12:14 ` Maxime Coquelin
2024-10-24 12:45 ` Maxime Coquelin
2024-10-24 16:14 ` Stephen Hemminger [this message]
2024-10-09 8:58 ` [PATCH v1 2/3] uapi: import VDUSE header Maxime Coquelin
2024-10-09 8:58 ` [PATCH v1 3/3] vduse: use imported VDUSE uAPI header Maxime Coquelin
2024-10-15 17:10 ` Stephen Hemminger
2024-10-09 10:29 ` [PATCH v1 0/3] Import Kernel uAPI header files Morten Brørup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241024091443.56214add@hermes.local \
--to=stephen@networkplumber.org \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=maxime.coquelin@redhat.com \
--cc=mb@smartsharesystems.com \
--cc=techboard@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).