From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 24B9145BC6; Thu, 24 Oct 2024 18:14:48 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 12B9940265; Thu, 24 Oct 2024 18:14:48 +0200 (CEST) Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by mails.dpdk.org (Postfix) with ESMTP id 96AB14025C for ; Thu, 24 Oct 2024 18:14:46 +0200 (CEST) Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-20ceb8bd22fso8266905ad.3 for ; Thu, 24 Oct 2024 09:14:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729786485; x=1730391285; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=YZZaftzDvDzchmDBhr9jCV0+D9E6whDeD5wkUNijY9k=; b=HTrXfUxJ4FFw+VZWiR6hKlaMPjvaNSqbteKdnAmgeu1P7Fq1ENpVuf/mDern4g2ojr YL3LoBi8Og60LllFX2KmBeXIHlYunj5gnY5ipQ2YVWRveFmWhIGoQnvON4Zae/N/hAO1 +s8UxEMmOfOJs43IeQ4pjcsODgttY1XtWXCN/2gIXKN7ciS2mVAr84atkRPrihdZYaHV nbw09TOcbA2+mQbcCsZQLqaIpG8Ntn/l/k3BpYM1nYRWbFMZHDVVIj6i+6b9gccNeuoA rVCqzNL7B9sjB8C5nmZAA7Vh/0BDFYjVnx6bsUlKyVXu79Jc7CmfSg3s6yMgTLldkRlq zUmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729786485; x=1730391285; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YZZaftzDvDzchmDBhr9jCV0+D9E6whDeD5wkUNijY9k=; b=LbekxvdC3wKY98tYIjSqTf9t38yBsyEunsyPq5cX+bhQMspFpSuij61gDfFSpTjOYd G5AKy43HlMqgSgvu4IeG6yVhOrFEuaFyTZVVwKsNbsUTIDgYCZvFLFamCzWIj5TyvS7V CQGQQ+bUrl/mboJPhGGVxNCKBKhrMP4uBypMWbeJDC1kFu5wo/2/IYH8rKWLdF30VMCd yVsVFGZVbOsLushlX8Vpfy4VlMQyjqArajMCcSOKTj8VGqhexy5f9H+Ssx7afM8mp4kN q74PClBBitRoGRmiId05pgPv8ryOLZP8EqsgM72u95NmFDktoT/9Gla6aIc1nJyBTpsm 0n0A== X-Gm-Message-State: AOJu0Yz48hgnhp99vtganKHnB3bv9yjo0nzXbfrWpAJfYXU3baJtxXrM i9wE04nNpraYazSMdG49v49z+/vFWB8dhevV2l0QEfaB7JTmXyCDMh/kVeWgatg= X-Google-Smtp-Source: AGHT+IFMZM5MVfJEyaUhhTnm1glf3KgZsQnlxYmTqbKi0aCEzP514VLp/hUNNZPMjXF3JYN4q01zBA== X-Received: by 2002:a17:902:db0e:b0:20c:e2ff:4a2e with SMTP id d9443c01a7336-20fab307417mr96508675ad.53.1729786485490; Thu, 24 Oct 2024 09:14:45 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20e7f0bd578sm74047735ad.126.2024.10.24.09.14.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Oct 2024 09:14:45 -0700 (PDT) Date: Thu, 24 Oct 2024 09:14:43 -0700 From: Stephen Hemminger To: Maxime Coquelin Cc: dev@dpdk.org, techboard@dpdk.org, david.marchand@redhat.com, thomas@monjalon.net, mb@smartsharesystems.com, ferruh.yigit@amd.com Subject: Re: [PATCH v1 1/3] uapi: introduce kernel uAPI headers import Message-ID: <20241024091443.56214add@hermes.local> In-Reply-To: <3eb53ec1-2c57-4efe-b797-60d3aa0785c6@redhat.com> References: <20241009085805.2638314-1-maxime.coquelin@redhat.com> <20241009085805.2638314-2-maxime.coquelin@redhat.com> <20241009075004.513224f2@hermes.local> <1e79879c-ab72-444c-9cb5-fb96cff25987@redhat.com> <3eb53ec1-2c57-4efe-b797-60d3aa0785c6@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 24 Oct 2024 14:45:10 +0200 Maxime Coquelin wrote: > >> > >> > >> Rather than copy-pasting headers_install.sh, could you use it directly? > >> > >> The copy/paste from GPL-2.0 concerns me. > >> And the potential upstream change as well. > >> > > > > The downside I see by calling directly the headers_install.sh script is > > that it could trigger some false positives if the version used for > > import is different from the one used to check. > > > > What we could do it to just do our own sed command if that's really an > > issue, that we would tailor based on our needs. > > > > Others, any thoughts? > > Following the discussion during the DPDK Release status meeting this > morning, I will propose a new version implementing our own sed command, > tailored to only our needs. Or you can just ask original author of the headers_install.sh script. Have done that many times and gotten approval every time when taking stuff out of kernel infrastructure for DPDK.