From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DA8DF45BC0; Thu, 24 Oct 2024 10:25:43 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B6DAD4339A; Thu, 24 Oct 2024 10:25:43 +0200 (CEST) Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) by mails.dpdk.org (Postfix) with ESMTP id 063B543352 for ; Thu, 24 Oct 2024 10:25:42 +0200 (CEST) Received: by mail-lj1-f172.google.com with SMTP id 38308e7fff4ca-2fabb837ddbso9059821fa.1 for ; Thu, 24 Oct 2024 01:25:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729758341; x=1730363141; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=wNpr1m8JEaxqA7RTGLCuAL1q39Vvyio/APSKUlg5mqE=; b=l8f74++OHAjUKvZWG1yJghL1xy0hJ732dW2Cv8J6ISlozCuQSBfvm7l6SS1aMGLhX8 xkXH6/UqpAIi4FscjATVAd599C0IIdxXLy/7u6USAwTtXSTY9obLmjPAm+F6AzLryx5H WbckVgcFSYyFcjN77ngG6QcR5krczoC6WwvyCJ1wYT1QdLnOWpaHelCRgfErXzYFGl5g vXv5N5pFFy7sA//26CJGUd/X0Lm5FtwAD5w74eCeXUkzqmuZsJqo/NOqnyMaWHdazGZ9 znUdZmGnOrIrblPIXAmpb1l6Y53znQYaV45UYOi3sXJfJyxZqZMIDrzgT75+R/jLajQ9 BpoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729758341; x=1730363141; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wNpr1m8JEaxqA7RTGLCuAL1q39Vvyio/APSKUlg5mqE=; b=WT3AGnlf62MqhVbwc8tOxyG8wYRFQKlSUIQEOEYUleO7cpSDcD5f65eOVsRfC02e5S j0n8Uf8WvYvZ4gLqLThSE4j1ELXfrJTgqw3Xf4NvwPN//Ww08Vo1/Cwnu4jVposvqQct oekhZnPuGQQPEurQksvcwot09zpz2WM1vEsJT8VvmKRAmssg1yUPEwlBpnyWK6GA4gPy psbfZiMJ7/5NxD4s8MGEfNwj63TalT532lrQ4bREFbTBeFNI6OcbpEavcmGV6Na8fn3N Ru+WgwMBAGWf8nEOlltsv8OkkAFwVWSUzVXWnQB9KWPSJXP+CvkCs96gGc5xR1xtlXRA hBHQ== X-Gm-Message-State: AOJu0YyqDGPEPBSDwZmti191W9cgLl7mHsZqClzOLvuDGUoidCnrHIWH Vpe2iB8ex5mqiB3S50aetiQG2K7M9jNd5qcQq55wJXautkQzXGJH X-Google-Smtp-Source: AGHT+IE3YDBTby0IOZcJRygmBSjKUmZ23aBfeQBZ2EbNA/+VRMViDBls3uYAz3JDaU7qvpV7Orl3Yg== X-Received: by 2002:a2e:be85:0:b0:2fa:d4ef:f234 with SMTP id 38308e7fff4ca-2fc9d2e4e0cmr42011211fa.1.1729758335324; Thu, 24 Oct 2024 01:25:35 -0700 (PDT) Received: from sovereign (broadband-109-173-43-194.ip.moscow.rt.ru. [109.173.43.194]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-2fb9ad4b838sm13353121fa.5.2024.10.24.01.25.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Oct 2024 01:25:33 -0700 (PDT) Date: Thu, 24 Oct 2024 11:25:31 +0300 From: Dmitry Kozlyuk To: Morten =?UTF-8?B?QnLDuHJ1cA==?= Cc: , "Anatoly Burakov" , "Lewis Donzis" , "Stephen Hemminger" Subject: Re: [PATCH] eal: support including mapped memory in core dump Message-ID: <20241024112531.351e77a0@sovereign> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9F814@smartserver.smartshare.dk> References: <20241023231859.1323727-1-kozlyuk@bifit.com> <98CBD80474FA8B44BF855DF32C47DC35E9F814@smartserver.smartshare.dk> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 2024-10-24 09:22 (UTC+0200), Morten Br=C3=B8rup: > > From: Dmitry Kozlyuk [mailto:dmitry.kozliuk@gmail.com] > > Sent: Thursday, 24 October 2024 01.19 [...] > > Add `--huge-dump` EAL command-line option to include in core dump > > all mapped hugepages and also non-hugepage memory > > allocated with `--no-huge` (as it substitutes for hugepages). =20 >=20 > I agree with the behavior of also dumping --no-huge mapped. > Perhaps because of this, the option should be named differently; something > like --dump-verbose, --dump-all, --dump-mapped.=20 Or one may interpret "huge dump" as "the dump will be huge" :) I'll use "--dump-mapped" as the most precise, thanks. > > Linux requires /proc/self/coredump_filter adjustment > > to include hugepages mapped with MAP_SHARED in core dump. > > Windows EAL requires no change since it automatically > > excludes reserved memory and includes committed memory. =20 >=20 > The above O/S specific information should also be included as notes in th= e documentation. [...] > If there are any notes about FreeBSD, like the notes about Linux and > Windows above, it should also be included in the documentation. "Linux requires..." here explains what DPDK code in the patch is doing and "Windows EAL requires no change" explains why there are no code changes. No OS-specific user action is required for --huge-dump to work. I'll rephrase that comment and add a release note about the new option, but I think documentation already contains everything users need.