* [PATCH v2] net/ixgbe: support per-queue stats for fewer queues
@ 2024-10-24 18:53 Morten Brørup
2024-10-24 18:58 ` Morten Brørup
2024-10-24 19:05 ` Stephen Hemminger
0 siblings, 2 replies; 4+ messages in thread
From: Morten Brørup @ 2024-10-24 18:53 UTC (permalink / raw)
To: dev, Anatoly Burakov, Vladimir Medvedkin
Cc: Bruce Richardson, Stephen Hemminger, Morten Brørup
Remove the requirement that the configured number of queues to provide
statistics for (RTE_ETHDEV_QUEUE_STAT_CNTRS) cannot be less than the
driver's max supported number of the same (IXGBE_QUEUE_STAT_COUNTERS).
Signed-off-by: Morten Brørup <mb@smartsharesystems.com>
---
v2:
* Fix subject. (Bruce Richardson)
* Simplify type cast. (Bruce Richardson, Stephen Hemminger)
---
drivers/net/ixgbe/ixgbe_ethdev.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index ab37c37469..09d648af6d 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -3385,7 +3385,8 @@ ixgbe_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
stats->opackets = hw_stats->gptc;
stats->obytes = hw_stats->gotc;
- for (i = 0; i < IXGBE_QUEUE_STAT_COUNTERS; i++) {
+ for (i = 0; i < RTE_MIN_T(IXGBE_QUEUE_STAT_COUNTERS,
+ RTE_ETHDEV_QUEUE_STAT_CNTRS, typeof(i)); i++) {
stats->q_ipackets[i] = hw_stats->qprc[i];
stats->q_opackets[i] = hw_stats->qptc[i];
stats->q_ibytes[i] = hw_stats->qbrc[i];
--
2.43.0
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: [PATCH v2] net/ixgbe: support per-queue stats for fewer queues
2024-10-24 18:53 [PATCH v2] net/ixgbe: support per-queue stats for fewer queues Morten Brørup
@ 2024-10-24 18:58 ` Morten Brørup
2024-10-24 19:05 ` Stephen Hemminger
1 sibling, 0 replies; 4+ messages in thread
From: Morten Brørup @ 2024-10-24 18:58 UTC (permalink / raw)
To: dev, Anatoly Burakov, Vladimir Medvedkin
Cc: Bruce Richardson, Stephen Hemminger
> From: Morten Brørup [mailto:mb@smartsharesystems.com]
> Sent: Thursday, 24 October 2024 20.54
>
> Remove the requirement that the configured number of queues to provide
> statistics for (RTE_ETHDEV_QUEUE_STAT_CNTRS) cannot be less than the
> driver's max supported number of the same (IXGBE_QUEUE_STAT_COUNTERS).
>
> Signed-off-by: Morten Brørup <mb@smartsharesystems.com>
Forgot the
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
And the
--in-reply-to 20241024111757.791634-1-mb@smartsharesystems.com
> ---
> v2:
> * Fix subject. (Bruce Richardson)
> * Simplify type cast. (Bruce Richardson, Stephen Hemminger)
> ---
> drivers/net/ixgbe/ixgbe_ethdev.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> b/drivers/net/ixgbe/ixgbe_ethdev.c
> index ab37c37469..09d648af6d 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -3385,7 +3385,8 @@ ixgbe_dev_stats_get(struct rte_eth_dev *dev,
> struct rte_eth_stats *stats)
> stats->opackets = hw_stats->gptc;
> stats->obytes = hw_stats->gotc;
>
> - for (i = 0; i < IXGBE_QUEUE_STAT_COUNTERS; i++) {
> + for (i = 0; i < RTE_MIN_T(IXGBE_QUEUE_STAT_COUNTERS,
> + RTE_ETHDEV_QUEUE_STAT_CNTRS, typeof(i)); i++) {
> stats->q_ipackets[i] = hw_stats->qprc[i];
> stats->q_opackets[i] = hw_stats->qptc[i];
> stats->q_ibytes[i] = hw_stats->qbrc[i];
> --
> 2.43.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] net/ixgbe: support per-queue stats for fewer queues
2024-10-24 18:53 [PATCH v2] net/ixgbe: support per-queue stats for fewer queues Morten Brørup
2024-10-24 18:58 ` Morten Brørup
@ 2024-10-24 19:05 ` Stephen Hemminger
2024-10-25 10:11 ` Bruce Richardson
1 sibling, 1 reply; 4+ messages in thread
From: Stephen Hemminger @ 2024-10-24 19:05 UTC (permalink / raw)
To: Morten Brørup
Cc: dev, Anatoly Burakov, Vladimir Medvedkin, Bruce Richardson
On Thu, 24 Oct 2024 18:53:52 +0000
Morten Brørup <mb@smartsharesystems.com> wrote:
> Remove the requirement that the configured number of queues to provide
> statistics for (RTE_ETHDEV_QUEUE_STAT_CNTRS) cannot be less than the
> driver's max supported number of the same (IXGBE_QUEUE_STAT_COUNTERS).
>
> Signed-off-by: Morten Brørup <mb@smartsharesystems.com>
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] net/ixgbe: support per-queue stats for fewer queues
2024-10-24 19:05 ` Stephen Hemminger
@ 2024-10-25 10:11 ` Bruce Richardson
0 siblings, 0 replies; 4+ messages in thread
From: Bruce Richardson @ 2024-10-25 10:11 UTC (permalink / raw)
To: Stephen Hemminger
Cc: Morten Brørup, dev, Anatoly Burakov, Vladimir Medvedkin
On Thu, Oct 24, 2024 at 12:05:39PM -0700, Stephen Hemminger wrote:
> On Thu, 24 Oct 2024 18:53:52 +0000
> Morten Brørup <mb@smartsharesystems.com> wrote:
>
> > Remove the requirement that the configured number of queues to provide
> > statistics for (RTE_ETHDEV_QUEUE_STAT_CNTRS) cannot be less than the
> > driver's max supported number of the same (IXGBE_QUEUE_STAT_COUNTERS).
> >
> > Signed-off-by: Morten Brørup <mb@smartsharesystems.com>
>
>
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
Applied to dpdk-next-net-intel.
Thanks,
/Bruce
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-10-25 10:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-10-24 18:53 [PATCH v2] net/ixgbe: support per-queue stats for fewer queues Morten Brørup
2024-10-24 18:58 ` Morten Brørup
2024-10-24 19:05 ` Stephen Hemminger
2024-10-25 10:11 ` Bruce Richardson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).