From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B985A45BC3; Thu, 24 Oct 2024 21:08:30 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A61C3434E6; Thu, 24 Oct 2024 21:08:30 +0200 (CEST) Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by mails.dpdk.org (Postfix) with ESMTP id 9160140156 for ; Thu, 24 Oct 2024 21:08:29 +0200 (CEST) Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-20cbcd71012so12241755ad.3 for ; Thu, 24 Oct 2024 12:08:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729796908; x=1730401708; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uzdYw/kHsug1foz8g7gZ+YvJi60jl/HxyYCL8VgW3dU=; b=bFTDiV/uvZ38bn5+TxLayi/Rgl3NXoCes4nrRpAviIo+l09ehJntesXSA4G3viCof3 0HZplzHcMzm5elWDbovWgMTFsPyAEHou9zxyO3M+Gdf+2RZFz+cuiGKV5q8YqDonN5lg 6lsFX5bkpown+UqoMBJ1xjklW0yQcEMiXpnt1T3m43aQNa4cqbBrEuAiL4oEAfseR7UB HwwIguJG5/UvV8FFjPZjMxK0VB+buErdo9tWwbuRUVeEwJJ7culcxhwRvG8WNOT810+H OwzZrPtQxK5e5Sc9BYJn4d/sdMfGdPyZxPVlVGv0qOKya1JrJ+vOJztDNQbgs6VjO6Hd M89w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729796908; x=1730401708; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uzdYw/kHsug1foz8g7gZ+YvJi60jl/HxyYCL8VgW3dU=; b=KhhQ4EOf5M3k3fr3NRR7rq0fISjdHSy64+9o3jEjqXE9h2MGL4YXxZmQBhObqTC0hr 75umct/O64iveN5nQ1yP+AG59Iy0MOLSlhNPuTUlZVSNeJgXEe2KjtdtY7wo1rHtYSnk lC9oJ4Ouy280h3/KCkIhULyHuVICXYdf06Gtzc2U8QOisCvhVGlBH0YByIOXYiiQ/il1 5xuzjXE+6xwYtWhhLl5k3kKbRNdEHUHzhVGniyijqAbymg4hbUvxGcg3SS6qZDf3rMYD wXm3zq+vkLQr0ASYHLB3tyAe8/fnAn5lbf/mHEZwi2dSIl+EcNlmS+4MV6ACHSH4xVl/ 00Qg== X-Gm-Message-State: AOJu0YzF5NCno4Zrjn7yLLIqgWwBuoo8+iqi/bYg5RiFd0aB8JRYP72e O1/bfCRzAhKM0lXHU77W807ylazswvpO1ZoY8B1Rf2M0NnYSdSIdW8uia5VrsmELYNHNGGOXw1e F X-Google-Smtp-Source: AGHT+IGjAf3MwqofNkZ+1f8qagQpjAlhsGBneeGVDjskPQTevgdVOmmCvfOZ8BNd/Z96KWslneWphg== X-Received: by 2002:a17:903:18e:b0:20b:6918:30b5 with SMTP id d9443c01a7336-20fa9e9f77emr107755985ad.41.1729796908581; Thu, 24 Oct 2024 12:08:28 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20e7f0f364bsm75535385ad.264.2024.10.24.12.08.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Oct 2024 12:08:28 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [PATCH v28 00/13] Logging subsystem improvements Date: Thu, 24 Oct 2024 12:02:46 -0700 Message-ID: <20241024190818.172863-1-stephen@networkplumber.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20200814173441.23086-1-stephen@networkplumber.org> References: <20200814173441.23086-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Improvements and unification of logging library. This version works on all platforms: Linux, Windows and FreeBSD. This is update to rework patch set. It adds several new features to the console log output. * Putting a timestamp on console output which is useful for analyzing performance of startup codes. Timestamp is optional and must be enabled on command line. * Displaying console output with colors. It uses the standard conventions used by many other Linux commands for colorized display. The default is to enable color if the console output is going to a terminal. But it can be always on or disabled by command line flag. This default was chosen based on what dmesg(1) command does. Color is used by many tools (vi, iproute2, git) because it is helpful; DPDK drivers and libraries print lots of not very useful messages. And having error messages highlighted in bold face helps. This might also get users to pay more attention to error messages. Many bug reports have earlier messages that are lost because there are so many info messages. * Add support for automatic detection of systemd journal protocol. If running as systemd service will get enhanced logging. * Use of syslog is optional and the meaning of the --syslog flag has changed. The default is *not* to use unless requested. Add myself as maintainer for log because by now have added more than previous authors. v28 - fix windows build fixup documentation around syslog consolidate syslog patches Stephen Hemminger (13): maintainers: add for log library windows: make getopt functions have const properties windows: update os shim eal: make eal_log_level_parse common eal: do not duplicate rte_init_alert() messages eal: change rte_exit() output to match rte_log() log: rework syslog handling eal: initialize log before everything else log: add hook for printing log messages log: add timestamp option log: add support for systemd journal log: colorize log output doc: add release note about log library MAINTAINERS | 1 + app/test/test_eal_flags.c | 66 ++++- .../freebsd_gsg/freebsd_eal_parameters.rst | 27 ++ .../prog_guide/env_abstraction_layer.rst | 6 +- doc/guides/prog_guide/log_lib.rst | 57 ++++- doc/guides/rel_notes/release_24_11.rst | 19 ++ lib/eal/common/eal_common_debug.c | 6 +- lib/eal/common/eal_common_options.c | 122 +++++---- lib/eal/common/eal_internal_cfg.h | 1 - lib/eal/common/eal_options.h | 5 + lib/eal/freebsd/eal.c | 65 ++--- lib/eal/linux/eal.c | 68 +---- lib/eal/windows/eal.c | 50 +--- lib/eal/windows/getopt.c | 23 +- lib/eal/windows/include/getopt.h | 8 +- lib/eal/windows/include/rte_os_shim.h | 10 + lib/log/log.c | 76 ++++-- lib/log/log_color.c | 214 ++++++++++++++++ lib/log/log_freebsd.c | 12 - lib/log/log_internal.h | 22 +- lib/log/log_journal.c | 154 +++++++++++ lib/log/log_linux.c | 61 ----- lib/log/log_private.h | 53 ++++ lib/log/log_syslog.c | 109 ++++++++ lib/log/log_timestamp.c | 240 ++++++++++++++++++ lib/log/log_windows.c | 18 -- lib/log/meson.build | 12 +- lib/log/version.map | 5 +- 28 files changed, 1158 insertions(+), 352 deletions(-) create mode 100644 lib/log/log_color.c delete mode 100644 lib/log/log_freebsd.c create mode 100644 lib/log/log_journal.c delete mode 100644 lib/log/log_linux.c create mode 100644 lib/log/log_private.h create mode 100644 lib/log/log_syslog.c create mode 100644 lib/log/log_timestamp.c delete mode 100644 lib/log/log_windows.c -- 2.45.2