From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 21B1645BC3; Thu, 24 Oct 2024 21:08:59 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8D5CA43552; Thu, 24 Oct 2024 21:08:39 +0200 (CEST) Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by mails.dpdk.org (Postfix) with ESMTP id 290C843569 for ; Thu, 24 Oct 2024 21:08:34 +0200 (CEST) Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-20cbca51687so11391925ad.1 for ; Thu, 24 Oct 2024 12:08:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729796913; x=1730401713; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UfF5OFU4THEiQH/INtpTpQBZpms6s7Uvj06coYmX7Vo=; b=o+4W2erLpyZBEiwoHi/UEJWnX/ZU+shKIM6K5J27Xn/OpL7U9XyDlJVOE7eQBq/KyR csTdDekvMFbJbMC5DnLEpo3EkxutCDsFXqsvRtWAZNgAEiwpB8ylA9O2Tewvbqe+x32H mmYApEXEArTQpBR6UfxpRgXAdvAeozRg5gzd3GyEF+jvgm7luk1Hd+fOdlF0pNeVDE/H JMY6+BC8MspaQ4tzu28Nnw7ASJzgwiSs6KZk2Bb/XNawIknvFD62lQevCuV8G/UI1tFt hC12YYEGLpHA/xppGzewgLs3r/+I3UJl7Blsfqum4cCz7HQB+nSUo5veFH7dLus7/CH6 OVqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729796913; x=1730401713; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UfF5OFU4THEiQH/INtpTpQBZpms6s7Uvj06coYmX7Vo=; b=w6CVXHzDWyEM8SWWWCqrmR6D+eMx/7ZoP9uEtLTFenUzMH+BI5vmjKgWu3Tfy+8PYI C8LPH5k10PcI52KgCgoxP3a/UIQ/+ui1J89wHS04jFStC233+iz2R/jzzK2sS8Exlpg9 7z6+VE2U9hm02UrowVzAWCURmY3Zc/9HhHKloLUfwaxCV8eh3LV0Z9jU6P+xBgl0qhnj YNEzYcR/J6x9FqRjCFlfvEB2rSXXcINp1PeCICN7Hmu+x7z7Cumrye8H+7+CMN5Hngvh aA5m3coUFjvs//dkx9oQMOjc/XUL9grOWRq1qhqUrAdnoBsJwKzjfo2wtOmaYX0v9TAz xu8g== X-Gm-Message-State: AOJu0Yy/jsDU8CLHzSIIAJoiMW+BvIt6Qud0eOQw1Rs2ndJtR6Gmkqpl 2bqc5ma7BQZUZQvpywhlJl9yuMzWjxePa4cbIG+XJtrAmlj8JDf2AwjbjNWiXBSdXFC8tJdrTAA F X-Google-Smtp-Source: AGHT+IEMRl0aF7/L5vChn5o7FCPMC/jBRDCL69h8nlAL79JTT/kNUSdqagtGhdlKAhXVq+2hnIthwg== X-Received: by 2002:a17:903:32c9:b0:20b:b40b:3454 with SMTP id d9443c01a7336-20fa707787dmr84278285ad.0.1729796913208; Thu, 24 Oct 2024 12:08:33 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20e7f0f364bsm75535385ad.264.2024.10.24.12.08.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Oct 2024 12:08:32 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Tyler Retzlaff , =?UTF-8?q?Morten=20Br=C3=B8rup?= , Bruce Richardson , Chengwen Feng , Dmitry Kozlyuk Subject: [PATCH v28 05/13] eal: do not duplicate rte_init_alert() messages Date: Thu, 24 Oct 2024 12:02:51 -0700 Message-ID: <20241024190818.172863-6-stephen@networkplumber.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241024190818.172863-1-stephen@networkplumber.org> References: <20200814173441.23086-1-stephen@networkplumber.org> <20241024190818.172863-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The message already goes through logging, and does not need to be printed on stderr. Message level should be ALERT to match function name. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Bruce Richardson Acked-by: Chengwen Feng --- lib/eal/freebsd/eal.c | 3 +-- lib/eal/linux/eal.c | 3 +-- lib/eal/windows/eal.c | 1 - 3 files changed, 2 insertions(+), 5 deletions(-) diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c index d3b40e81d8..7b974608e4 100644 --- a/lib/eal/freebsd/eal.c +++ b/lib/eal/freebsd/eal.c @@ -529,8 +529,7 @@ rte_eal_iopl_init(void) static void rte_eal_init_alert(const char *msg) { - fprintf(stderr, "EAL: FATAL: %s\n", msg); - EAL_LOG(ERR, "%s", msg); + EAL_LOG(ALERT, "%s", msg); } /* Launch threads, called at application init(). */ diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c index 40d750ed0d..c53a051405 100644 --- a/lib/eal/linux/eal.c +++ b/lib/eal/linux/eal.c @@ -830,8 +830,7 @@ rte_eal_iopl_init(void) static void rte_eal_init_alert(const char *msg) { - fprintf(stderr, "EAL: FATAL: %s\n", msg); - EAL_LOG(ERR, "%s", msg); + EAL_LOG(ALERT, "%s", msg); } /* diff --git a/lib/eal/windows/eal.c b/lib/eal/windows/eal.c index a77e590a72..93f099a968 100644 --- a/lib/eal/windows/eal.c +++ b/lib/eal/windows/eal.c @@ -181,7 +181,6 @@ sync_func(void *arg __rte_unused) static void rte_eal_init_alert(const char *msg) { - fprintf(stderr, "EAL: FATAL: %s\n", msg); EAL_LOG(ERR, "%s", msg); } -- 2.45.2