From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1785245BC3; Thu, 24 Oct 2024 21:09:05 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 96A7F43576; Thu, 24 Oct 2024 21:08:40 +0200 (CEST) Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by mails.dpdk.org (Postfix) with ESMTP id E5D1F43558 for ; Thu, 24 Oct 2024 21:08:34 +0200 (CEST) Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-20c8b557f91so10465175ad.2 for ; Thu, 24 Oct 2024 12:08:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729796914; x=1730401714; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=o2d4foqEUlKX8e/d7INvNR8WQ2O85ZJBZV4qHltV3dM=; b=Elx2XuVYQoNuy91OuEJPe3xlgsi8Ml6j6E+UGz9jTY2vgNrciYfgU5MVbTICaqyomR RGyV2kDahZJAVSq4BTaRnzrwBVG+tCdStCFmxACr1cKWo8fRj73PA2v5z3MwpBOWvcRb bgaV1Nqw/ip9BVwVx65dQHApRAQpMRUD4yewI+GBttGhgAD8QEQwNYSDUNwjZoBPqUUY 1q6kulbNyz2/NRThwi6y6AH1q8LfUu7SexT9YtMPXu3ZK15lR09Fi9ZOUy514ZKhnEP7 K2VugU8HmqxDOH3JH+NVNVljacEGueN8y/QsEXGJ+6IccgAX/I8ZVanJWz3TNIEQSLIn /CRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729796914; x=1730401714; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=o2d4foqEUlKX8e/d7INvNR8WQ2O85ZJBZV4qHltV3dM=; b=lOy2CQcHXzFf4KAk9hIlMbkF1oA5uzwOiCTfuSmqZymjr5SnkoJlKY6ebmnPJxWgye pZP3ZiQhi7VAp5rcVh+wtNTEJBcaoi2NQ6b3tjPTOxA+77WImZbqThoDCn/v8oE3mRga Zkbn61zCM/PUKhKx5p261lblhgIsd1EjedSwo88JL9qy5UHNnYhKrtKxYoi63U/5igEu CcoUQt6eYhiqeNjAq2fHnhIO/ZrS/wwvPmCYXd7DX0NMJthBFThK3RXeHYBneXnBz74C RAPIRX06eYBQzyB0wgqlDuZt7i4CYy5V1FTLRDxBK3STRwmCinSHW8xld2pU8XThEHd+ W4CA== X-Gm-Message-State: AOJu0YylVUjgpJ2u+7m4LNuNGWPPzgvMJpcmlYmGru+URmR0nngUMCI1 r9H84SEEljZwuaVS6a7CG3aVdZVQu6T4yIGRMcgP9syO6RRVMvG9yPrZjHnLEKUxn0jJnuC9nze t X-Google-Smtp-Source: AGHT+IGSHSgU09uxLFd4XIgQ7rL7EBpzHr5CD43U97o5t8SSrQNtQNqtPADhBnvhwHPo0i+prZ9M8A== X-Received: by 2002:a17:903:2283:b0:20c:5b80:930f with SMTP id d9443c01a7336-20fb989041fmr38661495ad.12.1729796914015; Thu, 24 Oct 2024 12:08:34 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20e7f0f364bsm75535385ad.264.2024.10.24.12.08.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Oct 2024 12:08:33 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Tyler Retzlaff , =?UTF-8?q?Morten=20Br=C3=B8rup?= , Bruce Richardson , Chengwen Feng Subject: [PATCH v28 06/13] eal: change rte_exit() output to match rte_log() Date: Thu, 24 Oct 2024 12:02:52 -0700 Message-ID: <20241024190818.172863-7-stephen@networkplumber.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241024190818.172863-1-stephen@networkplumber.org> References: <20200814173441.23086-1-stephen@networkplumber.org> <20241024190818.172863-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The rte_exit() output format confuses the timestamp and coloring options. Change it to use be a single line with proper prefix. Before: [ 0.006481] EAL: Error - exiting with code: 1 Cause: [ 0.006489] Cannot init EAL: Permission denied After: [ 0.006238] EAL: Error - exiting with code: 1 [ 0.006250] EAL: Cannot init EAL: Permission denied Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Bruce Richardson Acked-by: Chengwen Feng --- lib/eal/common/eal_common_debug.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/eal/common/eal_common_debug.c b/lib/eal/common/eal_common_debug.c index 3e77995896..bcfcd6df6f 100644 --- a/lib/eal/common/eal_common_debug.c +++ b/lib/eal/common/eal_common_debug.c @@ -36,15 +36,13 @@ rte_exit(int exit_code, const char *format, ...) va_list ap; if (exit_code != 0) - RTE_LOG(CRIT, EAL, "Error - exiting with code: %d\n" - " Cause: ", exit_code); + EAL_LOG(CRIT, "Error - exiting with code: %d", exit_code); va_start(ap, format); rte_vlog(RTE_LOG_CRIT, RTE_LOGTYPE_EAL, format, ap); va_end(ap); if (rte_eal_cleanup() != 0 && rte_errno != EALREADY) - EAL_LOG(CRIT, - "EAL could not release all resources"); + EAL_LOG(CRIT, "EAL could not release all resources"); exit(exit_code); } -- 2.45.2