DPDK patches and discussions
 help / color / mirror / Atom feed
From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, Anatoly Burakov <anatoly.burakov@intel.com>,
	Lewis Donzis <lew@perftech.com>
Subject: Re: [PATCH] eal: support including mapped memory in core dump
Date: Thu, 24 Oct 2024 23:54:21 +0300	[thread overview]
Message-ID: <20241024235421.5c1bd67e@sovereign> (raw)
In-Reply-To: <20241024093814.779d86c7@hermes.local>

2024-10-24 09:38 (UTC-0700), Stephen Hemminger:
> Having a process set a system global value like coredump_filter via an internal
> call seems like a potential problem. What about other processes on the system?
> It may not even be allowed if using a hardened kernel.
> 
> I would prefer that madvise() be used, and document the required change to
> coredump_filter.

/proc/self/coredump_filter affects only the process and its children.
madvise() done on hugepages will be ignored unless this bit is set.
So this must be done, and it seems convenient to require no user interaction.
If changing /proc/self/coredump_filter is disallowed,
EAL startup will fail and the user will have to go the way you described.
So the current solution:
- is convenient for a typical case
- is still usable in a hypothetical hardening case

On FreeBSD, including hugepages in core dump will require a global setting.
There I've been planning to go your way and have the user configure it,
because it is impossible to restrict to one process.

  reply	other threads:[~2024-10-24 20:54 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-23 23:18 Dmitry Kozlyuk
2024-10-24  2:19 ` Stephen Hemminger
2024-10-24  2:31 ` Stephen Hemminger
2024-10-24  7:07   ` Morten Brørup
2024-10-24  7:22 ` Morten Brørup
2024-10-24  8:25   ` Dmitry Kozlyuk
2024-10-24 12:55 ` Lewis Donzis
2024-10-24 16:38 ` Stephen Hemminger
2024-10-24 20:54   ` Dmitry Kozlyuk [this message]
2024-10-25  0:22     ` Dmitry Kozlyuk
2024-10-25 20:26 ` [PATCH v2 0/2] Hugepage inclusion " Dmitry Kozlyuk
2024-10-25 20:26   ` [PATCH v2 1/2] contigmem: support including mapped buffers " Dmitry Kozlyuk
2024-10-26 11:43     ` Lewis Donzis
2024-10-28 13:26       ` Dmitry Kozlyuk
2024-10-28 13:35         ` Lewis Donzis
2024-11-19 15:48         ` Bruce Richardson
2024-11-19 18:27           ` Dmitry Kozlyuk
2024-11-19 23:09             ` Thomas Monjalon
2024-11-19 15:43     ` Bruce Richardson
2024-10-25 20:26   ` [PATCH v2 2/2] doc: add instruction for including hugepages " Dmitry Kozlyuk
2024-10-26  3:18   ` [PATCH v2 0/2] Hugepage inclusion " Morten Brørup

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241024235421.5c1bd67e@sovereign \
    --to=dmitry.kozliuk@gmail.com \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=lew@perftech.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).