From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id D552045BC3;
	Fri, 25 Oct 2024 17:38:26 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id A32DD40294;
	Fri, 25 Oct 2024 17:38:26 +0200 (CEST)
Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com
 [209.85.214.169])
 by mails.dpdk.org (Postfix) with ESMTP id 1AD724021F
 for <dev@dpdk.org>; Fri, 25 Oct 2024 17:38:26 +0200 (CEST)
Received: by mail-pl1-f169.google.com with SMTP id
 d9443c01a7336-20c767a9c50so18419985ad.1
 for <dev@dpdk.org>; Fri, 25 Oct 2024 08:38:25 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729870705;
 x=1730475505; darn=dpdk.org; 
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:subject:cc:to:from:date:from:to:cc:subject:date
 :message-id:reply-to;
 bh=/dxyEF1VuRmveX1c7gCgNIck8tw8imk3jcklGFasjBk=;
 b=Awb+TWGKU6kt3uwCO6Y5f+mJNHoo0ONcdWipRKbne+p/WfoIYGX0SWUWNdVQmsjSs8
 XbDhplua9XI/iCC5Lenb8l5XVc39LVd+8//QvgnzSh6eciT27YIxnTCnF4rGE/5HpJ3l
 IKMwhte6pdgGalSrAKeDkXgegsgZDhxh6Rmj6LGqpFemhZ1Ls5RGYhloUhNfLhMDMJOD
 FNJHHI3kUN19bjq6pMAXBLtMsw1xg7ZsdxYQ5JlrEGz5QtZ0vaPn/UrpqrTfP/RDFVpt
 OxeP5El9tG9iQJVi78/BCsZsxPGD5uCU4LqbH4skgrXdCoKlv+h3qhVncXr3ZdGeDa/W
 P7ew==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1729870705; x=1730475505;
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=/dxyEF1VuRmveX1c7gCgNIck8tw8imk3jcklGFasjBk=;
 b=RScvbfKo7mdUENi9svGZ3zqgWSxXOzbtHKjR6pXZFZUFksCQbwAB2tDTGvUoBOUlfD
 nXynPzYYlVuelPGP5BPIKtQPQK54OfPVYIqdynXUmDB/a2dG5GwLUnX/usJDL1f5W9Yj
 SNuIeAK+c/3Udq6SblBDleNBRmgRsCnPgULY5mHLDVizzw1LEtR6KgE/XiD/oIJDZaOy
 EKsIbUQ6eygYfci778VDx/44pnIO9j586SRykYMAh9VhpWhMRnE+s+I4Kxdzp9Di2Of7
 avDMKaooTTRLiwz1DGjHbq0BX3PUK6RNVZb8Xx6P/ACHHkELCCUCeCuyS+yoNhJyFvng
 m63g==
X-Gm-Message-State: AOJu0YxFvgPjR2W3jzedvCPIdYRfNqNOJZjwNmm2QTp8flkXV1ymXgDA
 dUsRZ9zNFKidH3QhzAVwwVHfLnw/ND5yB9jSby62gFZaRVNgUdTyrFOTXkfwo3Q=
X-Google-Smtp-Source: AGHT+IFW8tpatQrURWdrBvNc7ydC9UCylni5sBUynUx4a0tsELx+iYP69zRoSF9RNk6llz8fUAAjFA==
X-Received: by 2002:a17:903:22c1:b0:20b:920e:8fd3 with SMTP id
 d9443c01a7336-20fa9e9ae97mr135931165ad.35.1729870705129; 
 Fri, 25 Oct 2024 08:38:25 -0700 (PDT)
Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226])
 by smtp.gmail.com with ESMTPSA id
 d9443c01a7336-210bbf71fb8sm10775605ad.107.2024.10.25.08.38.24
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 25 Oct 2024 08:38:24 -0700 (PDT)
Date: Fri, 25 Oct 2024 08:38:22 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Akhil Goyal <gakhil@marvell.com>
Cc: <dev@dpdk.org>, <thomas@monjalon.net>, <david.marchand@redhat.com>,
 <hemant.agrawal@nxp.com>, <jerinj@marvell.com>, <hkalra@marvell.com>,
 <sachin.saxena@oss.nxp.com>, <ferruh.yigit@amd.com>
Subject: Re: [PATCH v5 2/9] raw/cnxk_rvu_lf: add API to get NPA/SSO pffunc
Message-ID: <20241025083822.6cf274bf@hermes.local>
In-Reply-To: <20241024131759.3337333-3-gakhil@marvell.com>
References: <20241024130130.3330978-1-gakhil@marvell.com>
 <20241024131759.3337333-1-gakhil@marvell.com>
 <20241024131759.3337333-3-gakhil@marvell.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Thu, 24 Oct 2024 18:47:52 +0530
Akhil Goyal <gakhil@marvell.com> wrote:

> +/**
> + * @file cnxk_rvu_lf_driver.h
> + *
> + * Marvell RVU LF raw PMD specific structures and interface
> + *
> + * This API allows external driver/application to manage RVU LF device
> + * in user space along with installing interrupt handlers for low latency signal processing.
> + */
> +
> +#ifdef __cplusplus
> +extern "C" {
> +#endif
> +
> +/**
> + * Obtain NPA PF func
> + *
> + * @return
> + *   Returns NPA pf_func on success, 0 in case of invalid pf_func.
> + */
> +__rte_internal
> +uint16_t rte_pmd_rvu_lf_npa_pf_func_get(void);
> +
> +/**
> + * Obtain SSO PF func
> + *
> + * @return
> + *   Returns SSO pf_func on success, 0 in case of invalid pf_func.
> + */
> +__rte_internal
> +uint16_t rte_pmd_rvu_lf_sso_pf_func_get(void);
> +
> +#ifdef __cplusplus
> +}
> +#endif

If these functions are used by applications, they should be in experimental
section not internal. Applications shouldn't be calling internal routines.