From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B902345BCB; Fri, 25 Oct 2024 18:51:14 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5EC7240264; Fri, 25 Oct 2024 18:51:14 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by mails.dpdk.org (Postfix) with ESMTP id 67FC340156 for ; Fri, 25 Oct 2024 18:51:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1729875073; x=1761411073; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=RzAPd+51fNWrFST2GC1v4wILZO/twAEs1VYCVS180Uc=; b=RAq9uO+z1rq6MlaTk2r5LZOAmA8KMhlwI+eo/p2HV9sX+7ILjm/Z7f6I TZn5sap2uDFj+xU7SwQNpxYBoPUWK0c8i6WQqasZl2jIKEsiOd0xkoZ+m zTjsFWoyYFoSE/dvIzZhyticK+mV91Ufk4trPJpagKFpeVZEgYquQh+Uy 5l6BuP57CBafUlXWHB30Pnt3YgrBjJAMoRb0Ntm2iFvL1JfuO5TnQkp6D /Gr/FqGo7qP14vM5WD7JeBoOlLL0uWLTPFogAsJo7FyJ9Vlq6Ks/PArXS 4CjrrpFyi0qNt9fjPF3cyQWw+1RNRyyoVjZo5epwvCFJbeunjsiKRqtqP w==; X-CSE-ConnectionGUID: Qgansh4JRGeDSKp436pIMg== X-CSE-MsgGUID: eNW4C9PSQXCTsr+Zu+M3UA== X-IronPort-AV: E=McAfee;i="6700,10204,11236"; a="54956123" X-IronPort-AV: E=Sophos;i="6.11,232,1725346800"; d="scan'208";a="54956123" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Oct 2024 09:50:34 -0700 X-CSE-ConnectionGUID: Y0aXJVL/QniZJ/x28NYejQ== X-CSE-MsgGUID: W2pYWNU8TnydUJOTXqhy6Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,232,1725346800"; d="scan'208";a="118417469" Received: from unknown (HELO silpixa00401385.ir.intel.com) ([10.237.214.25]) by orviesa001.jf.intel.com with ESMTP; 25 Oct 2024 09:50:34 -0700 From: Bruce Richardson To: dev@dpdk.org Cc: david.marchand@redhat.com, Bruce Richardson Subject: [PATCH v2 0/6] Reduce scope address-of-packed-member warning Date: Fri, 25 Oct 2024 17:50:13 +0100 Message-ID: <20241025165020.1856733-1-bruce.richardson@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241017142214.1669370-1-bruce.richardson@intel.com> References: <20241017142214.1669370-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The warning for address-of-packed-member was being disabled globally in DPDK. While for drivers which need to access hardware-defined data-structures the use of packed may make sense, for normal libs and applications the use of packed data should be generally avoided. This patchset initially applies some fixes for cases where we are unnecessarily causing the warning to trigger. Thereafter the 6th patch removes the global enabling of the warning and replaces it with more selective disabling for drivers and for a couple of other components which have not yet been fixed. v2: * rebase on latest main (rte_ip.h -> rte_ip4.h) * remove unnecessary 0-check in IP checksum calc Bruce Richardson (6): ip_frag: remove use of unaligned variable efd: remove unnecessary packed attributes bus/ifpga: remove packed attribute pipeline: remove packed attribute net: add smaller IPv4 cksum function for simple cases build: limit scope of packed member warning disabling app/test-eventdev/test_pipeline_common.c | 25 +----------- app/test-pmd/icmpecho.c | 23 +---------- app/test-pmd/txonly.c | 22 +---------- app/test/packet_burst_generator.c | 49 +----------------------- app/test/test_reassembly_perf.c | 29 +------------- config/meson.build | 1 - drivers/bus/ifpga/bus_ifpga_driver.h | 2 +- drivers/meson.build | 9 +++-- examples/ipsec-secgw/meson.build | 6 +++ lib/efd/rte_efd.c | 4 +- lib/ip_frag/rte_ipv4_reassembly.c | 4 +- lib/net/rte_ip4.h | 32 ++++++++++++++++ lib/pipeline/rte_table_action.c | 2 +- lib/vhost/meson.build | 5 ++- 14 files changed, 59 insertions(+), 154 deletions(-) -- 2.43.0