From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 48EE645BCB; Fri, 25 Oct 2024 19:58:47 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F25A840A84; Fri, 25 Oct 2024 19:58:03 +0200 (CEST) Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) by mails.dpdk.org (Postfix) with ESMTP id 1669D409FA for ; Fri, 25 Oct 2024 19:57:58 +0200 (CEST) Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-7db90a28cf6so2214143a12.0 for ; Fri, 25 Oct 2024 10:57:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1729879077; x=1730483877; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wGBoRycky+Hxi1ZCIpwWoxDioS0ofUHY4fuHT13wH2A=; b=H8HekimeSQzmUjD9FIx0mQhu76E69IfyXSBsiKDmD8yfKltdi1aM8vSW5O9b04281R +XQg9H07OtgHrlamLrRAAftsKc8h5lr3BM1+P2ZZO9O0GRkUp++VZvEG3kgkTkXohU3V LeFq6wYpLChPYUlIc7rf+LOSUL5KfCFaC3IxU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729879077; x=1730483877; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wGBoRycky+Hxi1ZCIpwWoxDioS0ofUHY4fuHT13wH2A=; b=Es0XM+oBLvH7ZyQRL2uuaXf50D2AiIQHvdRtaa8iAX9F12/YHPgACvMzYuDSTvXwcP HmPlbcIwC5i1W/EOgrqqu2rZKt76vFnM6c+WxCzlKd8no77UXw26tHd78M4pTrexCr5O t4qcCGw45RLiYVis5iasK64deSFVjHtFFBCJuTm8MRfjkDXcrxWt80dGOlLDKbet1S7G TXe9WiV976UJOBVx4h230xQ04JopGMGfstM8JRx+O9UnzNEl4zGfVRrnH99L+LeD7dva MNAWDJvDbRmTWK8kr5Ryo7/Y5B2+P4KWXDtKSadfz18kNtX9+m92CZETa50SLnYUuKtX Hxzw== X-Gm-Message-State: AOJu0YzlaYb5gBdU0f1xOeP1F5XvpDjL/VzXQD1PWXjCamP180ldoSoX dGs9eXQ556V0tBqqlskN1yYDLJTBwj2XuLJnl5+kOi0V71IWDT6FFkgWt3+wzsi84E1UD7r22pW u5rebebsCbAQO1bChwAvU3DquBnfP7u8B620A8VyrrEUNOMOV8QYphV7W5BTD+Mf4WoGVMRkVsB KBDTmu3vUFRI89BEZ3ALmdYj4fDv6fvZ0= X-Google-Smtp-Source: AGHT+IHHXWzsaxPZ+v2R2bet0Q6wyCDWJGX1Gddk7M48lfHXAKkerJAih4BZht+LpBbzxq7VMr8Pug== X-Received: by 2002:a17:902:da81:b0:20c:ea22:3317 with SMTP id d9443c01a7336-210c5aac7f6mr6085535ad.29.1729879076488; Fri, 25 Oct 2024 10:57:56 -0700 (PDT) Received: from C02GC2QQMD6T.wifi.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-210bc02ebd8sm11924335ad.210.2024.10.25.10.57.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Oct 2024 10:57:55 -0700 (PDT) From: Ajit Khaparde To: dev@dpdk.org Cc: Kishore Padmanabha , Mike Baucom Subject: [PATCH 09/13] net/bnxt: disable VLAN filter when TF is enabled Date: Fri, 25 Oct 2024 10:57:34 -0700 Message-Id: <20241025175738.99564-10-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) In-Reply-To: <20241025175738.99564-1-ajit.khaparde@broadcom.com> References: <20241025175738.99564-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Kishore Padmanabha For p7 platform, the vlan filter and strip is disabled if the truflow is enabled on the platform. Signed-off-by: Kishore Padmanabha Reviewed-by: Mike Baucom --- drivers/net/bnxt/bnxt_ethdev.c | 6 +++++- drivers/net/bnxt/bnxt_rxq.c | 17 +++++++++++------ 2 files changed, 16 insertions(+), 7 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 890c9f8b45..d3ea4ed539 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -2964,7 +2964,7 @@ bnxt_vlan_offload_set_op(struct rte_eth_dev *dev, int mask) { uint64_t rx_offloads = dev->data->dev_conf.rxmode.offloads; struct bnxt *bp = dev->data->dev_private; - int rc; + int rc = 0; rc = is_bnxt_in_error(bp); if (rc) @@ -2974,6 +2974,10 @@ bnxt_vlan_offload_set_op(struct rte_eth_dev *dev, int mask) if (!dev->data->dev_started) return 0; + /* For P7 platform, cannot support if truflow is enabled */ + if (BNXT_TRUFLOW_EN(bp) && BNXT_CHIP_P7(bp)) + return rc; + if (mask & RTE_ETH_VLAN_FILTER_MASK) { /* Enable or disable VLAN filtering */ rc = bnxt_config_vlan_hw_filter(bp, rx_offloads); diff --git a/drivers/net/bnxt/bnxt_rxq.c b/drivers/net/bnxt/bnxt_rxq.c index 249fe7f6e5..8b8bc6584a 100644 --- a/drivers/net/bnxt/bnxt_rxq.c +++ b/drivers/net/bnxt/bnxt_rxq.c @@ -28,18 +28,23 @@ uint64_t bnxt_get_rx_port_offloads(struct bnxt *bp) RTE_ETH_RX_OFFLOAD_UDP_CKSUM | RTE_ETH_RX_OFFLOAD_TCP_CKSUM | RTE_ETH_RX_OFFLOAD_KEEP_CRC | - RTE_ETH_RX_OFFLOAD_VLAN_FILTER | - RTE_ETH_RX_OFFLOAD_VLAN_EXTEND | RTE_ETH_RX_OFFLOAD_SCATTER | RTE_ETH_RX_OFFLOAD_RSS_HASH; - if ((BNXT_CHIP_P7(bp) && !bnxt_compressed_rx_cqe_mode_enabled(bp)) || - BNXT_CHIP_P5(bp)) + /* In P7 platform if truflow is enabled then vlan offload is disabled*/ + if (!(BNXT_TRUFLOW_EN(bp) && BNXT_CHIP_P7(bp))) + rx_offload_capa |= (RTE_ETH_RX_OFFLOAD_VLAN_FILTER | + RTE_ETH_RX_OFFLOAD_VLAN_EXTEND); + + + if (!bnxt_compressed_rx_cqe_mode_enabled(bp)) rx_offload_capa |= RTE_ETH_RX_OFFLOAD_TCP_LRO; if (bp->flags & BNXT_FLAG_PTP_SUPPORTED) rx_offload_capa |= RTE_ETH_RX_OFFLOAD_TIMESTAMP; - if (bp->vnic_cap_flags & BNXT_VNIC_CAP_VLAN_RX_STRIP) - rx_offload_capa |= RTE_ETH_RX_OFFLOAD_VLAN_STRIP; + if (bp->vnic_cap_flags & BNXT_VNIC_CAP_VLAN_RX_STRIP) { + if (!(BNXT_TRUFLOW_EN(bp) && BNXT_CHIP_P7(bp))) + rx_offload_capa |= RTE_ETH_RX_OFFLOAD_VLAN_STRIP; + } if (BNXT_TUNNELED_OFFLOADS_CAP_ALL_EN(bp)) rx_offload_capa |= RTE_ETH_RX_OFFLOAD_OUTER_IPV4_CKSUM | -- 2.39.5 (Apple Git-154)