From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A24A045BCB; Fri, 25 Oct 2024 19:57:57 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BCC3C40667; Fri, 25 Oct 2024 19:57:48 +0200 (CEST) Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by mails.dpdk.org (Postfix) with ESMTP id 7603840655 for ; Fri, 25 Oct 2024 19:57:46 +0200 (CEST) Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-20c803787abso18271735ad.0 for ; Fri, 25 Oct 2024 10:57:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1729879065; x=1730483865; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xeq5JUB1b6HXK+w9i2aJfKsRO1Hes6bBbc2MvfUkJbY=; b=F3i6qyH88XAc8pZlgHIO0UWkdYrXywZZchrQq2TLqQU9XydIPUJF7CbV6J1A1hCQVK uvpd+X/sLr8Cf7eQVmq5xBg0xaZRJ6KVjzC7WBNb8gDN540M6IdeNa5Wmig8qEVxVgh0 gAN1pl54yT+N6IF0oxX65m5Rd1mdc1RAOxaBw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729879065; x=1730483865; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xeq5JUB1b6HXK+w9i2aJfKsRO1Hes6bBbc2MvfUkJbY=; b=DMImZa8fnjwV7K+m3IqS1zldi7GrXOfMXrr78tDkT2s6WXKf61955p9yOf62oZFLE0 t7S+8lpwYbvffgv1e4dtUW7BNnVwFMjFcJRpEwAGOcIyJr7X5IENFVictNMnKg4lgkGi rUTfFSjM8O6WexZg9c6WQ0v06ORSKrm/+noKCW4A+pTbgLwUUyZ81RJFEGqloDXXm9hJ 1/orFHikhDPb4NLmk/PIII6nz3zuiXzMQoBo+H5/Ze3xQcfDaUx76Er0zo+aa0rAs9X3 1Xn2TscVDZXkaQ4wad2qtEToZsIZbH+/46fOW6K9sqACxYngZmhfZiSr6vAvQ8qKZ19N UggA== X-Gm-Message-State: AOJu0YxrOF0DHo5U+WDcZXX1P/rhfTbYhSzhjzgzq3fU8ewlAfAkUhjm rEqolQ/eDhaZhc0Ncw/HkTlwVMr2qWv/5+R1DHNzr1eK8YmosN12qsRJSY+IyIPWkgZoilW5mpG KcHBCx8f6Mkpcdnl8bl3ZIFiHma/i6RT/ni4/CzZ8GOPmJ9408rbKFuF5qhg8l4D55dE2J1gpMr 6JP6IdIYUXw8bRfOpgfMxhJRbRhYzjcq0= X-Google-Smtp-Source: AGHT+IFfnREUdcHRlzNCQV+MJXEA+4lZTVjWa5wpUaWL/X/EcuNAW6f10xV8Cc3nyDtqF58e9RjaAw== X-Received: by 2002:a17:902:d487:b0:20c:68af:a4e3 with SMTP id d9443c01a7336-210c5a466eamr5512105ad.22.1729879064889; Fri, 25 Oct 2024 10:57:44 -0700 (PDT) Received: from C02GC2QQMD6T.wifi.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-210bc02ebd8sm11924335ad.210.2024.10.25.10.57.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Oct 2024 10:57:44 -0700 (PDT) From: Ajit Khaparde To: dev@dpdk.org Cc: Peter Spreadborough , stable@dpdk.org, Kishore Padmanabha Subject: [PATCH 02/13] net/bnxt: fix bad action offset in Tx bd Date: Fri, 25 Oct 2024 10:57:27 -0700 Message-Id: <20241025175738.99564-3-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) In-Reply-To: <20241025175738.99564-1-ajit.khaparde@broadcom.com> References: <20241025175738.99564-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Peter Spreadborough This change ensures that the high part of an action table entry offset stored in the Tx BD is set correctly. A bad value will cause the PDCU to abort a fetch an may stall the pipeline. Fixes: 527b10089cc5 ("net/bnxt: optimize Tx completion handling") Cc: stable@dpdk.org Signed-off-by: Peter Spreadborough Reviewed-by: Kishore Padmanabha Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_txr.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/net/bnxt/bnxt_txr.c b/drivers/net/bnxt/bnxt_txr.c index 38f858f27f..c82b11e733 100644 --- a/drivers/net/bnxt/bnxt_txr.c +++ b/drivers/net/bnxt/bnxt_txr.c @@ -308,10 +308,15 @@ static uint16_t bnxt_start_xmit(struct rte_mbuf *tx_pkt, */ txbd1->kid_or_ts_high_mss = 0; - if (txq->vfr_tx_cfa_action) - txbd1->cfa_action = txq->vfr_tx_cfa_action; - else - txbd1->cfa_action = txq->bp->tx_cfa_action; + if (txq->vfr_tx_cfa_action) { + txbd1->cfa_action = txq->vfr_tx_cfa_action & 0xffff; + txbd1->cfa_action_high = (txq->vfr_tx_cfa_action >> 16) & + TX_BD_LONG_CFA_ACTION_HIGH_MASK; + } else { + txbd1->cfa_action = txq->bp->tx_cfa_action & 0xffff; + txbd1->cfa_action_high = (txq->bp->tx_cfa_action >> 16) & + TX_BD_LONG_CFA_ACTION_HIGH_MASK; + } if (tx_pkt->ol_flags & RTE_MBUF_F_TX_TCP_SEG || tx_pkt->ol_flags & RTE_MBUF_F_TX_UDP_SEG) { -- 2.39.5 (Apple Git-154)