From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2022045BCB; Fri, 25 Oct 2024 19:58:12 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4C70240649; Fri, 25 Oct 2024 19:57:54 +0200 (CEST) Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by mails.dpdk.org (Postfix) with ESMTP id AB19D4066D for ; Fri, 25 Oct 2024 19:57:49 +0200 (CEST) Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-20c714cd9c8so22646585ad.0 for ; Fri, 25 Oct 2024 10:57:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1729879068; x=1730483868; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+mUGrys51rrrGRcEsltsl7C5BlGSp1s3k7WzJGhOVLE=; b=Gtur705E97ZNq2sXIPHS8YPbjx4pwK6LiO5021e9pJDO63yiCF2k5mvET54dXk37Ap 7vcNImYrfR6JqPAujB4YRrrKNg+aziRaM5EGFV+PYBU/o8coD+6+qgkg0z13m1kvpgXl GkyYLwYNcCuW4oTa4NC2Bm0iifqHtBYzaTtlA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729879068; x=1730483868; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+mUGrys51rrrGRcEsltsl7C5BlGSp1s3k7WzJGhOVLE=; b=RhluDvqLdFBiHXuRjXYIU+qRpFHvmcQEvUDn0YHjeKyugxpGY15R3PwNXuo1NOiSOy 7CsUd7js9nka76YXibv4eA9JNGMN/q/J7Y/kppBJaoov6Ai7CTzHNq6kotHEMZ3x3pUK NYblashTGs899AEi1DnLB2n/y8RNyN5MTorCWe6QU/HXpE/XIYAgnSf1+hAV8jjaMM3W m1S4mkLX6PGqqKdKIzuLcgvTF1cSgKBBfgf5X7guoZRs7uOyGuCnHrTPvE3PT/l6CN1P joG6kzxvs1TOv9IrymshirJ17FoD2pEYAqG2fLa4vzbCLwKZcMhKh0JGHKo29Hr0TXzr xkTQ== X-Gm-Message-State: AOJu0YyFn7pt35Lt0omSLZ0EmXsy5MTKVuTmsxdDk0TfZ8cxs6W+EfXR /0ky6ros+43rNbtAz/VET8mk+94BEjsi9B+CnHBHHIEaJu4ITo0M/lX1fx4bo8LmVen4cEJsrt6 KE2kcFIcnA1gAT29iY2dTf7wGVQx5k0v4IPa0iy4t9lG9tDOfCSW7bZSTrhtJirdNP99KUZqJOB HHuknpeJIKrBMwIBu6QqrW4zoS61Ulqbg= X-Google-Smtp-Source: AGHT+IEDygm5631LilW1IU/9CZaPr4Igf/909xlRrrtEcOQ9WS+pywIOSC4stBpxGcdWMI7Y9LGV/w== X-Received: by 2002:a17:902:fc8e:b0:20c:7485:891c with SMTP id d9443c01a7336-20fa9eb5b1dmr156502995ad.54.1729879068132; Fri, 25 Oct 2024 10:57:48 -0700 (PDT) Received: from C02GC2QQMD6T.wifi.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-210bc02ebd8sm11924335ad.210.2024.10.25.10.57.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Oct 2024 10:57:47 -0700 (PDT) From: Ajit Khaparde To: dev@dpdk.org Cc: Somnath Kotur Subject: [PATCH 04/13] net/bnxt: add check for number of segs Date: Fri, 25 Oct 2024 10:57:29 -0700 Message-Id: <20241025175738.99564-5-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) In-Reply-To: <20241025175738.99564-1-ajit.khaparde@broadcom.com> References: <20241025175738.99564-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Somnath Kotur If the application passes incorrect number of segs for a Tx pkt i.e. sets it to 5 while actually sending down only a single mbuf, this could escape all the existing driver checks and driver could end up sending down garbage TX BDs to the HW. This in turn could lead to a Tx pipeline stall. Fix it by validating the number of segs passed for the Tx pkt against what is actually set by the application to prevent this. Signed-off-by: Somnath Kotur Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_txr.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/drivers/net/bnxt/bnxt_txr.c b/drivers/net/bnxt/bnxt_txr.c index 6d7e9962ce..51d3689e9c 100644 --- a/drivers/net/bnxt/bnxt_txr.c +++ b/drivers/net/bnxt/bnxt_txr.c @@ -194,6 +194,21 @@ bnxt_check_pkt_needs_ts(struct rte_mbuf *m) return false; } +static bool +bnxt_invalid_nb_segs(struct rte_mbuf *tx_pkt) +{ + uint16_t nb_segs = 1; + struct rte_mbuf *m_seg; + + m_seg = tx_pkt->next; + while (m_seg) { + nb_segs++; + m_seg = m_seg->next; + } + + return (nb_segs != tx_pkt->nb_segs); +} + static uint16_t bnxt_start_xmit(struct rte_mbuf *tx_pkt, struct bnxt_tx_queue *txq, uint16_t *coal_pkts, @@ -221,6 +236,9 @@ static uint16_t bnxt_start_xmit(struct rte_mbuf *tx_pkt, if (unlikely(is_bnxt_in_error(txq->bp))) return -EIO; + if (unlikely(bnxt_invalid_nb_segs(tx_pkt))) + return -EINVAL; + long_bd = bnxt_xmit_need_long_bd(tx_pkt, txq); nr_bds = long_bd + tx_pkt->nb_segs; -- 2.39.5 (Apple Git-154)