From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0F58845BCB; Fri, 25 Oct 2024 19:58:19 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 58957406BA; Fri, 25 Oct 2024 19:57:55 +0200 (CEST) Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by mails.dpdk.org (Postfix) with ESMTP id 2D42340650 for ; Fri, 25 Oct 2024 19:57:51 +0200 (CEST) Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-20c8c50fdd9so21382535ad.0 for ; Fri, 25 Oct 2024 10:57:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1729879070; x=1730483870; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6ja6CwJEciD+8XYk5tRZEn5yghnsonZ3Y+c4t/l9rMs=; b=I23Ibmz6A//wn1XjyzVWFgG2kldB/rM1YJFqrHwXvRsOvA1Jsuo0jPjQxTwfhwe5A2 NR2pawu2bCUGKMZtJmFkMIpYGdYHxkRHwdQh1p2NQqnFggQQPlMRpzGEddw6geC3Bbci o/naUHIsSo0EdC0dN6wjOSRKuWBgdpH0P/O/4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729879070; x=1730483870; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6ja6CwJEciD+8XYk5tRZEn5yghnsonZ3Y+c4t/l9rMs=; b=evai9sSBLgn7rtm4uC3GRFxdNms3vK0N5IwciiduFFlZbxdfSu1JSC0TWnDDj8Lykq L/lv5cBFYdLZvQddL8NsZ1QqQ0CPRwznOgANT896YUPj7znOVnoKtUxH3cVjb/IjTHC+ pYpgFFZjqCa6uj6XlC4l5nn6E66X3jgTnlm4z0O174LcZBT5dyUbuDXU1lgZmJNbDZva ClCkqKHfQmi/XLPYxKaxbs3g4VYo7WNdd7Wnvh40GgnrJIuSyq/jlv0cOx+QslnvFnd2 LJkZzR9xRcfuH/3uSEG4p4VURxt6O6egx96e10fRzabcmTK+HPevY/MrY1cceDpKMuEo k2mA== X-Gm-Message-State: AOJu0YyKB3+yvBDcRN8/c4PqAeDU1yhcbX9Q75b+O7mxpKoYGa75F90K j2O9H6VlMQswq2scIZUhek3tmHjL0xCLNj/JMWSEeToZCgMgMJ4AE+YGRpCBiX4st1fB/oYJ0Ft raLGXdS3GFerjDHDP2icDaBSS4frCrvgLV6PvrbVTa+VdnGDzQKaziOhQuJuCQRJiZmBwDvkG+N 5YjYGHRJaaUlhgOrv8AQg6x4MwOIUTqoE= X-Google-Smtp-Source: AGHT+IGwo5htlS+yfj83bAv4v++ZaGGXGiM5PV7iXkFk5ACYFqp+0HfoykhxFeKc4Dz/rrQxNJf0Ig== X-Received: by 2002:a17:902:db0f:b0:20c:c482:1d72 with SMTP id d9443c01a7336-210c5a46f96mr5466805ad.20.1729879069772; Fri, 25 Oct 2024 10:57:49 -0700 (PDT) Received: from C02GC2QQMD6T.wifi.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-210bc02ebd8sm11924335ad.210.2024.10.25.10.57.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Oct 2024 10:57:48 -0700 (PDT) From: Ajit Khaparde To: dev@dpdk.org Cc: Kalesh AP , Somnath Kotur Subject: [PATCH 05/13] net/bnxt: add check for invalid mbuf passed by application Date: Fri, 25 Oct 2024 10:57:30 -0700 Message-Id: <20241025175738.99564-6-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) In-Reply-To: <20241025175738.99564-1-ajit.khaparde@broadcom.com> References: <20241025175738.99564-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Kalesh AP If the application passes invalid mbuf for a Tx pkt, this could escape all the existing driver checks and driver could end up sending down invalid TX BDs to the HW. This in turn could lead to a FW reset. Fix by validating the "mbuf->buf_iova" or "mbuf->buf_addr" passed for the Tx pkt by the application. Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur --- drivers/net/bnxt/bnxt_txr.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/drivers/net/bnxt/bnxt_txr.c b/drivers/net/bnxt/bnxt_txr.c index 51d3689e9c..4e9e377d5b 100644 --- a/drivers/net/bnxt/bnxt_txr.c +++ b/drivers/net/bnxt/bnxt_txr.c @@ -209,6 +209,25 @@ bnxt_invalid_nb_segs(struct rte_mbuf *tx_pkt) return (nb_segs != tx_pkt->nb_segs); } +static int bnxt_invalid_mbuf(struct rte_mbuf *mbuf) +{ + uint32_t mbuf_size = sizeof(struct rte_mbuf) + mbuf->priv_size; + const char *reason; + + if (unlikely(rte_eal_iova_mode() != RTE_IOVA_VA && + rte_eal_iova_mode() != RTE_IOVA_PA)) + return 0; + + if (unlikely(rte_mbuf_check(mbuf, 1, &reason))) + return -EINVAL; + + if (unlikely(mbuf->buf_iova < mbuf_size || + (mbuf->buf_iova != rte_mempool_virt2iova(mbuf) + mbuf_size))) + return -EINVAL; + + return 0; +} + static uint16_t bnxt_start_xmit(struct rte_mbuf *tx_pkt, struct bnxt_tx_queue *txq, uint16_t *coal_pkts, @@ -236,6 +255,9 @@ static uint16_t bnxt_start_xmit(struct rte_mbuf *tx_pkt, if (unlikely(is_bnxt_in_error(txq->bp))) return -EIO; + if (unlikely(bnxt_invalid_mbuf(tx_pkt))) + return -EINVAL; + if (unlikely(bnxt_invalid_nb_segs(tx_pkt))) return -EINVAL; -- 2.39.5 (Apple Git-154)